Add diagnostics for sporadic failures in a <format> test - #2494
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJan 22, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
January 20, 2022 05:06
Charlie Barto (barcharcraz)
approved these changes
Jan 20, 2022
Igor Zhukov (fsb4000)
approved these changes
Jan 20, 2022
| cerr << " str1: \"" << str1 << "\"\n"; | ||
| cerr << "expected: \"" << expected << "\"\n"; | ||
| cerr << "DO NOT IGNORE/RERUN THIS FAILURE.\n"; | ||
| cerr << "You must report it to the STL maintainers.\n"; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
We could, but I don't think it's necessary. charconv doesn't perform floating-point operations, especially the hexfloat codepath. The FPU's transistors are totally cold.
Casey Carter (CaseyCarter)
approved these changes
Jan 20, 2022
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This was referenced Feb 12, 2022
Alex Guteniev (AlexGuteniev)
added a commit
to AlexGuteniev/STL
that referenced
this pull request
Feb 15, 2022
…icrosoft#2494)" This reverts commit 1035141.
Stephan T. Lavavej (StephanTLavavej)
pushed a commit
that referenced
this pull request
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sporadic failure mentioned in #2449 has happened twice, in unrelated PRs, affecting both x86 and x64 (but curiously affecting clang-cl both times). We can't figure out why this is happening, so printing the return value of
format()might help.The output will look like this (with 2,000 zeroes, and there will be some difference between the strings):