Revert "Add diagnostics for sporadic failures in a <format> test" - #2570
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoMar 2, 2022
Conversation
…icrosoft#2494)" This reverts commit 1035141.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 15, 2022
Member
|
Charlie Barto (@barcharcraz) would like for this to be merged some time after #2569. (Perhaps one or two weeks?) |
Casey Carter (CaseyCarter)
approved these changes
Feb 16, 2022
Contributor
Author
|
Maybe not so fast then? We've seen the failure three times in three months. |
Member
|
I think one month would be plenty (personally I'd be happy with 2 weeks). The diagnostics don't change the test coverage, they just make investigation easier. |
Member
|
Charlie said he's happy with 2 weeks, so Feb 28 or later. Moving to Ready To Merge so we'll pick this up in the next batch (I don't anticipate merging on Thu/Fri). |
Charlie Barto (barcharcraz)
approved these changes
Feb 24, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for removing this temporary machinery! ⚙️ ✅ 🎉 |
Alex Guteniev (AlexGuteniev)
deleted the
revert-2494-format-hexfloat-test
branch
March 2, 2022 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2494