cache __std_get_cvt output - #2596
Closed
Igor Zhukov (fsb4000) wants to merge 3 commits into
Closed
Igor Zhukov (fsb4000) wants to merge 3 commits into
Igor Zhukov (fsb4000) wants to merge 3 commits into
Conversation
…UM_AVAILABLE (64) per process
Stephan T. Lavavej (StephanTLavavej)
requested changes
Mar 1, 2022
Comment on lines
+539
to
+540
| #pragma warning(push) | ||
| #pragma warning(disable : 4640) // '_Cvt_cache': construction of local static object is not thread-safe |
There was a problem hiding this comment.
This warning indicates that you're using Magic Statics. (It's confusingly phrased - what's happening is that the STL's test suite disables Magic Statics and enables this warning with /w14640 /Zc:threadSafeInit-. This ensures that anything that would be thread-safe via Magic Statics, instead emits this warning.)
We avoid Magic Statics in the STL: #673 (comment)
Thus I believe we need another mechanism here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2594
Is the warning C4640 correct at all?
https://en.cppreference.com/w/cpp/language/storage_duration#Static_local_variables