Cache _Fmt_codec<char, false> - #2600
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoMar 28, 2022
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Charlie Barto (barcharcraz)
approved these changes
Mar 8, 2022
Charlie Barto (barcharcraz)
left a comment
Contributor
There was a problem hiding this comment.
This looks great to me, though someone who understands more about object lifetime should look at the caching component.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
S. B. Tam (cpplearner)
force-pushed
the
patch-1
branch
from
March 19, 2022 11:32
9acb5e0 to
26019c4
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 23, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2596.
Fixes #2594
I thought of simply returning a global
_Fmt_codec<char>object in_Get_fmt_codec<char>(), but I think this might makestd::formatunusable in initialization of variable template instances. (The standard says that such initializations are unordered with other initializations.)