Implement P2520R0: move_iterator<T*> should be a random access iterator - #2958
Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits intoAug 3, 2022
Merged
Conversation
nicole mazzuca (strega-nil-ms)
force-pushed
the
p2520
branch
from
July 27, 2022 18:42
363bf89 to
8ad7ba1
Compare
nicole mazzuca (strega-nil-ms)
force-pushed
the
p2520
branch
from
July 27, 2022 18:46
8ad7ba1 to
3e54a6d
Compare
Casey Carter (CaseyCarter)
suggested changes
Jul 27, 2022
Casey Carter (CaseyCarter)
self-requested a review
July 27, 2022 21:22
Casey Carter (CaseyCarter)
approved these changes
Jul 27, 2022
Contributor
|
The test runner has found the pertinent libc++ test that you'll need to skip. |
Casey Carter (CaseyCarter)
suggested changes
Jul 28, 2022
Michael Schellenberger Costa (miscco)
approved these changes
Jul 29, 2022
Casey Carter (CaseyCarter)
self-requested a review
July 29, 2022 21:17
Casey Carter (CaseyCarter)
approved these changes
Jul 29, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 30, 2022
Member
|
nicole mazzuca (@strega-nil-ms) Casey Carter (@CaseyCarter) I pushed changes for two trivial nitpicks and one copy-pasta, FYI. |
Casey Carter (CaseyCarter)
approved these changes
Aug 1, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this C++23 feature and moving towards feature completeness! 📉 😹 🚀 |
nicole mazzuca (strega-nil)
added a commit
to strega-nil/stl
that referenced
this pull request
Aug 6, 2022
…ator (microsoft#2958) Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…ator (microsoft#2958) Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2939