Add __cpp_lib_concepts guard for __cpp_lib_move_iterator_concept - #2994
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoAug 5, 2022
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
August 3, 2022 23:51
Casey Carter (CaseyCarter)
suggested changes
Aug 4, 2022
Only the actual definition and test for `__cpp_lib_concepts` still mention `__EDG__` to avoid circularity. In `P0980R1_constexpr_strings`, explain how the `equalRanges` workaround should be removed.
Cite GH 395 by `__cpp_lib_algorithm_iterator_requirements`.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from Casey Carter (CaseyCarter)
August 4, 2022 01:05
Casey Carter (CaseyCarter)
approved these changes
Aug 4, 2022
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Thank you for crushing this inconsistency (and apologies for scope creeping your ~10 line PR).
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 4, 2022
Merged
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
nicole mazzuca (strega-nil)
pushed a commit
to strega-nil/stl
that referenced
this pull request
Aug 6, 2022
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fix
__cpp_lib_conceptsguard for__cpp_lib_move_iterator_concept.move_iterator<T*>should be a random access iterator #2958 - its product code changes to<xutility>affected only__cpp_lib_concepts, so the feature-test macro should be similarly guarded.🧹 Cleanups
__cpp_lib_conceptsand cite STL: Update__cpp_lib_conceptsconditionals when all supported C++20 frontends support Concepts #395.__cpp_lib_conceptsstill mention__EDG__to avoid circularity.P0980R1_constexpr_strings, explain how theequalRangesworkaround should be removed._HAS_CXX23 && defined(__cpp_lib_concepts), always say// TRANSITION, GH-395.#ifdef __cpp_lib_conceptsfor consistency.__cpp_lib_conceptsconditionals when all supported C++20 frontends support Concepts #395 by__cpp_lib_algorithm_iterator_requirements.