P1899R3: views::stride - #2981
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoAug 7, 2022
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
marked this pull request as ready for review
August 1, 2022 21:30
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
August 1, 2022 21:30
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 5, 2022
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks great! Found a small number of issues, should be quick to address. 😸
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
* Rename `_Iterator_base` to `_Category_base` * Swap `stride_view` constraints * Fix `stride_view`'s iterator cross comparisons in tests (`ci <=> ci2` -> `i <=> ci2`)
Jakub Mazurkiewicz (JMazurkiewicz)
force-pushed
the
stride_view
branch
from
August 5, 2022 12:21
a51e22a to
9869884
Compare
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 5, 2022 15:43
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 5, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Apart from the LWG issue we need to file, LGTM!
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 5, 2022
Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 5, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this C++23 feature and helping the STL make great strides in conformance! 😹 😻 🚀 |
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net> Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements P1899R3 -
stride_view. Closes #2915.Note(s)
std::-qualified all calls tostd::forwardandstd::movein tests, because next Clang release (15) is going to warn about "unqualified std cast calls".