P2446R2: views::as_rvalue - #3008
Merged
Stephan T. Lavavej (StephanTLavavej) merged 13 commits intoAug 12, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 13 commits into
Stephan T. Lavavej (StephanTLavavej) merged 13 commits into
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
force-pushed
the
as_rvalue
branch
from
August 9, 2022 18:10
40c1cea to
84d7242
Compare
Jakub Mazurkiewicz (JMazurkiewicz)
force-pushed
the
as_rvalue
branch
from
August 10, 2022 00:33
36b81bb to
7dd4532
Compare
Jakub Mazurkiewicz (JMazurkiewicz)
marked this pull request as ready for review
August 10, 2022 01:37
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
August 10, 2022 01:37
nicole mazzuca (strega-nil-ms)
suggested changes
Aug 10, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Minor changes requested, otherwise LGTM!
Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 10, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 11, 2022
Member
|
Thanks, this looks great! I pushed minor changes (FYI nicole mazzuca (@strega-nil-ms) after you approved) for nitpicky style issues and a slight expansion of test coverage. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for implementing this C++23 feature and helping users write more elegant, more efficient code! 😻 🚀 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements P2446R2 -
views::as_rvalue. Closes #2929.Notes:
Marked as draft - I'm unable to implement full test coverage due to iterator unwrapping problems.Not anymore - I've implemented customtest_equalfunction that should be replaced withranges::equalafter<iterator>:move_sentinelcould be unwrappable #3009 is fixed,views::stride#2981: