Marked _Doraise() functions as override (improves #207) - #302
Conversation
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
Looks good to me, but clang-format validation is failing because there should be a space before the brace in override{ . If you fix those occurrences, the validation should pass. You can either run clang-format 9.0.0 on these files, or you can click on the Details for the "microsoft.STL (x64)" check, which will display the edits that clang-format wants to make. Thanks!
044b03b to
c0a123d
Compare
|
Thank you for the feedback! I have made the necessary corrections. |
Casey Carter (CaseyCarter)
left a comment
There was a problem hiding this comment.
Looks good! I counted, and they're all here.
|
I'm porting this to our Microsoft-internal MSVC repo now, for a full build and test run. |
|
This passed our tests, so I've merged your improvement for the VS 2019 16.5 Preview 2 release. Thanks again! |
Marked _Doraise() functions as override (microsoft#302)
I have fixed _doraise() to become override functions. Unfortunately, I couldn't fix all the functions as I am not very familiar with the code. Sorry about that!