Skip to content

Marked _Doraise() functions as override (improves #207) #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Nov 16, 2019
Merged

Marked _Doraise() functions as override (improves #207) #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/exception
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public:
virtual __CLR_OR_THIS_CALL ~bad_exception() noexcept {}

protected:
virtual void __CLR_OR_THIS_CALL _Doraise() const { // raise this exception
virtual void __CLR_OR_THIS_CALL _Doraise() const override { // raise this exception
_RAISE(*this);
}
};
Expand All @@ -149,7 +149,7 @@ private:
}

protected:
virtual void __CLR_OR_THIS_CALL _Doraise() const { // perform class-specific exception handling
virtual void __CLR_OR_THIS_CALL _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
};
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/execution
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ struct _Parallelism_resources_exhausted : exception {

#if !_HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // !_HAS_EXCEPTIONS
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/experimental/filesystem
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,7 @@ private:

#else // _HAS_EXCEPTIONS
protected:
virtual __CLR_OR_THIS_CALL void _Doraise() const { // perform class-specific exception handling
virtual __CLR_OR_THIS_CALL void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/filesystem
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,7 @@ namespace filesystem {

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/future
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/optional
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public:

#if !_HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // !_HAS_EXCEPTIONS
Expand Down
18 changes: 9 additions & 9 deletions stl/inc/stdexcept
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -50,7 +50,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -69,7 +69,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -88,7 +88,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -107,7 +107,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -126,7 +126,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -145,7 +145,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -164,7 +164,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand All @@ -183,7 +183,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/system_error
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand Down
4 changes: 2 additions & 2 deletions stl/inc/typeinfo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public:
virtual ~bad_cast() noexcept {}

protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
};
Expand All @@ -50,7 +50,7 @@ public:
virtual ~bad_typeid() noexcept {}

protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
};
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/variant
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ public:

#if !_HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // perform class-specific exception handling
virtual void _Doraise() const override { // perform class-specific exception handling
_RAISE(*this);
}
#endif // !_HAS_EXCEPTIONS
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/xiosbase
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public:

#else // _HAS_EXCEPTIONS
protected:
virtual void _Doraise() const { // report the exception
virtual void _Doraise() const override { // report the exception
_RAISE(*this);
}
#endif // _HAS_EXCEPTIONS
Expand Down