Unwrappable iter/sent pairs! - #3024
Merged
Stephan T. Lavavej (StephanTLavavej) merged 24 commits intoAug 31, 2022
Merged
Conversation
Contributor
Author
|
Casey Carter (@CaseyCarter) how do you feel about my new version? |
Contributor
I feel like the code formatting could be better 🥁 (looking now). |
…ng-with-sentinels
…ng-with-sentinels
nicole mazzuca (strega-nil-ms)
marked this pull request as ready for review
August 19, 2022 18:10
Contributor
Author
|
It's always fun finding weird bugs in the compiler |
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 19, 2022
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
One test is failing for x86:
C:\a\1\s\tests\std\tests\P0896R4_ranges_alg_reverse_copy\test.cpp(136): fatal error C1060: compiler is out of heap space
nicole mazzuca (strega-nil-ms)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 19, 2022 22:54
Casey Carter (CaseyCarter)
suggested changes
Aug 20, 2022
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
I can't thank you enough for picking up this task I didn't have time for and knocking it out of the park. This is excellent.
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 23, 2022
Stephan T. Lavavej (StephanTLavavej)
previously requested changes
Aug 23, 2022
Casey Carter (CaseyCarter)
approved these changes
Aug 23, 2022
nicole mazzuca (strega-nil-ms)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 24, 2022 17:07
Member
|
nicole mazzuca (@strega-nil-ms) Now that #2987 has landed, there's a merge conflict in |
…ng-with-sentinels
Contributor
Author
|
Stephan T. Lavavej (@StephanTLavavej) it has been moiged! |
Casey Carter (CaseyCarter)
approved these changes
Aug 29, 2022
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 30, 2022
nicole mazzuca (strega-nil-ms)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 30, 2022 00:34
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 30, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Casey Carter (CaseyCarter)
approved these changes
Aug 31, 2022
Member
|
Thanks for unwrapping these iterators and sentinels so cats can play with the wrapping paper! 🐈 🎁 🐈⬛ |
This was referenced Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing machinery leaves much to be desired, see #2992. This will hopefully fix those issues.
Requires tests