Skip to content

Cleanup views::as_rvalue tests - #3089

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
JMazurkiewicz:cleanup_as_rvalue_tests
Sep 13, 2022
Merged

Cleanup views::as_rvalue tests#3089
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
JMazurkiewicz:cleanup_as_rvalue_tests

Conversation

@JMazurkiewicz

@JMazurkiewicz Jakub Mazurkiewicz (JMazurkiewicz) commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:

  • After merging Unwrappable iter/sent pairs! #3024 test_equal function became unnecessary - we can replace it with ranges::equal,
  • Fixed two comments, that mentioned as_const_view instead of as_rvalue_view.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the test Related to test code label Sep 8, 2022
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Sep 8, 2022

Copy link
Copy Markdown
Member

Thanks, great catches! 😻

@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Sep 12, 2022

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 6e72b6a into microsoft:main Sep 13, 2022
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Sep 13, 2022

Copy link
Copy Markdown
Member

Thanks for noticing and cleaning up these test issues! 🦅 😸 🎉

@JMazurkiewicz
Jakub Mazurkiewicz (JMazurkiewicz) deleted the cleanup_as_rvalue_tests branch September 13, 2022 22:19
Casey Carter (CaseyCarter) pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@JMazurkiewicz @CaseyCarter
Cleanup views::as_rvalue tests (microsoft#3089)
a7e660d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+1 more reviewer
@strega-nil-ms nicole mazzuca (strega-nil-ms) strega-nil-ms approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej)

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JMazurkiewicz @StephanTLavavej @strega-nil-ms