Fix null function check for move_only_function assigned from a DLL and issues caused by an unloaded DLL that constructed or assigned an empty move_only_function - #3038
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoAug 18, 2022
Conversation
move_only_functionmove_only_function assigned from a DLL and issues caused by an unloaded DLL that constructed or assigned an empty move_only_function
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 17, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 18, 2022
Member
|
Thanks for fixing this bug before ABI lockdown! I pushed extremely minor changes to use |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for fixing this bug before it was trapped in ABI amber for a million years! 🐞 🦕 😹 |
Alex Guteniev (AlexGuteniev)
deleted the
this_is_i_guess_what_we_call_dll_hell
branch
August 18, 2022 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3037