Update source_location to use __builtin_FUNCSIG

[Daniel Marshall (SuperWig)]

Fixes #3063

• Should there be an escape hatch?
• The column number is strangely different in the lambda test. x1 is different to all others

  x1 = source_location::current()
                               ^
  x2 = source_location::current()
                        ^
  

  Edit: scratch that, it already has a transition comment I didn't merge in.

[Igor Zhukov (fsb4000)]

one more place:

STL/tests/std/include/test_header_units_and_modules.hpp

Line 655 in 0098818

assert(sl.function_name() == "impl_test_source_location"sv);

[Daniel Marshall (SuperWig)]

Oh good that's where I was already looking at

[Igor Zhukov (fsb4000)]

FAIL: std :: tests/GH_001411_core_headers:23 (23 of 29)
******************** TEST 'std :: tests/GH_001411_core_headers:23' FAILED ********************
Build setup steps:
Build steps:
Build step failed unexpectedly.
Command: "C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.35.32019\bin\HostX64\x64\cl.EXE" "-c" "C:\Dev\STL\tests\std\tests\GH_001411_core_headers\test.cpp" "-IC:\Dev\STL\out\build\x64\out\inc" "-IC:\Dev\STL\llvm-project\libcxx\test\support" "-IC:\Dev\STL\tests\std\include" "/nologo" "/Od" "/W4" "/w14061" "/w14242" "/w14265" "/w14582" "/w14583" "/w14587" "/w14588" "/w14749" "/w14841" "/w14842" "/w15038" "/w15214" "/w15215" "/w15216" "/w15217" "/w15262" "/sdl" "/WX" "/Zc:strictStrings" "/D_ENABLE_STL_INTERNAL_CHECK" "/bigobj" "/FIforce_include.hpp" "/w14365" "/D_ENFORCE_FACET_SPECIALIZATIONS=1" "/D_STL_CALL_ABORT_INSTEAD_OF_INVALID_PARAMETER" "/BE" "/c" "/EHsc" "/MT" "/std:c++20" "/permissive-" "/w14640" "/Zc:threadSafeInit-"
Exit Code: 2
Standard Output:
--
test.cpp
"C:\Dev\STL\out\build\x64\out\inc\source_location", line 31: error: identifier
          "__builtin_FUNCSIG" is undefined
          const char* const _Function_ = __builtin_FUNCSIG()) noexcept {
                                         ^

[Igor Zhukov (fsb4000)]

Similar to

STL/stl/inc/new

Line 51 in 2f8342a

#else // ^^^ workaround / no workaround vvv

[nicole mazzuca (strega-nil-ms)]

That's the only thing I see rn; should be easily fixable and then I'm 👍

Thanks Daniel Marshall (@SuperWig), and Igor Zhukov (@fsb4000) for reviewing ahead of me 😄

[nicole mazzuca (strega-nil-ms)]

Thanks so much!

[Stephan T. Lavavej (StephanTLavavej)]

++thanks; // 😻

I pushed tiny changes to fix a comment missing an underscore, and to restore a tiny bit of test coverage (exercising what happens when a lambda's definition occurs on a different line from its call). FYI Casey Carter (@CaseyCarter), nicole mazzuca (@strega-nil-ms).

[Stephan T. Lavavej (StephanTLavavej)]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[Stephan T. Lavavej (StephanTLavavej)]

Have to drop this from the current merge batch because the internal build is starting with a compiler that's too old:

D:\msvc\src\tools\vctools\Dev14\bin\x64\amd64>.\cl.exe
Microsoft (R) C/C++ Optimizing Compiler Version 19.34.31935 for x64

D:\msvc\binaries\x86chk\inc\source_location(31,38): error C3861: '__builtin_FUNCSIG': identifier not found [D:\msvc\src\vctools\Compiler\Utc\build\arm64\utc-arm64.nativeproj]

[Stephan T. Lavavej (StephanTLavavej)]

Casey thinks that MSVC-PR-440319 has the toolset update we need, which should be merged soon.

[Stephan T. Lavavej (StephanTLavavej)]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[Stephan T. Lavavej (StephanTLavavej)]

Thanks for significantly improving the displayed information here! 📈 🚀 😻