standardize ^^^ x / !x vvv comments - #3208
Conversation
|
Should this PR also settle on double arrows or one on each side i.e. |
|
Sure, and what do you like more? |
|
My vote would for the second. I believe this is also part of #351 |
|
I'll take a look at this once we discuss #351 |
nicole mazzuca (strega-nil-ms)
left a comment
There was a problem hiding this comment.
Might as well standardize the location of the ^^^ and vvv as well; also do that through the rest of the file (probably should've just done one suggestion and then said that... sorry...)
// => / in comments^^^ x / !x vvv comments
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
Thanks for making this more consistent and easier to read! The changes to <xcharconv_ryu.h> are fine (they're in additions to the upstream code and don't represent unnecessary divergence).
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for this consistency pass! 😸 🎉 💯 |
Sometimes we use
// ^^^ no workaround / workaround vvvand sometimes// ^^^ no workaround // workaround vvv.It looks like
/is used more often. So I replaced all of//which I had found.I used
//.+//regexp and VS code.Driven by: #3206 (comment)