Speculatively implement LWG-3857 - #3348
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoJan 22, 2023
Merged
Conversation
And update references to WG21-N4928. Co-authored-by: S. B. Tam <cpplearner@outlook.com>
nicole mazzuca (strega-nil-ms)
approved these changes
Jan 18, 2023
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
I do also appreciate the C++20 workaround. I personally think it's the best way forward.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 19, 2023
Member
|
Looks great, thanks! I pushed a trivial commit to unqualify |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3336.
The involved constructor of
basic_string_viewis introduced in C++23, so this PR also fixes the issue in C++20 mode in an alternative way.Also updates references to working darft in
<format>to WG21-N4928.