Fix XPASSing visit_format_arg.pass.cpp - #3357
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJan 22, 2023
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
January 22, 2023 08:25
Casey Carter (CaseyCarter)
approved these changes
Jan 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libcxx test
visit_format_arg.pass.cppis "unexpectedly passing" due to a stealth merge conflict:MSVC-internal PR/CI runs aren't affected because they completely skip things in
skipped_tests.txt. However, the GitHub CI noticed that the test was marked asFAILyet was passing.(I sometimes create GitHub PRs for testing purposes when merging a big stack of PRs, but didn't do so this time, which is how I missed it.)