Mark constructors that do not throw exceptions as noexcept - #3574
Mark constructors that do not throw exceptions as noexcept#3574AZero13 (AZero13) wants to merge 1 commit into
Conversation
43d7514 to
b5bf055
Compare
By ensuring we strength each move constructor with noexcept as we can, we can avoid needless exception checking and handling.
b5bf055 to
b7b8c57
Compare
|
We talked about this at the weekly maintainer meeting and decided to close this PR without merging. We've repeatedly asked to avoid force-pushing changes, and multiple people have noted that many of these functions are physically allocating memory (e.g. |
That isn't what happened. What happened was I closed the original PR to do some research on the code I was modifying and then made those changes. Once those changes were made, GitHub would not allow me to reopen. I should have marked it as a draft. There is nothing I am trying to hide. It was an honest Git mistake. |
By ensuring we strength each move constructor with noexcept as we can, we can avoid needless exception checking and handling.
Had to open a new PR because GitHub wouldn't let me reopen the last one because it turns out editing commit history when the PR is closed is not good.