Skip to content

Mark constructors that do not throw exceptions as noexcept #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AZero13 (AZero13) wants to merge 1 commit into from
Closed

Mark constructors that do not throw exceptions as noexcept #3574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public:
}

// clang-format off
expected(expected&&) requires
expected(expected&&) noexcept requires
is_trivially_move_constructible_v<_Ty> && is_trivially_move_constructible_v<_Err> = default;
// clang-format on

Expand Down Expand Up @@ -1185,7 +1185,7 @@ public:
}

// clang-format off
expected(expected&&) requires is_trivially_move_constructible_v<_Err> = default;
expected(expected&&) noexcept requires is_trivially_move_constructible_v<_Err> = default;
// clang-format on

template <class _Uty, class _UErr>
Expand Down
4 changes: 2 additions & 2 deletions stl/inc/hash_map
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ namespace stdext {
return *this;
}

hash_map(hash_map&& _Right) : _Mybase(_STD move(_Right)) {}
hash_map(hash_map&& _Right) noexcept : _Mybase(_STD move(_Right)) {}

hash_map(hash_map&& _Right, const allocator_type& _Al) : _Mybase(_STD move(_Right), _Al) {}

Expand Down Expand Up @@ -356,7 +356,7 @@ namespace stdext {
return *this;
}

hash_multimap(hash_multimap&& _Right) : _Mybase(_STD move(_Right)) {}
hash_multimap(hash_multimap&& _Right) noexcept : _Mybase(_STD move(_Right)) {}

hash_multimap(hash_multimap&& _Right, const allocator_type& _Al) : _Mybase(_STD move(_Right), _Al) {}

Expand Down
4 changes: 2 additions & 2 deletions stl/inc/iterator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ public:
}

// clang-format off
constexpr _Variantish(_Variantish&&) requires is_trivially_move_constructible_v<_Ty1>
constexpr _Variantish(_Variantish&&) noexcept requires is_trivially_move_constructible_v<_Ty1>
&& is_trivially_move_constructible_v<_Ty2> = default;
// clang-format on

Expand Down Expand Up @@ -687,7 +687,7 @@ public:
}

// clang-format off
constexpr _Variantish& operator=(_Variantish&&) requires is_trivially_destructible_v<_Ty1>
constexpr _Variantish& operator=(_Variantish&&) noexcept requires is_trivially_destructible_v<_Ty1>
&& is_trivially_destructible_v<_Ty2>
&& is_trivially_move_constructible_v<_Ty1>
&& is_trivially_move_constructible_v<_Ty2>
Expand Down
4 changes: 2 additions & 2 deletions stl/inc/ranges
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ namespace ranges {
_Movable_box(_Movable_box&&) requires is_trivially_move_constructible_v<_Ty> = default;
// clang-format on

constexpr _Movable_box(_Movable_box&& _That) : _Engaged{_That._Engaged} {
constexpr _Movable_box(_Movable_box&& _That) noexcept : _Engaged{_That._Engaged} {
if (_That._Engaged) {
_Construct_in_place(_Val, _STD move(_That._Val));
}
Expand Down Expand Up @@ -515,7 +515,7 @@ namespace ranges {
_Defaultabox(_Defaultabox&&) requires is_trivially_move_constructible_v<_Ty> = default;
// clang-format on

constexpr _Defaultabox(_Defaultabox&& _That) : _Engaged{_That._Engaged} {
constexpr _Defaultabox(_Defaultabox&& _That) noexcept : _Engaged{_That._Engaged} {
if (_That._Engaged) {
_Construct_in_place(_Val, _STD move(_That._Val));
}
Expand Down
8 changes: 4 additions & 4 deletions stl/inc/sstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public:
}
#endif // _HAS_CXX20

basic_stringbuf(basic_stringbuf&& _Right) : _Mystate(0) {
basic_stringbuf(basic_stringbuf&& _Right) noexcept : _Mystate(0) {
_Assign_rv(_STD move(_Right));
}

Expand Down Expand Up @@ -584,7 +584,7 @@ public:
: _Mybase(_STD addressof(_Stringbuffer)), _Stringbuffer(_Str, _Mode | ios_base::in) {}
#endif // _HAS_CXX20

basic_istringstream(basic_istringstream&& _Right) : _Mybase(_STD addressof(_Stringbuffer)) {
basic_istringstream(basic_istringstream&& _Right) noexcept : _Mybase(_STD addressof(_Stringbuffer)) {
_Assign_rv(_STD move(_Right));
}

Expand Down Expand Up @@ -704,7 +704,7 @@ public:
: _Mybase(_STD addressof(_Stringbuffer)), _Stringbuffer(_Str, _Mode | ios_base::out) {}
#endif // _HAS_CXX20

basic_ostringstream(basic_ostringstream&& _Right) : _Mybase(_STD addressof(_Stringbuffer)) {
basic_ostringstream(basic_ostringstream&& _Right) noexcept : _Mybase(_STD addressof(_Stringbuffer)) {
_Assign_rv(_STD move(_Right));
}

Expand Down Expand Up @@ -830,7 +830,7 @@ public:
: _Mybase(_STD addressof(_Stringbuffer)), _Stringbuffer(_Str, _Mode) {}
#endif // _HAS_CXX20

basic_stringstream(basic_stringstream&& _Right) : _Mybase(_STD addressof(_Stringbuffer)) {
basic_stringstream(basic_stringstream&& _Right) noexcept : _Mybase(_STD addressof(_Stringbuffer)) {
_Assign_rv(_STD move(_Right));
}

Expand Down