Skip to content

<mdspan>: layout_right improvements - #3615

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:feature/mdspan2from
JMazurkiewicz:mdspan/layout_right
Apr 4, 2023
Merged

<mdspan>: layout_right improvements#3615
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:feature/mdspan2from
JMazurkiewicz:mdspan/layout_right

Conversation

@JMazurkiewicz

Copy link
Copy Markdown
Contributor

layout_right:

  • Implement preconditions (checked unconditionally for now),
  • Fix is_(unique/exhaustive/strided) functions - all three should be static,
  • Implement rev-prod-of-extents function in extents,
  • Add separate regular tests and death tests.

layout_left:

  • Fix incorrect preconditions in constructor from layout_stride,
  • Fix tests and add extra coverage.

Testing:

  • Get rid of CanInvokeCallOperatorOfMapping concept and use already defined in helper header CheckCallOperatorOfLayoutMapping concept.

Comment thread tests/std/tests/P0009R18_mdspan_layout_right/test.cpp
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 74a6e2f into microsoft:feature/mdspan2 Apr 4, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks! 😻 Merged with one tiny suggestion for followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mdspan C++23 mdspan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants