<mdspan>: Cleanup extents's deduction guide - #3632
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoApr 7, 2023
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
April 6, 2023 22:18
<mdspan>: Fix extents's deduction guide<mdspan>: Cleanup extents's deduction guide
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 7, 2023
Stephan T. Lavavej (StephanTLavavej)
merged commit Apr 7, 2023
f4934c6
into
microsoft:feature/mdspan2
Member
😻 🧹 ✅ |
Jakub Mazurkiewicz (JMazurkiewicz)
deleted the
mdspan/extents-deduction-guide
branch
April 7, 2023 08:27
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR removes workaround for
extents's deduction guide ICE. It looks like the code was incorrect anyway (meaning it is ICE on invalid) and Clang incorrectly accepts it.Here is a minimal repro: https://godbolt.org/z/Wdjq5boG3, feel free to report it to both LLVM and MSVC (and maybe to GCC, this error message is awful).
Drive-by: address comment from previous PR.