<mdspan>: Implement multidimensional subscript operator - #3689
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoMay 24, 2023
Conversation
Clang 16/17 only.
Drive-by: * Add extra `TRANSITION, P2128R6` comment * Fix rebase conflict
Already fixed for Clang 17 Repro: https://godbolt.org/z/shfq7TPEx
Jakub Mazurkiewicz (JMazurkiewicz)
force-pushed
the
mdspan/subscript-operator
branch
from
May 16, 2023 00:36
cddba56 to
8ab95b0
Compare
Jakub Mazurkiewicz (JMazurkiewicz)
marked this pull request as ready for review
May 18, 2023 23:16
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
May 18, 2023 23:16
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 24, 2023
Stephan T. Lavavej (StephanTLavavej)
merged commit May 24, 2023
c600a08
into
microsoft:feature/mdspan2
Member
|
Thanks! Merged with a couple of suggestions for later. |
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
May 28, 2023
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
May 30, 2023
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
Jun 6, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operator()in all modes,spanas an argument tomdspan::_Index_impl,(*this)[indices...]I had to usethis->operator[](indices...)syntax (https://godbolt.org/z/shfq7TPEx).operator[indices...]when possible,operator[array{indices...}]otherwise.