Skip to content

mdspan STL's review comments - easy part - #3944

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:feature/mdspan2from
AlexGuteniev:feature/mdspan2
Aug 10, 2023
Merged

mdspan STL's review comments - easy part#3944
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:feature/mdspan2from
AlexGuteniev:feature/mdspan2

Conversation

@AlexGuteniev

@AlexGuteniev Alex Guteniev (AlexGuteniev) commented Aug 10, 2023

Copy link
Copy Markdown
Contributor
  • Remove superfluous std::, the tests do using namespace std;
  • Cast bool to size_t explicitly
  • Check the correct constructor

@AlexGuteniev
Alex Guteniev (AlexGuteniev) requested a review from a team as a code owner August 10, 2023 15:46
@CaseyCarter Casey Carter (CaseyCarter) added the mdspan C++23 mdspan label Aug 10, 2023
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 74e82a6 into microsoft:feature/mdspan2 Aug 10, 2023
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Aug 10, 2023

Copy link
Copy Markdown
Member

Thanks for fixing these issues! 😻

@AlexGuteniev
Alex Guteniev (AlexGuteniev) deleted the feature/mdspan2 branch August 10, 2023 18:54
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes

Assignees

No one assigned

Labels

mdspan C++23 mdspan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexGuteniev @StephanTLavavej @CaseyCarter