Skip to content

mdspan STL's review comments - easy part #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Aug 10, 2023
Merged

mdspan STL's review comments - easy part #3944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/std/tests/P0009R18_mdspan_default_accessor/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ constexpr void test_one(array<ElementType, 3> elems) {
static_assert(semiregular<Accessor>);

// Check if default_accessor is empty
static_assert(std::is_empty_v<Accessor>);
static_assert(is_empty_v<Accessor>);

// Check nested types
static_assert(same_as<typename Accessor::offset_policy, Accessor>);
Expand Down
4 changes: 2 additions & 2 deletions tests/std/tests/P0009R18_mdspan_extents/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ constexpr void check_members(index_sequence<Indices...>) {

// Check static observers
static_assert(Ext::rank() == sizeof...(Extents));
static_assert(Ext::rank_dynamic() == ((Extents == dynamic_extent) + ... + 0));
static_assert(Ext::rank_dynamic() == (size_t{Extents == dynamic_extent} + ... + 0));
static_assert(((Ext::static_extent(Indices) == Extents) && ...));

// Check noexceptness of static observers
Expand Down Expand Up @@ -67,7 +67,7 @@ constexpr void check_members(index_sequence<Indices...>) {
Ext2 ext2{ext.extent(Indices)...};
assert(((ext.extent(Indices) == ext2.extent(Indices)) && ...));
assert(ext == ext2);
static_assert(is_nothrow_constructible_v<Ext2, Ext>);
static_assert(is_nothrow_constructible_v<Ext2, decltype(ext.extent(Indices))...>);
// Other tests are defined in 'check_construction_from_extents_pack' function
}

Expand Down