Fix #224: static_assert is_sorted(). - #451
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJan 24, 2020
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
January 24, 2020 08:00
Stephan T. Lavavej (StephanTLavavej)
force-pushed
the
fix_gh_224_static_assert_is_sorted
branch
from
January 24, 2020 08:26
f10fa76 to
384b394
Compare
Member
Author
|
I filed #455 to track the fact that we can't change validate.cpp yet (the tools don't use the freshly-built STL, d'oh). |
Billy O'Neal (BillyONeal)
approved these changes
Jan 24, 2020
Stephan T. Lavavej (StephanTLavavej)
requested review from
Casey Carter (CaseyCarter) and
Charlie Barto (barcharcraz)
January 24, 2020 11:04
Casey Carter (CaseyCarter)
approved these changes
Jan 24, 2020
Stephan T. Lavavej (StephanTLavavej)
deleted the
fix_gh_224_static_assert_is_sorted
branch
January 24, 2020 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that #6 has been implemented, we can fix #224 by
static_assertingis_sorted()for lookup tables. This guarantees safety with zero runtime cost.Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.