Skip to content

Fix #224: static_assert is_sorted(). #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Jan 24, 2020
+12 −0
Merged

Fix #224: static_assert is_sorted(). #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions stl/src/winapinls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@

#if _STL_WIN32_WINNT < _WIN32_WINNT_VISTA

#include <algorithm>
#include <ctype.h>
#include <stdlib.h>
#include <string_view>

namespace {
struct LCIDTOLOCALENAME {
Expand Down Expand Up @@ -255,6 +257,9 @@ namespace {
};
// clang-format on

static_assert(_STD is_sorted(_STD begin(LcidToLocaleNameTable), _STD end(LcidToLocaleNameTable),
[](const auto& left, const auto& right) { return left.lcid < right.lcid; }));

// Map of locale name to an index in LcidToLocaleNameTable, for Windows XP.
// Data in this table has been obtained from National Language Support (NLS) API Reference.
// The table is sorted to improve search performance.
Expand Down Expand Up @@ -490,6 +495,13 @@ namespace {
{ L"zu-za" , 112 },
};
// clang-format on

// This static_assert is case-sensitive, which is more than sufficient for the case-insensitive runtime lookups.
static_assert(_STD is_sorted(
_STD begin(LocaleNameToIndexTable), _STD end(LocaleNameToIndexTable), [](const auto& left, const auto& right) {
return _STD wstring_view{left.name} < _STD wstring_view{right.name};
}));

} // unnamed namespace

// __wcsnicmp_ascii
Expand Down