Toolset update: MSVC Compiler 19.52.36725, large Fadsv7 pool - #6444
Merged
Stephan T. Lavavej (StephanTLavavej) merged 25 commits intoSep 10, 2026
Merged
Conversation
… to 23 64-core VMs.
"--fail" means "Fail fast with no output on HTTP errors".
``` -f, --fail Fail fast with no output on HTTP errors -s, --silent Silent mode -S, --show-error Show error even when -s is used -L, --location Follow redirects -o, --output <file> Write to file instead of stdout ```
…ence` just in case. We don't have any native commands right now.
…), before GH 6434 (merged 2026-09-04) used inline namespaces to allow mixing.
…constant evaluation and fpclassify for subnormal floats.
… made `/O2` coverage necessary.
…`/std:c++23preview`.
Remove most of the fine-grained task timeouts; we don't need them. Keep the Code Format Validation job timeout at 5 minutes. It currently takes ~1m55s so this leaves a 2.5x margin. Reduce the build-and-test.yml job timeout from 30 to 20 minutes. The slowest shards are ARM64EC and they take ~9m, so this leaves a 2.2x margin. Making this arch/stage dependent would be valuable, since the early builds and the x64/x86 runs are faster. Reduce the Run Tests task timeout from 30 to 15 minutes. The slowest ARM64EC shard takes 5m56s so this leaves a 2.5x margin.
Use 6 minutes for early x64/x86 builds (2.4x margin), and 9 minutes for early ARM64/ARM64EC builds (2.5x margin). Use 5 minutes for Configure Tests (3.3x margin), same as Code Format Validation. Use 15 minutes for full x64/x86 tests (2.5x margin) and 20 minutes for full ARM64/ARM64EC tests (2.2x margin). Use 20 minutes for x64/x86 ASan (unverified but should be ~2.5x margin) and 25 minutes for ARM64 ASan (2.5x margin).
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
September 9, 2026 21:56
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Stephan T. Lavavej (StephanTLavavej)
September 9, 2026 21:58
View session
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Stephan T. Lavavej (StephanTLavavej)
September 9, 2026 23:08
View session
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Billy O'Neal (BillyONeal)
approved these changes
Sep 10, 2026
Stephan T. Lavavej (StephanTLavavej)
merged commit Sep 10, 2026
7647828
into
microsoft:main
48 checks passed
Charlie Lin (clin1234)
pushed a commit
to clin1234/STL
that referenced
this pull request
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes our CI system simpler and faster now that we have sufficient quota for a large Fadsv7 pool (non-SMT Zen 5, temp storage, can use 80-core VMs).
$DiskTypeto handle NVMe vs. SCSI.$PSNativeCommandUseErrorActionPreferencejust in case./experimental:mathlibto/Zc:cmath.frexp(), before Overhaulconstexpr <cmath>#6434 (merged 2026-09-04) used inline namespaces to allow mixing.fpclassifyfor subnormal floats.constexpr <cmath>#6434 (merged 2026-09-04) removed the#pragma functionstuff that made/O2coverage necessary./std:c++23and deprecated/std:c++23preview.__fastfailwe no longer need_STL_UNREACHABLEto improve codegen./Zc:cmathto libcxx, reported [libcxx][test]signaling_NaN()should not be used inconstexpr <cmath>tests llvm/llvm-project#222431.<cmath>:constexprfpclassify()rejects signaling NaNs on x86 #6445.