Toolset update: MSVC Compiler 19.52.36725, large Fadsv7 pool

CMakeLists.txt

@@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 4.3.1)
 set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
 project(msvc_standard_libraries LANGUAGES CXX)
 
-set(expected_msvc_compiler_version "19.52.36629")
+set(expected_msvc_compiler_version "19.52.36725")
 if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS expected_msvc_compiler_version)
     message(FATAL_ERROR "The STL must be built with MSVC Compiler ${expected_msvc_compiler_version} or later. Follow the README instructions.")
 endif()

azure-devops/asan-pipeline.yml

@@ -20,15 +20,16 @@ stages:
     displayName: 'Test x64 ASan'
     dependsOn: []
     pool:
-      name: ${{ variables.x64SlowPoolName }}
+      name: ${{ variables.x64PoolName }}
       demands: ${{ variables.poolDemands }}
     variables:
     - name: workRoot
-      value: '$(x64SlowPoolWorkRoot)'
+      value: '$(x64PoolWorkRoot)'
       readonly: true
     jobs:
       - template: build-and-test.yml
         parameters:
+          jobTimeoutInMinutes: 20
           hostArch: x64
           targetArch: x64
           targetPlatform: x64
@@ -39,15 +40,16 @@ stages:
     displayName: 'Test x86 ASan'
     dependsOn: []
     pool:
-      name: ${{ variables.x64SlowPoolName }}
+      name: ${{ variables.x64PoolName }}
       demands: ${{ variables.poolDemands }}
     variables:
     - name: workRoot
-      value: '$(x64SlowPoolWorkRoot)'
+      value: '$(x64PoolWorkRoot)'
       readonly: true
     jobs:
       - template: build-and-test.yml
         parameters:
+          jobTimeoutInMinutes: 20
           hostArch: x86
           targetArch: x86
           targetPlatform: x86
@@ -67,6 +69,7 @@ stages:
     jobs:
       - template: build-and-test.yml
         parameters:
+          jobTimeoutInMinutes: 25
           hostArch: arm64
           targetArch: arm64
           targetPlatform: arm64

azure-devops/build-and-test.yml

@@ -2,6 +2,8 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 parameters:
+- name: jobTimeoutInMinutes
+  type: string
 - name: hostArch
   type: string
 - name: targetArch
@@ -39,7 +41,7 @@ jobs:
 - job: '${{ parameters.targetPlatform }}'
   strategy:
     parallel: ${{ parameters.numShards }}
-  timeoutInMinutes: 30
+  timeoutInMinutes: ${{ parameters.jobTimeoutInMinutes }}
   steps:
   - template: checkout-self.yml
   - template: checkout-submodule.yml

azure-devops/build-benchmarks.yml

@@ -31,7 +31,6 @@ steps:
       -DSTL_BINARY_DIR="$(buildOutputLocation)" `
       -DVCLIBS_TARGET_ARCHITECTURE=${{ parameters.targetPlatform }} `
       -S $(Build.SourcesDirectory)/benchmarks -B "$(benchmarkBuildOutputLocation)\${{ parameters.compiler }}"
-  timeoutInMinutes: 2
   env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
   # TRANSITION, we currently only build the benchmarks with Clang for x64
   condition: >
@@ -47,7 +46,6 @@ steps:
       $PSNativeCommandUseErrorActionPreference = $true
       & "$(launchVsDevShell)" -Preview -NoLogo -HostArch ${{ parameters.hostArch }} -Arch ${{ parameters.targetArch }}
       cmake --build "$(benchmarkBuildOutputLocation)\${{ parameters.compiler }}"
-  timeoutInMinutes: 2
   env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
   # TRANSITION, we currently only build the benchmarks with Clang for x64
   condition: >

azure-devops/cmake-configure-build.yml

@@ -48,7 +48,6 @@ steps:
       -DTESTS_BUILD_ONLY=${{ parameters.testsBuildOnly }} `
       -DVCLIBS_TARGET_ARCHITECTURE=${{ parameters.targetPlatform }} `
       -S $(Build.SourcesDirectory) -B "$(buildOutputLocation)"
-  timeoutInMinutes: 2
   env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
 - task: PowerShell@2
   displayName: 'Build STL'
@@ -59,6 +58,5 @@ steps:
       $PSNativeCommandUseErrorActionPreference = $true
       & "$(launchVsDevShell)" -Preview -NoLogo -HostArch ${{ parameters.hostArch }} -Arch ${{ parameters.targetArch }}
       cmake --build "$(buildOutputLocation)"
-  timeoutInMinutes: 5
   condition: and(succeeded(), ${{ parameters.buildStl }})
   env: { TMP: $(tmpDir), TEMP: $(tmpDir) }

azure-devops/config.yml

@@ -4,34 +4,20 @@
 # Common configuration used by both pipelines
 
 variables:
-- name: x64SlowPoolName
-  value: 'Stl-2026-08-25T2113-x64-Fasv6-Pool'
-  readonly: true
-- name: x64MediumPoolName
-  value: 'Stl-2026-08-25T2113-x64-Fasv7-Pool'
-  readonly: true
-- name: x64FastPoolName
-  value: 'Stl-2026-08-25T2113-x64-Fadsv7-Pool'
+- name: x64PoolName
+  value: 'Stl-2026-09-08T1422-x64-Fadsv7-Pool'
   readonly: true
 - name: arm64PoolName
-  value: 'Stl-2026-08-25T2113-arm64-Dpdsv6-Pool'
+  value: 'Stl-2026-09-08T1422-arm64-Dpdsv6-Pool'
   readonly: true
 - name: poolDemands
   value: 'EnableSpotVM -equals false'
   readonly: true
 - name: launchVsDevShell
   value: 'C:\Program Files\Microsoft Visual Studio\18\Insiders\Common7\Tools\Launch-VsDevShell.ps1'
   readonly: true
-# The x64 SKU Fasv6 doesn't have local temporary storage, so it must use 'C:'.
-- name: x64SlowPoolWorkRoot
-  value: 'C:'
-  readonly: true
-# The x64 SKU Fasv7 doesn't have local temporary storage, so it must use 'C:'.
-- name: x64MediumPoolWorkRoot
-  value: 'C:'
-  readonly: true
 # The x64 SKU Fadsv7 has local temporary storage, available as 'N:' (for NVMe).
-- name: x64FastPoolWorkRoot
+- name: x64PoolWorkRoot
   value: 'N:'
   readonly: true
 # The arm64 SKU Dpdsv6 has local temporary storage, available as 'E:'.

azure-devops/create-1es-hosted-pool.ps1

@@ -9,14 +9,15 @@ Creates a 1ES Hosted Pool, set up for the STL's CI.
 See https://github.com/microsoft/STL/wiki/Checklist-for-Toolset-Updates for more information.
 
 .PARAMETER VMSku
-The VM SKU can be Fasv6, Fasv7, Fadsv7, or Dpdsv6.
+The VM SKU can be Fadsv7 or Dpdsv6.
 #>
 [CmdletBinding(PositionalBinding=$false)]
 Param(
-  [Parameter(Mandatory)][ValidateSet('Fasv6', 'Fasv7', 'Fadsv7', 'Dpdsv6')][String]$VMSku
+  [Parameter(Mandatory)][ValidateSet('Fadsv7', 'Dpdsv6')][String]$VMSku
 )
 
 $ErrorActionPreference = 'Stop'
+$PSNativeCommandUseErrorActionPreference = $true
 
 $CurrentDate = Get-Date
 $Timestamp = $CurrentDate.ToString('yyyy-MM-ddTHHmm')
@@ -31,41 +32,28 @@ $Timestamp = $CurrentDate.ToString('yyyy-MM-ddTHHmm')
 
 # | SKU    | Location       | Cores | Notes
 # |--------|----------------|------:|-------
-# | Fasv6  | eastus2        |  4096 |
-# | Fasv7  | australiaeast  |   740 | Currently unused to stay within our regional (all-SKU) quota of 4736 cores
-# | Fasv7  | northeurope    |   640 |
-# | Fasv7  | southeastasia  |   640 |
-# | Fadsv7 | australiaeast  |  2048 |
+# | Fadsv7 | australiaeast  |  3024 |
+# | Fadsv7 | swedencentral  |  2560 |
 # | Dpdsv6 | australiaeast  |  2048 |
 # | Dpdsv6 | southcentralus |  2048 |
 
-if ($VMSku -ieq 'Fasv6') {
-  $Arch = 'x64'
-  $ProtoVMSize = 'Standard_F16as_v6'
-  $PoolSkuName = 'Standard_F64as_v6'
-  $PoolSize = 32 # We have quota for 4096 cores (64 VMs), so we can have old and new pools of 32 VMs each.
-  $AvailableLocations = @('eastus2')
-} elseif ($VMSku -ieq 'Fasv7') {
-  $Arch = 'x64'
-  $ProtoVMSize = 'Standard_F16as_v7'
-  $PoolSkuName = 'Standard_F48as_v7'
-  $PoolSize = 13 # Locations where we have quota for at least 640 cores (13 VMs):
-  $AvailableLocations = @('northeurope', 'southeastasia')
-} elseif ($VMSku -ieq 'Fadsv7') {
+if ($VMSku -ieq 'Fadsv7') {
   $Arch = 'x64'
+  $DiskType = 'NVMe'
   $ProtoVMSize = 'Standard_F16ads_v7'
-  $PoolSkuName = 'Standard_F48ads_v7'
-  $PoolSize = 21 # We have quota for 2048 cores (42 VMs), so we can have old and new pools of 21 VMs each.
-  $AvailableLocations = @('australiaeast')
+  $PoolSkuName = 'Standard_F80ads_v7'
+  $PoolSize = 32 # Locations where we have quota for at least 2560 cores (32 VMs):
+  $AvailableLocations = @('australiaeast', 'swedencentral')
 } elseif ($VMSku -ieq 'Dpdsv6') {
   $Arch = 'arm64'
+  $DiskType = 'SCSI'
   $ProtoVMSize = 'Standard_D16pds_v6'
   $PoolSkuName = 'Standard_D64pds_v6'
   $PoolSize = 32 # Locations where we have quota for at least 2048 cores (32 VMs):
   $AvailableLocations = @('australiaeast', 'southcentralus')
 }
 
-$AvailableLocationIdx = 14 # Increment for each new set of pools, to cycle through the available locations.
+$AvailableLocationIdx = 15 # Increment for each new set of pools, to cycle through the available locations.
 $Location = $AvailableLocations[$AvailableLocationIdx % $AvailableLocations.Length]
 
 if ($Arch -ieq 'x64') {
@@ -232,13 +220,13 @@ if ($Arch -ieq 'x64') {
   $VM = New-AzVMConfig `
     -VMName $ProtoVMName `
     -VMSize $ProtoVMSize `
-    -DiskControllerType 'NVMe' `
+    -DiskControllerType $DiskType `
     -Priority 'Regular'
 } else {
   $VM = New-AzVMConfig `
     -VMName $ProtoVMName `
     -VMSize $ProtoVMSize `
-    -DiskControllerType 'SCSI' `
+    -DiskControllerType $DiskType `
     -Priority 'Regular' `
     -SecurityType 'TrustedLaunch' `
     -SharedGalleryImageId $ImageId
@@ -386,7 +374,7 @@ Display-ProgressBar -Status 'Creating image definition'
 
 $ImageDefinitionName = "$ResourceGroupName-ImageDefinition"
 $FeatureTrustedLaunch = @{ Name = 'SecurityType'; Value = 'TrustedLaunch'; }
-if ($Arch -ieq 'x64') {
+if ($DiskType -ieq 'NVMe') {
   $FeatureNVMe = @{ Name = 'DiskControllerTypes'; Value = 'SCSI, NVMe'; }
 } else {
   $FeatureNVMe = @{ Name = 'DiskControllerTypes'; Value = 'SCSI'; }

azure-devops/format-validation.yml

@@ -22,29 +22,27 @@ jobs:
           & "$(launchVsDevShell)" -Preview -NoLogo -HostArch x64 -Arch x64
           cmake -G Ninja -S $(Build.SourcesDirectory)/tools -B "$(validationBuildOutputLocation)"
           cmake --build "$(validationBuildOutputLocation)"
-      timeoutInMinutes: 5
       env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
     - task: PowerShell@2
-      displayName: 'clang-format Files'
+      displayName: 'Validate Files'
       inputs:
         pwsh: true
         targetType: inline
         script: |
           $PSNativeCommandUseErrorActionPreference = $true
           & "$(launchVsDevShell)" -Preview -NoLogo -HostArch x64 -Arch x64
-          cmake --build "$(validationBuildOutputLocation)" --target run-format
-      timeoutInMinutes: 5
+          cmake --build "$(validationBuildOutputLocation)" --target run-validate
       env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
+    # We need to validate files before running clang-format, which modifies them in-place.
     - task: PowerShell@2
-      displayName: 'Validate Files'
+      displayName: 'clang-format Files'
       inputs:
         pwsh: true
         targetType: inline
         script: |
           $PSNativeCommandUseErrorActionPreference = $true
           & "$(launchVsDevShell)" -Preview -NoLogo -HostArch x64 -Arch x64
-          cmake --build "$(validationBuildOutputLocation)" --target run-validate
-      timeoutInMinutes: 2
+          cmake --build "$(validationBuildOutputLocation)" --target run-format
       env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
     - task: PowerShell@2
       displayName: 'Create Diff'

azure-devops/provision-image.ps1

@@ -59,9 +59,9 @@ foreach ($workload in $VisualStudioWorkloads) {
 
 # https://github.com/PowerShell/PowerShell/releases/latest
 if ($Provisioning_x64) {
-  $PowerShellUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.6.5/PowerShell-7.6.5-win-x64.msi'
+  $PowerShellUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.6.6/PowerShell-7.6.6-win-x64.msi'
 } else {
-  $PowerShellUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.6.5/PowerShell-7.6.5-win-arm64.msi'
+  $PowerShellUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.6.6/PowerShell-7.6.6-win-arm64.msi'
 }
 $PowerShellArgs = @('/quiet', '/norestart')
 
@@ -111,7 +111,10 @@ Function DownloadAndInstall {
     mkdir $tempPath -Force | Out-Null
     $fileName = [uri]::new($Url).Segments[-1]
     $installerPath = Join-Path $tempPath $fileName
-    curl.exe -L -o $installerPath -s -S $Url
+    curl.exe --fail --silent --show-error --location --output $installerPath $Url
+    if ($LASTEXITCODE -ne 0) {
+      Write-Error "curl.exe failed with non-zero exit code $LASTEXITCODE."
+    }
 
     Write-Host "Installing $Name..."
     $proc = Start-Process -FilePath $installerPath -ArgumentList $Args -Wait -PassThru

azure-devops/run-tests.yml

@@ -23,12 +23,11 @@ steps:
       $PSNativeCommandUseErrorActionPreference = $true
       & "$(launchVsDevShell)" -Preview -NoLogo -HostArch ${{ parameters.hostArch }} -Arch ${{ parameters.targetArch }}
       ninja --verbose -k 0 ${{ parameters.testTargets }}
-  timeoutInMinutes: 30
+  timeoutInMinutes: 15
   condition: and(succeeded(), ${{ parameters.runTesting }})
   env: { TMP: $(tmpDir), TEMP: $(tmpDir) }
 - task: PublishTestResults@2
   displayName: 'Publish Tests'
-  timeoutInMinutes: 5
   condition: and(succeededOrFailed(), ${{ parameters.runTesting }})
   inputs:
     searchFolder: $(buildOutputLocation)