Modernize ranges::copy - #956
Merged
Stephan T. Lavavej (StephanTLavavej) merged 10 commits intoJul 11, 2020
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
July 1, 2020 11:41
Contributor
Author
Ups |
Casey Carter (CaseyCarter)
suggested changes
Jul 1, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
More righteous cleanup.
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
Michael Schellenberger Costa (miscco)
force-pushed
the
ranges_copy
branch
2 times, most recently
from
July 3, 2020 08:00
a486c1d to
4e68141
Compare
Michael Schellenberger Costa (miscco)
force-pushed
the
ranges_copy
branch
from
July 3, 2020 08:02
4e68141 to
2bb2eff
Compare
... so other algorithms can use it directly.
Casey Carter (CaseyCarter)
approved these changes
Jul 9, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 10, 2020
Member
|
Thanks for improving this code to modern standards! We've learned a lot since merging #565 on March 4, 2020, a lifetime ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves ranges::copy to the new way of handling both the CPOs and the tests