Modernize ranges::copy_if - #958
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoJul 11, 2020
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
July 1, 2020 12:13
Contributor
Author
Double ups Billy O'Neal (@BillyONeal) we need MOOOOOOOOOORE RAM |
Casey Carter (CaseyCarter)
suggested changes
Jul 1, 2020
Casey Carter (CaseyCarter)
suggested changes
Jul 3, 2020
Michael Schellenberger Costa (miscco)
force-pushed
the
ranges_copy_if
branch
4 times, most recently
from
July 3, 2020 18:56
9286de8 to
f31a68c
Compare
Michael Schellenberger Costa (miscco)
force-pushed
the
ranges_copy_if
branch
from
July 3, 2020 21:08
f31a68c to
b3ca4a8
Compare
Casey Carter (CaseyCarter)
approved these changes
Jul 9, 2020
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 10, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good, I'll push a change to restore <utility> for move().
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 10, 2020
Member
|
Thanks for this series of improvements! One might say that this is a total copycat of #956. 🐈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new way of delegating the work and improve the tests