Skip to content

Allowed digits at the end of method return type - #240

Closed
Richard Beddington (RichieAHB) wants to merge 1 commit into
microsoft:masterfrom
RichieAHB:issue_188
Closed

Allowed digits at the end of method return type#240
Richard Beddington (RichieAHB) wants to merge 1 commit into
microsoft:masterfrom
RichieAHB:issue_188

Conversation

@RichieAHB

@RichieAHBRichard Beddington (RichieAHB) commented Aug 12, 2016

Copy link
Copy Markdown

Fixes#153 - includes tests. The regex for type-annotation was looking for [a-zA-Z_$] (the regex used for the first character) as the pattern for the last character rather than [\w$]. There are a few regexes around that allows [.\w$] for the last character of a type name but as far as I can tell, type names can't end with a dot so I've not included this.

I have a plugin that removes whitespace at the end of lines so there are some rogue changes in here that I missed, which can be removed if required.

@msftclas

Hi Richard Beddington (@RichieAHB), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

Richard Beddington (@RichieAHB), Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@anubmat

Copy link
Copy Markdown
Contributor

Hi Richard Beddington (@RichieAHB) , this PR is similar to PR #199 . I see you have a good test here. You can either leave some comments on PR #199, or wait for that PR to be merged in and send out a PR to improve those changes.

@mhegazy

Copy link
Copy Markdown
Contributor

Sorry for the delay. the original issue should be fixed now by #257

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RichieAHB@msftclas@anubmat@mhegazy