Skip to content

Rewrite and fixes for lot of grammar issues - #257

Merged
Sheetal Nandi (sheetalkamat) merged 78 commits into
masterfrom
modifyExistingGrammar
Sep 16, 2016
Merged

Rewrite and fixes for lot of grammar issues#257
Sheetal Nandi (sheetalkamat) merged 78 commits into
masterfrom
modifyExistingGrammar

Conversation

@sheetalkamat

@sheetalkamatSheetal Nandi (sheetalkamat) commented Sep 8, 2016

Copy link
Copy Markdown
Member

No description provided.

@sheetalkamat
Make baselines so we can verify against new grammar
89e4a66
@sheetalkamat
Add original file to baselines for easier diagnosing issues with base…
c0acaa2
…line
@sheetalkamat
Stop running old baselines along with making better baseline for mark…
b08936f
…ers too
@sheetalkamat
Generate baselines and markers in same folder
c0d907e
@sheetalkamat
Theme files for existing typescript and typescript react
d9a7c97
@sheetalkamat
Update comment grammar
aea13ef
@sheetalkamat
Changes for numeric literals
89d8a7b
@sheetalkamat
Generate the marker file only if there are any markers in the file
b4a9b2d
@sheetalkamat
Constants - true, false, null, undefined, nan, infinity
9c71cac
@sheetalkamat
Strings
1de155d
@sheetalkamat
Regular expressions
91a4709
@sheetalkamat
Renaming of scope names to match other grammars
8c4e427
Note jsx attribute value is colored as string with this and its a TODO
@sheetalkamat
Workaround to distiguish attribute values from the string literals
38cee99
@sheetalkamat
Few simplifications for type-name and primitive types
b7a6c22
@sheetalkamat
Fix the method return type, handle return type that is object type an…
66a6eba
…d object type's field declaration's type annotation
@sheetalkamat
Fix the return type of function type when it is tuple or object type
543cc6a
@sheetalkamat
Fix the incorrect ternary operator colorizing in tsx file
3fff5ce
@sheetalkamat
Include comments in type declaration
eaeaa94
@sheetalkamat
Fix incorrect scope name for assignment
b0b161d
@sheetalkamat
Fix the fn return type annotation when it is used inside the object type
153f123
@sheetalkamat
Rearrange the declarations, statements, expressions
731f7c0
@sheetalkamat
Export var, type and enums declarations
80ad4f0
@sheetalkamat
Detect { followed by => as body of the arrow function
7ec2883
@sheetalkamat
Await is keyword.control and not modifier
132088f
@sheetalkamat
Fix for loop variable declarations
87e32c6
@sheetalkamat
{ after the operator is object literal and not the declaration block
8914364
@sheetalkamat
rename meta.block to meta.object-literal
d5caa74
@sheetalkamat
Rename meta.decl.block to meta.block
c817285
@sheetalkamat
Support Import equals and import declarations
4774bec
@sheetalkamat
Support for Export declarations
8870cb4
This was referenced Sep 16, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 16, 2016
Closed
Closed
Closed
@sheetalkamatSheetal Nandi (sheetalkamat) mentioned this pull request Sep 16, 2016
Closed
@mhegazyMohamed Hegazy (mhegazy) mentioned this pull request Sep 16, 2016
Closed
@Tyriar

Daniel Imms (Tyriar) commented Sep 16, 2016

Copy link
Copy Markdown

Nice work! Looking forward to testing it out.

This was referenced Sep 16, 2016
Closed
Closed
@wclr

Alex (wclr) commented Sep 17, 2016

Copy link
Copy Markdown

Should it also effect on this?
microsoft/vscode#11398

And when will it be available?

@mhegazy

Mohamed Hegazy (mhegazy) commented Sep 19, 2016

Copy link
Copy Markdown
Contributor

And when will it be available?

we should have this in a vscode extension for users to try it out next week. if every thing looks good, should be available in vscode's subsequent releases.

@octref

Pine (octref) commented Sep 19, 2016

Copy link
Copy Markdown

Mohamed Hegazy (@mhegazy)

Thanks a lot for the hard work! Can you give an overview of the most important grammar issues that get fixed in this PR?

@mhegazy

Mohamed Hegazy (mhegazy) commented Sep 19, 2016

Copy link
Copy Markdown
Contributor

there are some 120 issues that are fixed by this change (linked above). it is almost a rewrite at this point. give it a try and let us know if there are other issues we are not aware of.

@wclr

Alex (wclr) commented Sep 19, 2016

Copy link
Copy Markdown

give it a try and let us know if there are other issues we are not aware of.

So it is not available yet right? What will be need to it out, just use vscode insiders?

@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Sep 19, 2016

Copy link
Copy Markdown
MemberAuthor

Renamed in favour of (@whitecolor) the issue you mentioned seems to be fixed.

@chrmartiChristof Marti (chrmarti) mentioned this pull request Sep 20, 2016
Closed
@mhegazyMohamed Hegazy (mhegazy) mentioned this pull request Sep 26, 2016
Closed
@farfromrefug

farfromrefuge (farfromrefug) commented Oct 4, 2016

Copy link
Copy Markdown

Sheetal Nandi (@sheetalkamat) is this going to be merged soon? Can i test it already?
Thanks

@mhegazy

Mohamed Hegazy (mhegazy) commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

farfromrefuge (@farfromrefug) you can find these changes in the VSCode extension: https://marketplace.visualstudio.com/items?itemName=ms-vscode.typescript-javascript-grammar

@farfromrefug

farfromrefuge (farfromrefug) commented Oct 5, 2016

Copy link
Copy Markdown

Thanks Mohamed Hegazy (@mhegazy) will test it right away!

This was referenced Oct 10, 2016
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sheetalkamat@msftclas@Tyriar@wclr@mhegazy@octref@farfromrefug