Uh oh!
There was an error while loading. Please reload this page.
Add primitive types null, true, and false - #258
Closed
Patrick Westerhoff (poke) wants to merge 1 commit into
Closed
Conversation
Hi Patrick Westerhoff (@poke), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Mohamed Hegazy (mhegazy)
commented
Sep 16, 2016
Contributor
Patrick Westerhoff (@poke), sorry for the delay. Can you refresh the PR. |
Sheetal Nandi (sheetalkamat)
commented
Sep 16, 2016
Member
Mohamed Hegazy (@mhegazy) and Patrick Westerhoff (@poke) you shouldn't need this change any more as #257 handles this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with TypeScript 2, we can use all kinds of literal types. These three are very common literal types which also happen to be reserved words, so I guess it makes sense to handle them in a special way.
Ultimately, it might make sense to expand the syntax structure for literal types a bit but for now, this is a quick fix.