Skip to content

Add primitive types null, true, and false - #258

Closed
Patrick Westerhoff (poke) wants to merge 1 commit into
microsoft:masterfrom
poke:master
Closed

Add primitive types null, true, and false#258
Patrick Westerhoff (poke) wants to merge 1 commit into
microsoft:masterfrom
poke:master

Conversation

@poke

Copy link
Copy Markdown

Starting with TypeScript 2, we can use all kinds of literal types. These three are very common literal types which also happen to be reserved words, so I guess it makes sense to handle them in a special way.

Ultimately, it might make sense to expand the syntax structure for literal types a bit but for now, this is a quick fix.

@msftclas

Hi Patrick Westerhoff (@poke), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy

Copy link
Copy Markdown
Contributor

Patrick Westerhoff (@poke), sorry for the delay. Can you refresh the PR.

@sheetalkamat

Copy link
Copy Markdown
Member

Mohamed Hegazy (@mhegazy) and Patrick Westerhoff (@poke) you shouldn't need this change any more as #257 handles this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@poke@msftclas@mhegazy@sheetalkamat