Skip to content

Update compilerOptions.jsx to reflect latest preferences - #2994

Merged
Jake Bailey (jakebailey) merged 3 commits into
microsoft:v2from
eps1lon:jsx-default
Jul 8, 2024
Merged

Update compilerOptions.jsx to reflect latest preferences#2994
Jake Bailey (jakebailey) merged 3 commits into
microsoft:v2from
eps1lon:jsx-default

Conversation

@eps1lon

@eps1lonSebastian "Sebbie" Silbermann (eps1lon) commented Dec 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

react-jsx makes the most sense as a default.

Preview

@jakebailey

Jake Bailey (jakebailey) commented Dec 9, 2023

Copy link
Copy Markdown
Member

TODO: PR changing default in TypeScript actual.

The default in TS is undefined, so I'm not sure there's an actual code change needed there besides potentially changing a diagnostic to suggestion one choice over another.

(Additionally, other runtimes than React I believe still use that setting so I doubt it's going to be deprecated in TS)

@jakebailey

Jake Bailey (jakebailey) commented Dec 9, 2023

Copy link
Copy Markdown
Member

Are the discussions for this somewhere that can be linked?

@eps1lonSebastian "Sebbie" Silbermann (eps1lon) changed the title Document new compilerOptions.jsx defaultUpdate compilerOptions.jsx to reflect latest preferencesDec 12, 2023
@eps1lon

Sebastian "Sebbie" Silbermann (eps1lon) commented Dec 12, 2023

Copy link
Copy Markdown
ContributorAuthor

The default in TS is undefined, so I'm not sure there's an actual code change needed there besides potentially changing a diagnostic to suggestion one choice over another.

Yeah, I tried it on a fresh project and you need to specify a value. You can't just run tsc --jsx. So all we need to do is document that there is no default and then we discuss in the React team whether people should prefer react-jsx or react-jsxdev if they have a single tsconfig.json.

eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) commented Dec 12, 2023
View reviewed changes
Comment threadpackages/tsconfig-reference/copy/en/options/jsx.md Outdated

React 17 dev transform: `"react-jsxdev"`<sup>[[1]](https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)</sup>

Legacy runtime: `"react"`

@eps1lonSebastian "Sebbie" Silbermann (eps1lon)Dec 12, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is language we want to use.

@eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) marked this pull request as ready for review December 26, 2023 10:04
@jakebaileyJake Bailey (jakebailey) added the deploy-preview Enables automatic deployments to preview environments on a PR label Jun 5, 2024
eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) commented Jun 5, 2024
View reviewed changes
Comment threadpackages/tsconfig-reference/copy/en/options/jsx.md Outdated
@jakebailey

Jake Bailey (jakebailey) commented Jun 5, 2024

Copy link
Copy Markdown
Member

I think #3064 composes with this?

@eps1lon

Sebastian "Sebbie" Silbermann (eps1lon) commented Jun 6, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This one is more focused and can land separately though, no?

@jakebailey

Jake Bailey (jakebailey) commented Jul 8, 2024

Copy link
Copy Markdown
Member

Close-reopening to verify CI after changes in the repo.

@github-actions

github-actionsBot commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-2994.centralus.5.azurestaticapps.net

@jakebailey
Jake Bailey (jakebailey) merged commit 8417ff5 into microsoft:v2Jul 8, 2024
This was referenced Apr 16, 2025
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes
@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Awaiting requested review from DanielRosenwasser

Assignees

No one assigned

Labels

deploy-previewEnables automatic deployments to preview environments on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eps1lon@jakebailey