Skip to content

Deemphasize old JSX transform - #61586

Merged
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into
microsoft:mainfrom
eps1lon:emphasize-automatic-transform
Apr 17, 2025
Merged

Deemphasize old JSX transform#61586
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into
microsoft:mainfrom
eps1lon:emphasize-automatic-transform

Conversation

@eps1lon

@eps1lonSebastian "Sebbie" Silbermann (eps1lon) commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

People should choose the new, automatic transform
over the old transform which required a React import.

Test plan

Applied changes to local tsc code and ran pnpm tsc test.tsx --jsx:

$ pnpm tsc test.tsx --jsxerror TS6044: Compiler option 'jsx' expects an argument.error TS6046: Argument for '--jsx' option must be: 'preserve', 'react-native', 'react-jsx', 'react-jsxdev', 'react'.

Fixes#61585

Related:

@github-project-automationgithub-project-automationBot moved this to Not started in PR BacklogApr 16, 2025
@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 16, 2025
@jakebailey

Copy link
Copy Markdown
Member

I feel like this is fine, though I suspect there are other places where we order the message the other way around?

@eps1lon

Copy link
Copy Markdown
ContributorAuthor

I couldn't find any when looking for --jsx and react-native.

@github-project-automationgithub-project-automationBot moved this from Not started to Needs merge in PR BacklogApr 17, 2025
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit 0a1aa6d into microsoft:mainApr 17, 2025
@github-project-automationgithub-project-automationBot moved this from Needs merge to Done in PR BacklogApr 17, 2025
@eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) deleted the emphasize-automatic-transform branch April 17, 2025 18:55
@mrazauskas

Copy link
Copy Markdown
Contributor

there are other places where we order the message the other way around

Perhaps, the schema of tsconfig.json? Hard to say if different order would be reflected by code editors.

Reference: https://github.com/SchemaStore/schemastore/blob/ac8666004983f29014f320cb82c9bbe3ec44fae4/src/schemas/json/tsconfig.json#L349-L358

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--jsx react should be deemphasized

7 participants

@eps1lon@jakebailey@mrazauskas@RyanCavanaugh@sandersn@andrewbranch@typescript-bot