Uh oh!
There was an error while loading. Please reload this page.
feat(27615): fixAddMissingMember should work for type literal - #47212
Merged
Gabriela Araujo Britto (gabritto) merged 1 commit intoMar 30, 2022
Merged
Conversation
Nathan Shively-Sanders (sandersn)
requested review from
Gabriela Araujo Britto (gabritto) and Nathan Shively-Sanders (sandersn)
and removed request for
Nathan Shively-Sanders (sandersn)February 16, 2022 00:01
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Member
The original issue (#27615) said "this should work with types defined in jsdoc syntax", but from looking at the code in the codefix, I'm not sure if that could go in the same PR or would be better left separate. Oleksandr Tarasiuk (@a-tarasyuk)Nathan Shively-Sanders (@sandersn) what do you think? |
Oleksandr Tarasiuk (a-tarasyuk)force-pushed
the
feat/27615
branch
from
March 30, 2022 09:44
452fe0d to
692bf5eCompareOleksandr Tarasiuk (a-tarasyuk)
commented
Mar 30, 2022
ContributorAuthor
Gabriela Araujo Britto (@gabritto) Thanks for the review. You are right, all actions in |
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Gabriela Araujo Britto (gabritto)March 30, 2022 10:47
Gabriela Araujo Britto (gabritto)
approved these changes
Mar 30, 2022
Gabriela Araujo Britto (gabritto)
left a comment
Member
There was a problem hiding this comment.
thanks
Sidharth Vinod (sidharthv96) added a commit
to sidharthv96/TypeScript
that referenced
this pull request
Apr 1, 2022
* upstream/main: (473 commits) Correct node used for isDefinition calculation (microsoft#48499) fix(48405): emit dummy members from a mapped type (microsoft#48481) CFA for dependent parameters typed by generic constraints (microsoft#48411) No contextual typing from return types for boolean literals (microsoft#48380) fix(47733): omit JSDoc comment template suggestion on node with existing JSDoc (microsoft#47748) Ensure that we copy empty NodeArrays during transform (microsoft#48490) Add a new compiler option `moduleSuffixes` to expand the node module resolver's search algorithm (microsoft#48189) feat(27615): Add missing member fix should work for type literals (microsoft#47212) Add label details to completion entry (microsoft#48429) Enable method signature completion for object literals (microsoft#48168) Fix string literal completions when a partially-typed string fixes inference to a type parameter (microsoft#48410) fix(48445): show errors on type-only import/export specifiers in JavaScript files (microsoft#48449) Fix newline inserted in empty block at end of formatting range (microsoft#48463) Prevent looking up symbol for as const from triggering an error (microsoft#48464) Revise accessor resolution logic and error reporting (microsoft#48459) fix(48166): skip checking module.exports in a truthiness call expression (microsoft#48337) LEGO: Merge pull request 48450 LEGO: Merge pull request 48436 fix(48031): show circularity error for self referential get accessor annotations (microsoft#48050) Revert "Fix contextual discrimination for omitted members (microsoft#43937)" (microsoft#48426) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#27615