Uh oh!
There was an error while loading. Please reload this page.
Ensure that we copy empty NodeArrays during transform - #48490
Merged
Conversation
Jake Bailey (jakebailey)
commented
Mar 30, 2022
MemberAuthor
TypeScript Bot (@typescript-bot) perf test this inline |
Contributor
Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 944315e. You can monitor the build here. Update: The results are in! |
TypeScript Bot (typescript-bot)
commented
Mar 30, 2022
Contributor
Jake Bailey (@jakebailey) Here they are:Comparison Report - main..48490
System
Hosts
Scenarios
Developer Information: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Jake Bailey (jakebailey)
requested review from
Gabriela Araujo Britto (gabritto) and Wesley Wigham (weswigham)March 30, 2022 21:43
Gabriela Araujo Britto (gabritto)
approved these changes
Mar 30, 2022
Wesley Wigham (weswigham)
approved these changes
Mar 30, 2022
Sidharth Vinod (sidharthv96) added a commit
to sidharthv96/TypeScript
that referenced
this pull request
Apr 1, 2022
* upstream/main: (473 commits) Correct node used for isDefinition calculation (microsoft#48499) fix(48405): emit dummy members from a mapped type (microsoft#48481) CFA for dependent parameters typed by generic constraints (microsoft#48411) No contextual typing from return types for boolean literals (microsoft#48380) fix(47733): omit JSDoc comment template suggestion on node with existing JSDoc (microsoft#47748) Ensure that we copy empty NodeArrays during transform (microsoft#48490) Add a new compiler option `moduleSuffixes` to expand the node module resolver's search algorithm (microsoft#48189) feat(27615): Add missing member fix should work for type literals (microsoft#47212) Add label details to completion entry (microsoft#48429) Enable method signature completion for object literals (microsoft#48168) Fix string literal completions when a partially-typed string fixes inference to a type parameter (microsoft#48410) fix(48445): show errors on type-only import/export specifiers in JavaScript files (microsoft#48449) Fix newline inserted in empty block at end of formatting range (microsoft#48463) Prevent looking up symbol for as const from triggering an error (microsoft#48464) Revise accessor resolution logic and error reporting (microsoft#48459) fix(48166): skip checking module.exports in a truthiness call expression (microsoft#48337) LEGO: Merge pull request 48450 LEGO: Merge pull request 48436 fix(48031): show circularity error for self referential get accessor annotations (microsoft#48050) Revert "Fix contextual discrimination for omitted members (microsoft#43937)" (microsoft#48426) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#48379
Fixes#45744 (most likely)
In order to offer snippet completion for method overrides, we emit code. During emit, each node gets
__posand__endproperties as a side effect, so that later those positions relative to the just-emitted text can be used.To produce the code for the override, we convert signatures, which involves converting types to nodes. Unfortunately, the empty
NodeArrayinside of the type{}was getting cached then reused instead of cached then cloned. This led to every instance of{}in the transformed tree being the same object, which then caused emit to set position info more than once on the same node, which then caused debug assertions because earlier{}s would have the position info from the last{}, which isn't legal.So, during transform, when we are explicitly doing that "deep copy or reuse", actually ensure that a copy happens for empty
NodeArrays.I feel like it would be better for
visitNodesto do this, orcreateNodeArrayto do it, or similar, but doing so breaks some cases where it appears as though callers ofvisitNodesassume that the array is returned unmodified if empty, breaking some 25 cases.