Properly propagate ObjectFlags.NonInferrableType, clean up non-inferrable code paths by jakebailey · Pull Request #49887 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2022-07-13T04:44:59Z

The original bug required two changes to fix:

The NonInferrableType flag needs to be propagated from aliasTypeArguments to the type they're used in, but this was missed in at least one place.
Inference returns silentNeverType as its marker type to say "don't infer from this", but it only checked for source === silentNeverType, which doesn't work when you use that type in another type. So this needs to be NonInferrableType too.

The rest of the changes are cleanups and documentation improvements.

It turns out that nonInferrableType is redundant with silentNeverType, and there are other types like anyFunctionType, autoType, and autoArrayType which are also used as marker types for this same purpose. They all can just use the flag without any changes in behavior.
nonInferrableAnyType looks like it should be NonInferrableType, but making it have that flag breaks things. It turns out that if you just use anyType, nothing breaks.

…g NonInferrableType, but breaks if it does

Wesley Wigham (weswigham) · 2022-07-13T20:57:51Z

 result.mapper = mapper;
 result.aliasSymbol = aliasSymbol || type.aliasSymbol;
 result.aliasTypeArguments = aliasSymbol ? aliasTypeArguments : instantiateTypes(type.aliasTypeArguments, mapper);
+ result.objectFlags |= result.aliasTypeArguments ? getPropagatingFlagsOfTypes(result.aliasTypeArguments, /*excludeKinds*/ 0) : 0;


Huh, this is interesting because this is redundant for TypeReference anonymous types (since those internally collect propagating flags from their type arguments), but required for any other anonymous object type with an alias. Go figure. I wonder if we should be propagating these object flags through conditional types, too... We already preserve them through intersections and unions. (We probably should be, since conditionals are "smart unions"...)

Yes, I think they should. Right now I'm trying to go by hand to every createAnonymousType, createObjectType,... etc and see if there's anything missed, and it's a bit daunting because there's like 100 of them to verify, and nothing I've changed so far as actually changed any test.
I want to have something I can run while I'm debugging that'll observe each type during inference and walk down to see if there was a NonInferrableType flag that was missed, but I get stuck in stack overflows, so I don't quite know how I can do my sanity check.

I think for this PR, I'm inclined to not try and go everywhere and add some more flag propagation without a way for me to check these; I just don't trust that I'm getting it right, and I don't have any way to observe the result.
This PR at least improves the one case I can test, and has a good amount of cleanup, so I'm happy with it (but I'll rerun the testing since I changed the structure of this quite a bit).

Jake Bailey (jakebailey) · 2022-07-13T21:30:36Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2022-07-13T21:30:39Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at dd6bdaf. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-07-13T21:30:39Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at dd6bdaf. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-07-13T21:46:27Z

Heya Jake Bailey (@jakebailey), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

Wesley Wigham (weswigham)

Assuming rwc and DT are good, this seems like a good consolidation.

TypeScript Bot (typescript-bot) · 2022-07-13T21:47:51Z

Jake Bailey (@jakebailey)
The results of the user tests run you requested are in!

Here they are:

Comparison Report - main..refs/pull/49887/merge

fp-ts

2 of 4 projects failed to build with the old tsc

dtslint/ts3.5/tsconfig.json

error TS2571: Object is of type 'unknown'.

Jake Bailey (jakebailey) · 2022-07-13T21:53:47Z

Hm, those fp-ts things seem relevant. I was hoping those would go away, but I guess not.

Jake Bailey (jakebailey) · 2022-07-13T22:11:03Z

Yeah, the actual fix in this PR breaks fp-ts's Either type, which looks a lot like one of the other types I saw break when I was working on propagating flags. I'll port a test.

TypeScript Bot (typescript-bot) · 2022-07-13T22:11:22Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..49887

_Metric	_main	₄₉₈₈₇	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{359,686k (± 0.02%)}	_{359,625k (± 0.01%)}	_{-61k (- 0.02%)}	_359,515k	_359,745k
_{Parse Time}	_{2.09s (± 0.35%)}	_{2.08s (± 0.42%)}	_{-0.00s (- 0.24%)}	_2.06s	_2.10s
_{Bind Time}	_{0.90s (± 0.98%)}	_{0.90s (± 1.12%)}	_{-0.01s (- 0.78%)}	_0.88s	_0.93s
_{Check Time}	_{5.99s (± 0.34%)}	_{6.01s (± 0.40%)}	_{+0.01s (+ 0.25%)}	_5.95s	_6.07s
_{Emit Time}	_{6.11s (± 0.75%)}	_{6.11s (± 0.30%)}	_{+0.00s (+ 0.07%)}	_6.08s	_6.17s
_{Total Time}	_{15.09s (± 0.36%)}	_{15.10s (± 0.18%)}	_{+0.01s (+ 0.07%)}	_15.06s	_15.19s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{206,703k (± 0.03%)}	_{206,670k (± 0.04%)}	_{-34k (- 0.02%)}	_206,501k	_206,933k
_{Parse Time}	_{0.83s (± 0.69%)}	_{0.83s (± 0.48%)}	_{+0.00s (+ 0.12%)}	_0.82s	_0.84s
_{Bind Time}	_{0.53s (± 1.76%)}	_{0.52s (± 2.11%)}	_{-0.01s (- 0.95%)}	_0.51s	_0.55s
_{Check Time}	_{7.09s (± 0.32%)}	_{7.13s (± 0.48%)}	_{+0.04s (+ 0.54%)}	_7.06s	_7.22s
_{Emit Time}	_{2.50s (± 1.25%)}	_{2.50s (± 0.70%)}	_{-0.00s (- 0.16%)}	_2.47s	_2.56s
_{Total Time}	_{10.95s (± 0.36%)}	_{10.98s (± 0.35%)}	_{+0.03s (+ 0.26%)}	_10.90s	_11.09s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{343,991k (± 0.02%)}	_{343,968k (± 0.02%)}	_{-22k (- 0.01%)}	_343,710k	_344,077k
_{Parse Time}	_{1.60s (± 0.37%)}	_{1.60s (± 0.78%)}	_{+0.00s (+ 0.25%)}	_1.57s	_1.63s
_{Bind Time}	_{0.77s (± 0.68%)}	_{0.78s (± 2.10%)}	_{+0.01s (+ 1.04%)}	_0.76s	_0.84s
_{Check Time}	_{5.95s (± 0.47%)}	_{5.98s (± 0.53%)}	_{+0.03s (+ 0.52%)}	_5.88s	_6.03s
_{Emit Time}	_{3.24s (± 0.40%)}	_{3.27s (± 0.77%)}	_{+0.02s (+ 0.77%)}	_3.22s	_3.33s
_{Total Time}	_{11.56s (± 0.21%)}	_{11.63s (± 0.51%)}	_{+0.07s (+ 0.61%)}	_11.53s	_11.76s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{305,162k (± 0.02%)}	_{305,156k (± 0.02%)}	_{-6k (- 0.00%)}	_305,082k	_305,253k
_{Parse Time}	_{1.27s (± 0.59%)}	_{1.28s (± 0.58%)}	_{+0.01s (+ 0.47%)}	_1.27s	_1.30s
_{Bind Time}	_{0.72s (± 0.51%)}	_{0.73s (± 0.61%)}	_{+0.00s (+ 0.41%)}	_0.72s	_0.74s
_{Check Time}	_{5.40s (± 0.43%)}	_{5.42s (± 0.62%)}	_{+0.03s (+ 0.50%)}	_5.34s	_5.49s
_{Emit Time}	_{3.42s (± 1.08%)}	_{3.41s (± 0.89%)}	_{-0.01s (- 0.41%)}	_3.34s	_3.47s
_{Total Time}	_{10.82s (± 0.45%)}	_{10.84s (± 0.43%)}	_{+0.02s (+ 0.23%)}	_10.72s	_10.93s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{469,401k (± 0.01%)}	_{469,401k (± 0.01%)}	_{+0k (+ 0.00%)}	_469,271k	_469,566k
_{Parse Time}	_{1.82s (± 0.69%)}	_{1.83s (± 0.75%)}	_{+0.01s (+ 0.44%)}	_1.81s	_1.86s
_{Bind Time}	_{0.69s (± 2.28%)}	_{0.68s (± 1.44%)}	_{-0.01s (- 1.02%)}	_0.66s	_0.70s
_{Check Time}	_{14.51s (± 0.56%)}	_{14.58s (± 0.83%)}	_{+0.08s (+ 0.52%)}	_14.38s	_14.81s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{17.02s (± 0.51%)}	_{17.10s (± 0.73%)}	_{+0.08s (+ 0.45%)}	_16.90s	_17.33s
_{xstate - node (v10.16.3, x64)}
_{Memory used}	_{581,242k (± 1.26%)}	_{581,307k (± 1.26%)}	_{+65k (+ 0.01%)}	_577,874k	_610,906k
_{Parse Time}	_{2.59s (± 0.26%)}	_{2.59s (± 0.35%)}	_{-0.00s (- 0.15%)}	_2.57s	_2.61s
_{Bind Time}	_{1.03s (± 1.34%)}	_{1.03s (± 0.68%)}	_{+0.00s (+ 0.19%)}	_1.02s	_1.05s
_{Check Time}	_{1.56s (± 0.49%)}	_{1.56s (± 0.44%)}	_{0.00s ( 0.00%)}	_1.54s	_1.57s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.24s (± 0.39%)}	_{5.24s (± 0.29%)}	_{+0.00s (+ 0.08%)}	_5.22s	_5.28s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{337,292k (± 0.02%)}	_{337,143k (± 0.09%)}	_{-149k (- 0.04%)}	_335,952k	_337,406k
_{Parse Time}	_{2.09s (± 0.40%)}	_{2.10s (± 0.69%)}	_{+0.01s (+ 0.57%)}	_2.08s	_2.15s
_{Bind Time}	_{0.86s (± 0.46%)}	_{0.86s (± 0.52%)}	_{+0.00s (+ 0.12%)}	_0.85s	_0.87s
_{Check Time}	_{5.81s (± 0.59%)}	_{5.83s (± 0.53%)}	_{+0.02s (+ 0.36%)}	_5.76s	_5.90s
_{Emit Time}	_{6.35s (± 0.78%)}	_{6.37s (± 0.54%)}	_{+0.02s (+ 0.30%)}	_6.30s	_6.44s
_{Total Time}	_{15.11s (± 0.48%)}	_{15.16s (± 0.43%)}	_{+0.05s (+ 0.30%)}	_15.05s	_15.31s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{194,308k (± 0.09%)}	_{194,353k (± 0.04%)}	_{+45k (+ 0.02%)}	_194,228k	_194,517k
_{Parse Time}	_{0.82s (± 0.83%)}	_{0.83s (± 0.82%)}	_{+0.00s (+ 0.12%)}	_0.81s	_0.84s
_{Bind Time}	_{0.55s (± 1.33%)}	_{0.55s (± 1.06%)}	_{-0.00s (- 0.18%)}	_0.54s	_0.56s
_{Check Time}	_{6.67s (± 0.48%)}	_{6.70s (± 0.43%)}	_{+0.03s (+ 0.37%)}	_6.64s	_6.78s
_{Emit Time}	_{2.54s (± 1.47%)}	_{2.54s (± 0.68%)}	_{+0.01s (+ 0.24%)}	_2.50s	_2.59s
_{Total Time}	_{10.58s (± 0.60%)}	_{10.61s (± 0.43%)}	_{+0.03s (+ 0.32%)}	_10.53s	_10.76s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{326,957k (± 0.02%)}	_{326,991k (± 0.02%)}	_{+34k (+ 0.01%)}	_326,889k	_327,090k
_{Parse Time}	_{1.57s (± 0.33%)}	_{1.57s (± 0.57%)}	_{+0.00s (+ 0.19%)}	_1.55s	_1.59s
_{Bind Time}	_{0.76s (± 0.76%)}	_{0.76s (± 0.59%)}	_{-0.00s (- 0.26%)}	_0.75s	_0.77s
_{Check Time}	_{5.80s (± 0.72%)}	_{5.80s (± 0.68%)}	_{+0.00s (+ 0.05%)}	_5.74s	_5.92s
_{Emit Time}	_{3.30s (± 0.84%)}	_{3.30s (± 0.71%)}	_{-0.00s (- 0.15%)}	_3.26s	_3.36s
_{Total Time}	_{11.43s (± 0.54%)}	_{11.43s (± 0.41%)}	_{+0.00s (+ 0.00%)}	_11.32s	_11.59s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{289,814k (± 0.02%)}	_{289,687k (± 0.05%)}	_{-127k (- 0.04%)}	_289,141k	_289,849k
_{Parse Time}	_{1.29s (± 0.90%)}	_{1.30s (± 0.63%)}	_{+0.01s (+ 0.69%)}	_1.29s	_1.33s
_{Bind Time}	_{0.72s (± 0.82%)}	_{0.73s (± 1.04%)}	_{+0.00s (+ 0.28%)}	_0.71s	_0.74s
_{Check Time}	_{5.35s (± 0.57%)}	_{5.36s (± 0.41%)}	_{+0.01s (+ 0.17%)}	_5.32s	_5.41s
_{Emit Time}	_{3.55s (± 1.07%)}	_{3.53s (± 0.87%)}	_{-0.02s (- 0.68%)}	_3.45s	_3.58s
_{Total Time}	_{10.93s (± 0.42%)}	_{10.92s (± 0.44%)}	_{-0.00s (- 0.03%)}	_10.82s	_11.03s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{448,440k (± 0.07%)}	_{448,249k (± 0.08%)}	_{-191k (- 0.04%)}	_447,267k	_448,611k
_{Parse Time}	_{1.83s (± 0.41%)}	_{1.82s (± 0.57%)}	_{-0.00s (- 0.22%)}	_1.81s	_1.85s
_{Bind Time}	_{0.68s (± 0.95%)}	_{0.68s (± 0.50%)}	_{+0.00s (+ 0.74%)}	_0.68s	_0.69s
_{Check Time}	_{12.99s (± 0.43%)}	_{13.09s (± 0.77%)}	_{+0.09s (+ 0.72%)}	_12.94s	_13.30s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.50s (± 0.35%)}	_{15.59s (± 0.64%)}	_{+0.09s (+ 0.61%)}	_15.45s	_15.79s
_{xstate - node (v12.1.0, x64)}
_{Memory used}	_{543,455k (± 0.01%)}	_{543,421k (± 0.02%)}	_{-34k (- 0.01%)}	_543,192k	_543,618k
_{Parse Time}	_{2.56s (± 0.30%)}	_{2.56s (± 0.37%)}	_{0.00s ( 0.00%)}	_2.53s	_2.57s
_{Bind Time}	_{1.03s (± 1.37%)}	_{1.03s (± 1.29%)}	_{+0.01s (+ 0.68%)}	_1.01s	_1.06s
_{Check Time}	_{1.50s (± 0.32%)}	_{1.50s (± 0.39%)}	_{+0.01s (+ 0.40%)}	_1.49s	_1.52s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 3.14%)}	_{+0.00s (+ 1.43%)}	_0.07s	_0.08s
_{Total Time}	_{5.15s (± 0.31%)}	_{5.17s (± 0.33%)}	_{+0.01s (+ 0.27%)}	_5.13s	_5.21s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{335,438k (± 0.01%)}	_{335,451k (± 0.01%)}	_{+13k (+ 0.00%)}	_335,385k	_335,542k
_{Parse Time}	_{2.06s (± 0.60%)}	_{2.07s (± 0.52%)}	_{+0.01s (+ 0.63%)}	_2.05s	_2.09s
_{Bind Time}	_{0.90s (± 0.44%)}	_{0.90s (± 0.68%)}	_{+0.00s (+ 0.22%)}	_0.89s	_0.91s
_{Check Time}	_{5.78s (± 0.52%)}	_{5.82s (± 0.48%)}	_{+0.04s (+ 0.71%)}	_5.75s	_5.88s
_{Emit Time}	_{6.36s (± 0.61%)}	_{6.41s (± 0.68%)}	_{+0.05s (+ 0.79%)}	_6.31s	_6.50s
_{Total Time}	_{15.10s (± 0.43%)}	_{15.20s (± 0.45%)}	_{+0.11s (+ 0.70%)}	_15.06s	_15.32s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,832k (± 0.01%)}	_{192,851k (± 0.02%)}	_{+19k (+ 0.01%)}	_192,754k	_192,910k
_{Parse Time}	_{0.85s (± 0.78%)}	_{0.85s (± 0.61%)}	_{-0.00s (- 0.12%)}	_0.84s	_0.86s
_{Bind Time}	_{0.57s (± 1.01%)}	_{0.58s (± 0.77%)}	_{+0.00s (+ 0.87%)}	_0.57s	_0.59s
_{Check Time}	_{6.69s (± 0.40%)}	_{6.73s (± 0.74%)}	_{+0.04s (+ 0.58%)}	_6.63s	_6.84s
_{Emit Time}	_{2.48s (± 0.79%)}	_{2.49s (± 0.91%)}	_{+0.02s (+ 0.65%)}	_2.45s	_2.54s
_{Total Time}	_{10.59s (± 0.41%)}	_{10.65s (± 0.58%)}	_{+0.06s (+ 0.58%)}	_10.56s	_10.79s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,716k (± 0.01%)}	_{325,729k (± 0.01%)}	_{+12k (+ 0.00%)}	_325,683k	_325,779k
_{Parse Time}	_{1.58s (± 0.66%)}	_{1.59s (± 0.79%)}	_{+0.01s (+ 0.38%)}	_1.56s	_1.62s
_{Bind Time}	_{0.79s (± 0.82%)}	_{0.80s (± 1.34%)}	_{+0.01s (+ 1.40%)}	_0.79s	_0.84s
_{Check Time}	_{5.67s (± 0.54%)}	_{5.70s (± 0.74%)}	_{+0.03s (+ 0.46%)}	_5.57s	_5.78s
_{Emit Time}	_{3.37s (± 1.12%)}	_{3.35s (± 0.50%)}	_{-0.01s (- 0.45%)}	_3.32s	_3.40s
_{Total Time}	_{11.41s (± 0.44%)}	_{11.44s (± 0.43%)}	_{+0.03s (+ 0.25%)}	_11.30s	_11.53s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{288,800k (± 0.01%)}	_{288,801k (± 0.01%)}	_{+1k (+ 0.00%)}	_288,730k	_288,831k
_{Parse Time}	_{1.34s (± 2.13%)}	_{1.33s (± 1.13%)}	_{-0.01s (- 0.97%)}	_1.30s	_1.37s
_{Bind Time}	_{0.75s (± 1.27%)}	_{0.78s (± 4.59%)}	_{+0.03s (+ 4.69%)}	_0.74s	_0.86s
_{Check Time}	_{5.34s (± 0.41%)}	_{5.35s (± 0.31%)}	_{+0.01s (+ 0.21%)}	_5.31s	_5.38s
_{Emit Time}	_{3.57s (± 2.08%)}	_{3.57s (± 2.07%)}	_{+0.00s (+ 0.11%)}	_3.46s	_3.71s
_{Total Time}	_{11.00s (± 0.73%)}	_{11.03s (± 0.78%)}	_{+0.04s (+ 0.35%)}	_10.86s	_11.24s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{446,674k (± 0.00%)}	_{446,639k (± 0.01%)}	_{-34k (- 0.01%)}	_446,558k	_446,687k
_{Parse Time}	_{1.87s (± 0.40%)}	_{1.88s (± 0.24%)}	_{+0.01s (+ 0.59%)}	_1.87s	_1.89s
_{Bind Time}	_{0.73s (± 0.61%)}	_{0.74s (± 1.03%)}	_{+0.00s (+ 0.55%)}	_0.71s	_0.75s
_{Check Time}	_{13.11s (± 0.72%)}	_{13.17s (± 0.72%)}	_{+0.05s (+ 0.40%)}	_12.98s	_13.33s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.71s (± 0.61%)}	_{15.78s (± 0.65%)}	_{+0.07s (+ 0.43%)}	_15.60s	_15.96s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{541,296k (± 0.00%)}	_{541,296k (± 0.01%)}	_{-0k (- 0.00%)}	_541,254k	_541,394k
_{Parse Time}	_{2.60s (± 0.50%)}	_{2.60s (± 0.45%)}	_{+0.00s (+ 0.12%)}	_2.58s	_2.63s
_{Bind Time}	_{1.15s (± 1.69%)}	_{1.16s (± 1.21%)}	_{+0.01s (+ 0.96%)}	_1.12s	_1.19s
_{Check Time}	_{1.55s (± 0.38%)}	_{1.55s (± 0.71%)}	_{+0.00s (+ 0.26%)}	_1.53s	_1.58s
_{Emit Time}	_{0.07s (± 4.66%)}	_{0.07s (± 0.00%)}	_{🟩-0.00s (- 4.11%)}	_0.07s	_0.07s
_{Total Time}	_{5.37s (± 0.53%)}	_{5.38s (± 0.38%)}	_{+0.02s (+ 0.32%)}	_5.34s	_5.42s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v10.16.3, x64)
xstate - node (v12.1.0, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₉₈₈₇	₁₀
_Baseline	_main	₁₀

TSServer

Comparison Report - main..49887

_Metric	_main	₄₉₈₈₇	_Delta	_Best	_Worst
_{xstateTSServer - node (v10.16.3, x64)}
_{Initial load time}	_{2,155.50ms (± 0.45%)}	_{2,162.00ms (± 0.62%)}	_{+6.50ms (+ 0.30%)}	_2,141.00ms	_2,200.00ms
_{Geterr time}	_{762.70ms (± 0.33%)}	_{764.40ms (± 0.90%)}	_{+1.70ms (+ 0.22%)}	_755.00ms	_785.00ms
_{References time}	_{96.20ms (± 1.72%)}	_{96.20ms (± 2.01%)}	_{0.00ms ( 0.00%)}	_93.00ms	_101.00ms
_{Navto time}	_{254.20ms (± 1.11%)}	_{253.30ms (± 1.03%)}	_{-0.90ms (- 0.35%)}	_249.00ms	_260.00ms
_{Navto count}	_{256.00 (± 0.00%)}	_{256.00 (± 0.00%)}	_{0.00 ( 0.00%)}	_256.00	_256.00
_{Completions time}	_{243.00ms (± 0.80%)}	_{247.60ms (± 1.00%)}	_{+4.60ms (+ 1.89%)}	_242.00ms	_254.00ms
_{Completions count}	_{3,205.00 (± 0.00%)}	_{3,205.00 (± 0.00%)}	_{0.00 ( 0.00%)}	_3,205.00	_3,205.00
_{xstateTSServer - node (v12.1.0, x64)}
_{Initial load time}	_{2,095.00ms (± 0.52%)}	_{2,102.50ms (± 0.88%)}	_{+7.50ms (+ 0.36%)}	_2,067.00ms	_2,146.00ms
_{Geterr time}	_{752.00ms (± 0.43%)}	_{749.60ms (± 0.37%)}	_{-2.40ms (- 0.32%)}	_745.00ms	_756.00ms
_{References time}	_{68.40ms (± 1.39%)}	_{69.00ms (± 1.98%)}	_{+0.60ms (+ 0.88%)}	_67.00ms	_74.00ms
_{Navto time}	_{240.60ms (± 1.82%)}	_{241.00ms (± 1.14%)}	_{+0.40ms (+ 0.17%)}	_231.00ms	_245.00ms
_{Navto count}	_{256.00 (± 0.00%)}	_{256.00 (± 0.00%)}	_{0.00 ( 0.00%)}	_256.00	_256.00
_{Completions time}	_{238.40ms (± 0.75%)}	_{241.20ms (± 0.71%)}	_{+2.80ms (+ 1.17%)}	_237.00ms	_244.00ms
_{Completions count}	_{3,205.00 (± 0.00%)}	_{3,205.00 (± 0.00%)}	_{0.00 ( 0.00%)}	_3,205.00	_3,205.00
_{xstateTSServer - node (v14.15.1, x64)}
_{Initial load time}	_{2,222.80ms (± 0.38%)}	_{2,230.70ms (± 0.58%)}	_{+7.90ms (+ 0.36%)}	_2,213.00ms	_2,271.00ms
_{Geterr time}	_{765.60ms (± 0.23%)}	_{770.60ms (± 0.49%)}	_{+5.00ms (+ 0.65%)}	_764.00ms	_782.00ms
_{References time}	_{64.40ms (± 1.28%)}	_{64.80ms (± 1.23%)}	_{+0.40ms (+ 0.62%)}	_64.00ms	_67.00ms
_{Navto time}	_{250.00ms (± 0.73%)}	_{250.50ms (± 0.89%)}	_{+0.50ms (+ 0.20%)}	_247.00ms	_257.00ms
_{Navto count}	_{256.00 (± 0.00%)}	_{256.00 (± 0.00%)}	_{0.00 ( 0.00%)}	_256.00	_256.00
_{Completions time}	_{241.90ms (± 0.57%)}	_{247.50ms (± 4.38%)}	_{+5.60ms (+ 2.32%)}	_241.00ms	_291.00ms
_{Completions count}	_{3,205.00 (± 0.00%)}	_{3,205.00 (± 0.00%)}	_{0.00 ( 0.00%)}	_3,205.00	_3,205.00

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

xstateTSServer - node (v10.16.3, x64)
xstateTSServer - node (v12.1.0, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₉₈₈₇	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

…lavent when the non-inferrable type was an any

Jake Bailey (jakebailey) · 2022-07-14T21:58:29Z

Figured this out; we basically just needed to revert #26678, which worked around problems with non-inferrable types before the current non-inferrable flag and proper propagation was implemented.

Jake Bailey (jakebailey) · 2022-07-14T21:59:05Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2022-07-14T21:59:07Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 9e831ec. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-07-14T21:59:07Z

Heya Jake Bailey (@jakebailey), I've started to run the abridged perf test suite on this PR at 9e831ec. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-07-14T21:59:07Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 9e831ec. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-07-14T21:59:07Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 9e831ec. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-07-14T22:14:02Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49887

_Metric	_main	₄₉₈₈₇	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{335,892k (± 0.01%)}	_{335,919k (± 0.01%)}	_{+28k (+ 0.01%)}	_335,876k	_335,995k
_{Parse Time}	_{2.06s (± 0.71%)}	_{2.06s (± 0.63%)}	_{-0.00s (- 0.24%)}	_2.04s	_2.10s
_{Bind Time}	_{0.89s (± 1.10%)}	_{0.89s (± 0.41%)}	_{+0.00s (+ 0.22%)}	_0.89s	_0.90s
_{Check Time}	_{5.80s (± 0.64%)}	_{5.79s (± 0.45%)}	_{-0.01s (- 0.22%)}	_5.73s	_5.84s
_{Emit Time}	_{6.40s (± 1.34%)}	_{6.36s (± 0.58%)}	_{-0.04s (- 0.67%)}	_6.28s	_6.43s
_{Total Time}	_{15.15s (± 0.83%)}	_{15.09s (± 0.41%)}	_{-0.06s (- 0.39%)}	_14.98s	_15.20s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,850k (± 0.01%)}	_{193,172k (± 0.38%)}	_{+322k (+ 0.17%)}	_192,794k	_196,118k
_{Parse Time}	_{0.86s (± 0.69%)}	_{0.85s (± 0.86%)}	_{-0.01s (- 0.93%)}	_0.84s	_0.87s
_{Bind Time}	_{0.57s (± 1.30%)}	_{0.57s (± 1.32%)}	_{+0.00s (+ 0.88%)}	_0.56s	_0.59s
_{Check Time}	_{6.72s (± 0.71%)}	_{6.70s (± 0.66%)}	_{-0.02s (- 0.36%)}	_6.62s	_6.80s
_{Emit Time}	_{2.48s (± 0.82%)}	_{2.48s (± 0.70%)}	_{-0.00s (- 0.20%)}	_2.43s	_2.52s
_{Total Time}	_{10.63s (± 0.51%)}	_{10.60s (± 0.51%)}	_{-0.03s (- 0.28%)}	_10.50s	_10.70s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,710k (± 0.01%)}	_{325,724k (± 0.00%)}	_{+14k (+ 0.00%)}	_325,689k	_325,746k
_{Parse Time}	_{1.58s (± 0.84%)}	_{1.58s (± 0.65%)}	_{-0.00s (- 0.25%)}	_1.56s	_1.61s
_{Bind Time}	_{0.79s (± 0.63%)}	_{0.78s (± 0.85%)}	_{-0.00s (- 0.25%)}	_0.77s	_0.80s
_{Check Time}	_{5.70s (± 0.33%)}	_{5.69s (± 0.52%)}	_{-0.01s (- 0.14%)}	_5.64s	_5.74s
_{Emit Time}	_{3.36s (± 0.39%)}	_{3.36s (± 0.86%)}	_{+0.00s (+ 0.15%)}	_3.32s	_3.43s
_{Total Time}	_{11.42s (± 0.29%)}	_{11.41s (± 0.53%)}	_{-0.01s (- 0.08%)}	_11.31s	_11.54s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{288,817k (± 0.01%)}	_{288,809k (± 0.01%)}	_{-9k (- 0.00%)}	_288,763k	_288,870k
_{Parse Time}	_{1.33s (± 1.67%)}	_{1.32s (± 1.11%)}	_{-0.01s (- 0.75%)}	_1.29s	_1.35s
_{Bind Time}	_{0.77s (± 3.32%)}	_{0.78s (± 4.79%)}	_{+0.01s (+ 1.04%)}	_0.73s	_0.86s
_{Check Time}	_{5.35s (± 0.54%)}	_{5.32s (± 0.28%)}	_{-0.02s (- 0.39%)}	_5.29s	_5.37s
_{Emit Time}	_{3.58s (± 2.22%)}	_{3.53s (± 2.20%)}	_{-0.06s (- 1.62%)}	_3.41s	_3.71s
_{Total Time}	_{11.02s (± 0.91%)}	_{10.95s (± 0.90%)}	_{-0.07s (- 0.68%)}	_10.78s	_11.19s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{446,681k (± 0.01%)}	_{446,540k (± 0.06%)}	_{-142k (- 0.03%)}	_445,488k	_446,715k
_{Parse Time}	_{1.87s (± 0.51%)}	_{1.87s (± 0.48%)}	_{-0.00s (- 0.16%)}	_1.85s	_1.89s
_{Bind Time}	_{0.72s (± 1.36%)}	_{0.72s (± 1.30%)}	_{-0.00s (- 0.28%)}	_0.70s	_0.74s
_{Check Time}	_{13.12s (± 0.72%)}	_{13.19s (± 1.11%)}	_{+0.07s (+ 0.52%)}	_12.90s	_13.52s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.72s (± 0.68%)}	_{15.78s (± 0.96%)}	_{+0.07s (+ 0.41%)}	_15.49s	_16.14s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{541,287k (± 0.01%)}	_{541,253k (± 0.00%)}	_{-34k (- 0.01%)}	_541,220k	_541,286k
_{Parse Time}	_{2.61s (± 0.67%)}	_{2.60s (± 0.37%)}	_{-0.01s (- 0.42%)}	_2.57s	_2.61s
_{Bind Time}	_{1.15s (± 1.35%)}	_{1.14s (± 0.97%)}	_{-0.01s (- 1.04%)}	_1.11s	_1.17s
_{Check Time}	_{1.55s (± 0.61%)}	_{1.54s (± 0.42%)}	_{-0.01s (- 0.52%)}	_1.53s	_1.56s
_{Emit Time}	_{0.07s (± 4.92%)}	_{0.07s (± 0.00%)}	_{🟩-0.00s (- 5.41%)}	_0.07s	_0.07s
_{Total Time}	_{5.38s (± 0.54%)}	_{5.35s (± 0.31%)}	_{-0.03s (- 0.50%)}	_5.31s	_5.38s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₉₈₈₇	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2022-07-14T22:16:17Z

Jake Bailey (@jakebailey)
Great news! no new errors were found between main..refs/pull/49887/merge

Jake Bailey (jakebailey) · 2022-07-15T01:32:56Z

All the tests look clean, phew.

Jake Bailey (jakebailey) added 2 commits July 12, 2022 21:42

Add test
f6a2bed

Ensure flags are propogated when instantiating anonymous types
f5db542

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey)Jul 13, 2022

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 13, 2022

This comment was marked as outdated.
Sign in to view

Jake Bailey (jakebailey) added 5 commits July 13, 2022 11:24

Always return on equal aliasSymbol
3f02cba

Just use flag to check for non-inferrable types
b875b3e

Eliminate nonInferrableType
66dbd1d

Also remove nonInferrableAnyType, which looks like it should have fla…
0db958c
…g NonInferrableType, but breaks if it does

Make autoType non-inferrable instead of checking explicitly
6dad0a4

Jake Bailey (jakebailey)force-pushed the fix-43962 branch from 2b69b97 to ba8c888Compare July 13, 2022 18:51

Rewrite and move comment to the correct place
2974d9a

Jake Bailey (jakebailey)force-pushed the fix-43962 branch from ba8c888 to 2974d9aCompare July 13, 2022 20:02

Wesley Wigham (weswigham) reviewed Jul 13, 2022
View reviewed changes

Comment threadsrc/compiler/checker.ts Outdated

Give autoType its flags the normal way
dd6bdaf

Wesley Wigham (weswigham) reviewed Jul 13, 2022
View reviewed changes

Jake Bailey (jakebailey) marked this pull request as ready for review July 13, 2022 21:28

Jake Bailey (jakebailey) requested a review from Wesley Wigham (weswigham)July 13, 2022 21:31

Wesley Wigham (weswigham) approved these changes Jul 13, 2022
View reviewed changes

Jake Bailey (jakebailey) added 4 commits July 13, 2022 15:37

Make excludesKind optional in getPropagatingFlagsOfTypes
4a73c1c

Rename test
0972ebd

Add test from fp-ts
28bc9d6

Remove old hack that skipped parameters during inference; this was re…
9e831ec
…lavent when the non-inferrable type was an any

Wesley Wigham (weswigham) approved these changes Jul 14, 2022
View reviewed changes

Jake Bailey (jakebailey) merged commit cf3af3f into microsoft:mainJul 15, 2022

Jake Bailey (jakebailey) deleted the fix-43962 branch July 15, 2022 01:33

Jake Bailey (jakebailey) mentioned this pull request Jul 15, 2022
Clean up inference of type parameters, contravariant types #49915
Merged

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Jul 18, 2022
Crash in narrowing when using for-in #49942
Closed

Mateusz Burzyński (Andarist) mentioned this pull request Sep 8, 2022
TS 4.8 Generics completion is now weaker. #50680
Closed

Jake Bailey (jakebailey) mentioned this pull request Sep 8, 2022
Revert removal of nonInferrableAnyType #50691
Merged

This was referenced Aug 26, 2025
Function argument is not infered correctly #62336
Open
Properly propagate ObjectFlags.NonInferrableType onto non-aliased anonymous object types instantiations #62346
Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Jake Bailey (jakebailey) commented Jul 13, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Wesley Wigham (weswigham)Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey)Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) commented Jul 13, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2022

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2022

fp-ts

dtslint/ts3.5/tsconfig.json

Uh oh!

Jake Bailey (jakebailey) commented Jul 13, 2022

Uh oh!

Jake Bailey (jakebailey) commented Jul 13, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 13, 2022

Compiler

TSServer

Uh oh!

Jake Bailey (jakebailey) commented Jul 14, 2022

Uh oh!

Jake Bailey (jakebailey) commented Jul 14, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2022

Uh oh!

Jake Bailey (jakebailey) commented Jul 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jake Bailey (jakebailey) commented Jul 13, 2022•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 13, 2022•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 13, 2022•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 14, 2022•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 14, 2022•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 14, 2022•
edited
Loading

TypeScript Bot (typescript-bot) commented Jul 14, 2022•
edited
Loading