Skip to content

Defer type comparability check for assertions - #53261

Merged
Gabriela Araujo Britto (gabritto) merged 12 commits into
mainfrom
gabritto/issue52813
Mar 23, 2023
Merged

Defer type comparability check for assertions#53261
Gabriela Araujo Britto (gabritto) merged 12 commits into
mainfrom
gabritto/issue52813

Conversation

@gabritto

@gabrittoGabriela Araujo Britto (gabritto) commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#52813.

This is the fix that is implemented as deferring the type comparability check we do for assertions, and it fixes the circularity case in the original issue.
However, we can still trigger circularity errors when computing variance, as one of the new tests shows, because we can't always defer the check that makes us compute variances.

I'll attempt a different fix next that involves "resetting" the type resolution stack when we start to compute variances.

@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 14, 2023
@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 14, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I'm starting to run the parallelized Definitely Typed test suite on this PR at 46c61b3. Hold tight - I'll update this comment with the log link once the build has been queued.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I'm starting to run the diff-based user code test suite on this PR at 46c61b3. Hold tight - I'll update this comment with the log link once the build has been queued.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I'm starting to run the extended test suite on this PR at 46c61b3. Hold tight - I'll update this comment with the log link once the build has been queued.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I'm starting to run the diff-based top-repos suite on this PR at 46c61b3. Hold tight - I'll update this comment with the log link once the build has been queued.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I'm starting to run the perf test suite on this PR at 46c61b3. Hold tight - I'll update this comment with the log link once the build has been queued.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/53261/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used362,142k (± 0.01%)362,132k (± 0.01%)~362,099k362,181kp=0.470 n=6
Parse Time3.38s (± 0.52%)3.38s (± 0.16%)~3.38s3.39sp=0.508 n=6
Bind Time1.11s (± 0.37%)1.12s (± 0.98%)~1.11s1.14sp=0.100 n=6
Check Time8.63s (± 0.47%)8.66s (± 0.43%)~8.62s8.71sp=0.420 n=6
Emit Time7.40s (± 0.36%)7.43s (± 0.56%)~7.38s7.49sp=0.225 n=6
Total Time20.52s (± 0.27%)20.60s (± 0.35%)~20.51s20.72sp=0.109 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used192,877k (± 1.52%)190,757k (± 0.02%)-2,120k (- 1.10%)190,714k190,797kp=0.005 n=6
Parse Time1.51s (± 0.68%)1.52s (± 1.38%)~1.50s1.55sp=0.263 n=6
Bind Time0.77s (± 0.53%)0.77s (± 0.67%)~0.77s0.78sp=0.114 n=6
Check Time9.43s (± 0.41%)9.39s (± 0.55%)~9.33s9.46sp=0.228 n=6
Emit Time2.73s (± 0.92%)2.79s (± 1.06%)+0.06s (+ 2.32%)2.74s2.82sp=0.012 n=6
Total Time14.43s (± 0.36%)14.47s (± 0.59%)~14.40s14.60sp=0.419 n=6
Monaco - node (v18.10.0, x64)
Memory used347,450k (± 0.01%)347,524k (± 0.01%)+74k (+ 0.02%)347,489k347,543kp=0.008 n=6
Parse Time2.60s (± 0.62%)2.61s (± 0.75%)~2.58s2.64sp=0.676 n=6
Bind Time1.00s (± 0.81%)1.01s (± 1.02%)~1.00s1.03sp=0.070 n=6
Check Time7.07s (± 0.49%)7.10s (± 0.62%)~7.02s7.14sp=0.295 n=6
Emit Time4.23s (± 0.97%)4.25s (± 0.60%)~4.21s4.28sp=0.221 n=6
Total Time14.90s (± 0.50%)14.97s (± 0.34%)~14.90s15.05sp=0.148 n=6
TFS - node (v18.10.0, x64)
Memory used300,806k (± 0.01%)300,802k (± 0.01%)~300,769k300,822kp=0.873 n=6
Parse Time2.06s (± 1.39%)2.07s (± 1.06%)~2.03s2.09sp=0.737 n=6
Bind Time1.13s (± 0.48%)1.14s (± 1.20%)~1.13s1.17sp=0.138 n=6
Check Time6.53s (± 0.55%)6.50s (± 0.58%)~6.43s6.53sp=0.335 n=6
Emit Time3.85s (± 0.54%)3.85s (± 0.75%)~3.81s3.87sp=0.935 n=6
Total Time13.57s (± 0.45%)13.56s (± 0.39%)~13.50s13.63sp=0.810 n=6
material-ui - node (v18.10.0, x64)
Memory used478,385k (± 0.01%)478,374k (± 0.01%)~478,322k478,427kp=0.689 n=6
Parse Time3.04s (± 1.97%)2.96s (± 2.01%)~2.90s3.07sp=0.106 n=6
Bind Time0.94s (± 7.39%)1.03s (± 6.28%)~0.90s1.06sp=0.271 n=6
Check Time17.09s (± 0.46%)17.02s (± 0.65%)~16.89s17.16sp=0.297 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.07s (± 0.35%)21.02s (± 0.61%)~20.87s21.19sp=0.378 n=6
xstate - node (v18.10.0, x64)
Memory used553,201k (± 0.03%)556,483k (± 0.03%)+3,281k (+ 0.59%)556,296k556,723kp=0.005 n=6
Parse Time3.77s (± 0.74%)3.78s (± 0.78%)~3.73s3.81sp=0.419 n=6
Bind Time1.68s (± 1.21%)1.68s (± 0.82%)~1.67s1.70sp=0.871 n=6
Check Time2.77s (± 0.64%)3.13s (± 0.91%)+0.37s (+13.26%)3.10s3.16sp=0.005 n=6
Emit Time0.08s (± 0.00%)0.08s (± 0.00%)~0.08s0.08sp=1.000 n=6
Total Time8.29s (± 0.28%)8.68s (± 0.55%)+0.38s (+ 4.60%)8.59s8.72sp=0.005 n=6
Angular - node (v16.17.1, x64)
Memory used361,458k (± 0.01%)361,427k (± 0.01%)~361,377k361,464kp=0.066 n=6
Parse Time3.51s (± 0.58%)3.51s (± 0.39%)~3.49s3.53sp=0.743 n=6
Bind Time1.18s (± 0.69%)1.18s (± 0.35%)~1.17s1.18sp=0.584 n=6
Check Time9.46s (± 0.54%)9.45s (± 0.22%)~9.42s9.48sp=0.565 n=6
Emit Time7.91s (± 0.80%)7.91s (± 0.39%)~7.88s7.96sp=0.521 n=6
Total Time22.05s (± 0.28%)22.05s (± 0.19%)~22.00s22.13sp=0.572 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used193,215k (± 0.76%)192,505k (± 0.03%)~192,445k192,597kp=0.066 n=6
Parse Time1.57s (± 1.25%)1.57s (± 1.30%)~1.54s1.60sp=0.682 n=6
Bind Time0.82s (± 1.25%)0.82s (± 0.77%)~0.81s0.83sp=0.654 n=6
Check Time10.07s (± 0.39%)10.07s (± 0.43%)~10.01s10.11sp=0.809 n=6
Emit Time2.99s (± 0.52%)3.03s (± 0.98%)+0.04s (+ 1.34%)2.98s3.06sp=0.043 n=6
Total Time15.44s (± 0.26%)15.49s (± 0.39%)~15.41s15.57sp=0.172 n=6
Monaco - node (v16.17.1, x64)
Memory used346,709k (± 0.00%)346,747k (± 0.01%)+39k (+ 0.01%)346,711k346,774kp=0.020 n=6
Parse Time2.72s (± 0.49%)2.72s (± 0.28%)~2.71s2.73sp=1.000 n=6
Bind Time1.09s (± 0.47%)1.09s (± 0.00%)~1.09s1.09sp=0.174 n=6
Check Time7.74s (± 0.28%)7.75s (± 0.43%)~7.70s7.80sp=0.466 n=6
Emit Time4.46s (± 0.52%)4.45s (± 0.66%)~4.41s4.50sp=0.869 n=6
Total Time15.99s (± 0.31%)16.01s (± 0.29%)~15.97s16.09sp=0.331 n=6
TFS - node (v16.17.1, x64)
Memory used300,126k (± 0.01%)300,146k (± 0.01%)~300,107k300,175kp=0.229 n=6
Parse Time2.17s (± 0.69%)2.18s (± 0.84%)~2.16s2.21sp=0.251 n=6
Bind Time1.23s (± 0.80%)1.24s (± 1.02%)~1.22s1.25sp=0.115 n=6
Check Time7.16s (± 0.29%)7.18s (± 0.52%)~7.14s7.24sp=0.332 n=6
Emit Time4.34s (± 0.74%)4.33s (± 0.66%)~4.29s4.37sp=0.629 n=6
Total Time14.89s (± 0.45%)14.93s (± 0.56%)~14.85s15.07sp=0.521 n=6
material-ui - node (v16.17.1, x64)
Memory used477,697k (± 0.01%)477,730k (± 0.01%)~477,675k477,777kp=0.423 n=6
Parse Time3.22s (± 0.32%)3.21s (± 0.70%)~3.17s3.23sp=0.867 n=6
Bind Time0.96s (± 0.57%)0.96s (± 1.44%)~0.94s0.98sp=0.663 n=6
Check Time18.08s (± 0.46%)17.98s (± 0.20%)-0.10s (- 0.55%)17.95s18.05sp=0.019 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.25s (± 0.38%)22.15s (± 0.14%)-0.10s (- 0.44%)22.12s22.21sp=0.010 n=6
xstate - node (v16.17.1, x64)
Memory used550,691k (± 0.02%)553,949k (± 0.01%)+3,258k (+ 0.59%)553,889k554,038kp=0.005 n=6
Parse Time3.94s (± 0.41%)3.95s (± 0.39%)~3.93s3.97sp=0.413 n=6
Bind Time1.80s (± 0.57%)1.79s (± 0.86%)~1.77s1.81sp=0.458 n=6
Check Time3.00s (± 0.49%)3.40s (± 0.34%)+0.40s (+13.34%)3.38s3.41sp=0.005 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time8.83s (± 0.14%)9.23s (± 0.22%)+0.40s (+ 4.51%)9.21s9.26sp=0.005 n=6
Angular - node (v14.15.1, x64)
Memory used355,316k (± 0.00%)355,301k (± 0.01%)~355,276k355,361kp=0.199 n=6
Parse Time3.59s (± 0.41%)3.60s (± 0.38%)~3.57s3.61sp=0.437 n=6
Bind Time1.23s (± 0.61%)1.23s (± 0.61%)~1.22s1.24sp=0.487 n=6
Check Time9.73s (± 0.49%)9.75s (± 0.19%)~9.73s9.78sp=0.334 n=6
Emit Time8.29s (± 0.25%)8.38s (± 1.08%)+0.09s (+ 1.05%)8.27s8.54sp=0.043 n=6
Total Time22.84s (± 0.27%)22.96s (± 0.41%)+0.12s (+ 0.53%)22.84s23.11sp=0.016 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used187,929k (± 0.01%)187,819k (± 0.01%)-110k (- 0.06%)187,802k187,847kp=0.005 n=6
Parse Time1.59s (± 0.26%)1.60s (± 0.39%)+0.01s (+ 0.52%)1.59s1.61sp=0.033 n=6
Bind Time0.84s (± 0.99%)0.84s (± 0.61%)~0.84s0.85sp=0.923 n=6
Check Time10.15s (± 0.52%)10.18s (± 0.60%)~10.08s10.24sp=0.335 n=6
Emit Time3.11s (± 0.60%)3.13s (± 0.78%)~3.10s3.15sp=0.165 n=6
Total Time15.71s (± 0.32%)15.75s (± 0.47%)~15.67s15.83sp=0.377 n=6
Monaco - node (v14.15.1, x64)
Memory used341,684k (± 0.01%)341,687k (± 0.01%)~341,655k341,733kp=0.873 n=6
Parse Time2.82s (± 0.22%)2.83s (± 0.36%)+0.01s (+ 0.47%)2.82s2.85sp=0.028 n=6
Bind Time1.09s (± 0.47%)1.09s (± 0.50%)~1.09s1.10sp=0.640 n=6
Check Time8.12s (± 0.69%)8.16s (± 0.24%)~8.13s8.18sp=0.072 n=6
Emit Time4.66s (± 0.40%)4.66s (± 0.34%)~4.63s4.67sp=0.366 n=6
Total Time16.69s (± 0.45%)16.75s (± 0.22%)~16.70s16.80sp=0.077 n=6
TFS - node (v14.15.1, x64)
Memory used295,230k (± 0.00%)295,261k (± 0.00%)+31k (+ 0.01%)295,252k295,271kp=0.005 n=6
Parse Time2.38s (± 0.35%)2.40s (± 0.59%)+0.02s (+ 1.05%)2.38s2.42sp=0.011 n=6
Bind Time1.06s (± 0.38%)1.07s (± 0.51%)~1.06s1.07sp=0.282 n=6
Check Time7.47s (± 0.41%)7.48s (± 0.41%)~7.43s7.52sp=0.518 n=6
Emit Time4.27s (± 0.77%)4.30s (± 0.93%)~4.27s4.37sp=0.124 n=6
Total Time15.18s (± 0.21%)15.25s (± 0.40%)~15.16s15.32sp=0.052 n=6
material-ui - node (v14.15.1, x64)
Memory used473,296k (± 0.01%)473,281k (± 0.00%)~473,247k473,306kp=0.574 n=6
Parse Time3.33s (± 0.23%)3.34s (± 0.57%)~3.32s3.37sp=0.282 n=6
Bind Time1.00s (± 0.75%)1.00s (± 0.75%)~0.99s1.01sp=1.000 n=6
Check Time18.99s (± 0.49%)19.01s (± 0.60%)~18.84s19.15sp=0.810 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.32s (± 0.40%)23.35s (± 0.47%)~23.19s23.47sp=0.630 n=6
xstate - node (v14.15.1, x64)
Memory used539,308k (± 0.01%)542,544k (± 0.00%)+3,236k (+ 0.60%)542,524k542,587kp=0.005 n=6
Parse Time4.24s (± 0.47%)4.24s (± 0.29%)~4.23s4.26sp=0.806 n=6
Bind Time1.66s (± 0.62%)1.67s (± 0.31%)~1.66s1.67sp=0.437 n=6
Check Time3.16s (± 0.99%)3.54s (± 0.75%)+0.37s (+11.80%)3.51s3.57sp=0.005 n=6
Emit Time0.09s (± 0.00%)0.10s (± 5.76%)~0.09s0.10sp=0.071 n=6
Total Time9.16s (± 0.24%)9.54s (± 0.34%)+0.38s (+ 4.09%)9.50s9.58sp=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

TSServer

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,384ms (± 0.59%)2,388ms (± 0.36%)~2,377ms2,403msp=0.810 n=6
Req 2 - geterr5,321ms (± 0.17%)5,402ms (± 0.42%)+81ms (+ 1.53%)5,378ms5,434msp=0.005 n=6
Req 3 - references336ms (± 1.17%)337ms (± 0.73%)~335ms340msp=0.284 n=6
Req 4 - navto279ms (± 0.27%)277ms (± 0.38%)-3ms (- 0.96%)275ms278msp=0.006 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo81ms (± 3.06%)85ms (± 1.37%)+4ms (+ 4.93%)83ms86msp=0.008 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,523ms (± 1.04%)2,512ms (± 1.01%)~2,470ms2,548msp=0.575 n=6
Req 2 - geterr4,007ms (± 0.75%)3,980ms (± 0.58%)~3,954ms4,013msp=0.173 n=6
Req 3 - references351ms (± 0.51%)345ms (± 0.56%)-6ms (- 1.76%)342ms347msp=0.005 n=6
Req 4 - navto291ms (± 1.42%)291ms (± 0.60%)~288ms292msp=1.000 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo81ms (± 7.91%)71ms (± 3.45%)🟩-10ms (-12.16%)69ms74msp=0.019 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,022ms (± 0.43%)3,036ms (± 0.50%)~3,018ms3,060msp=0.149 n=6
Req 2 - geterr1,597ms (± 0.90%)1,726ms (± 1.13%)+129ms (+ 8.09%)1,703ms1,749msp=0.005 n=6
Req 3 - references107ms (± 1.15%)108ms (± 1.97%)~105ms110msp=0.163 n=6
Req 4 - navto356ms (± 0.59%)354ms (± 0.47%)~351ms356msp=0.098 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo385ms (± 1.25%)385ms (± 1.31%)~378ms390msp=1.000 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,507ms (± 0.44%)2,508ms (± 0.77%)~2,496ms2,545msp=0.470 n=6
Req 2 - geterr5,740ms (± 0.49%)5,788ms (± 0.31%)+49ms (+ 0.85%)5,771ms5,815msp=0.013 n=6
Req 3 - references347ms (± 1.01%)356ms (± 1.38%)+9ms (+ 2.69%)348ms362msp=0.010 n=6
Req 4 - navto278ms (± 0.84%)279ms (± 0.35%)~278ms280msp=0.137 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo73ms (± 0.70%)75ms (± 1.08%)+2ms (+ 2.73%)74ms76msp=0.006 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,672ms (± 0.50%)2,690ms (± 0.99%)~2,672ms2,743msp=0.148 n=6
Req 2 - geterr4,355ms (± 0.42%)4,335ms (± 0.50%)~4,303ms4,352msp=0.128 n=6
Req 3 - references360ms (± 1.68%)363ms (± 0.99%)~360ms370msp=0.228 n=6
Req 4 - navto290ms (± 0.52%)288ms (± 0.47%)~286ms290msp=0.210 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo78ms (± 3.07%)76ms (± 3.46%)~73ms81msp=0.198 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,168ms (± 0.33%)3,164ms (± 0.29%)~3,156ms3,178msp=0.571 n=6
Req 2 - geterr1,752ms (± 0.86%)1,884ms (± 0.90%)+132ms (+ 7.54%)1,868ms1,907msp=0.005 n=6
Req 3 - references117ms (± 1.08%)116ms (± 1.60%)~114ms118msp=0.557 n=6
Req 4 - navto341ms (± 0.64%)340ms (± 0.42%)~338ms342msp=0.462 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo403ms (± 5.19%)391ms (± 0.46%)~388ms393msp=0.053 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,597ms (± 0.36%)2,604ms (± 0.18%)~2,596ms2,608msp=0.229 n=6
Req 2 - geterr6,137ms (± 0.35%)6,277ms (± 1.10%)+140ms (+ 2.28%)6,199ms6,378msp=0.005 n=6
Req 3 - references368ms (± 0.48%)367ms (± 1.59%)~359ms374msp=1.000 n=6
Req 4 - navto280ms (± 0.98%)281ms (± 0.89%)~278ms284msp=0.567 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo101ms (± 2.24%)97ms (± 6.27%)~89ms101msp=0.122 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,810ms (± 0.33%)2,808ms (± 0.24%)~2,802ms2,819msp=0.936 n=6
Req 2 - geterr4,450ms (± 0.49%)4,518ms (± 2.56%)~4,401ms4,646msp=0.936 n=6
Req 3 - references419ms (± 5.16%)387ms (± 6.65%)🟩-32ms (- 7.68%)367ms421msp=0.013 n=6
Req 4 - navto288ms (± 1.45%)288ms (± 0.72%)~285ms290msp=0.451 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo95ms (± 6.37%)91ms (±12.09%)~81ms104msp=0.686 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,443ms (± 0.23%)3,455ms (± 0.52%)~3,439ms3,489msp=0.093 n=6
Req 2 - geterr1,837ms (± 0.81%)1,850ms (± 0.82%)~1,833ms1,870msp=0.378 n=6
Req 3 - references126ms (± 1.12%)125ms (± 2.42%)~122ms130msp=0.167 n=6
Req 4 - navto369ms (± 0.20%)370ms (± 0.68%)~368ms375msp=0.241 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo411ms (± 0.95%)412ms (± 1.30%)~407ms420msp=0.809 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Startup

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time141.08ms (± 0.17%)141.78ms (± 0.23%)+0.69ms (+ 0.49%)140.89ms146.98msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time225.76ms (± 0.13%)227.52ms (± 0.25%)+1.75ms (+ 0.78%)226.24ms236.58msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time227.84ms (± 0.15%)230.80ms (± 0.38%)+2.96ms (+ 1.30%)227.92ms236.39msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time208.69ms (± 0.13%)212.68ms (± 0.33%)+3.98ms (+ 1.91%)208.71ms218.49msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/53261/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 16, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the abridged perf test suite on this PR at 45124b1. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53261

Metricmain53261DeltaBestWorstp-value
Angular - node (v16.17.1, x64)
Memory used361,346k (± 0.01%)361,323k (± 0.01%)~361,296k361,362kp=0.173 n=6
Parse Time3.52s (± 0.36%)3.54s (± 0.65%)~3.51s3.56sp=0.182 n=6
Bind Time1.18s (± 0.44%)1.18s (± 0.44%)~1.18s1.19sp=1.000 n=6
Check Time9.46s (± 0.50%)9.46s (± 0.53%)~9.40s9.54sp=1.000 n=6
Emit Time7.93s (± 0.48%)7.93s (± 0.88%)~7.87s8.04sp=1.000 n=6
Total Time22.09s (± 0.39%)22.12s (± 0.51%)~22.01s22.28sp=1.000 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used192,575k (± 0.02%)192,493k (± 0.04%)~192,406k192,627kp=0.066 n=6
Parse Time1.58s (± 1.41%)1.59s (± 1.42%)~1.55s1.61sp=0.743 n=6
Bind Time0.83s (± 1.01%)0.82s (± 0.63%)~0.82s0.83sp=0.923 n=6
Check Time10.07s (± 0.88%)10.11s (± 0.54%)~10.04s10.19sp=0.296 n=6
Emit Time3.00s (± 0.63%)3.04s (± 1.20%)+0.04s (+ 1.39%)3.01s3.11sp=0.024 n=6
Total Time15.47s (± 0.42%)15.56s (± 0.26%)+0.09s (+ 0.60%)15.49s15.60sp=0.024 n=6
Monaco - node (v16.17.1, x64)
Memory used346,709k (± 0.00%)346,708k (± 0.01%)~346,688k346,739kp=0.630 n=6
Parse Time2.73s (± 0.43%)2.73s (± 0.59%)~2.71s2.75sp=0.805 n=6
Bind Time1.09s (± 0.90%)1.09s (± 0.90%)~1.08s1.11sp=1.000 n=6
Check Time7.74s (± 0.45%)7.73s (± 0.39%)~7.69s7.77sp=0.571 n=6
Emit Time4.46s (± 0.39%)4.44s (± 0.54%)~4.40s4.46sp=0.366 n=6
Total Time16.02s (± 0.38%)15.98s (± 0.33%)~15.92s16.07sp=0.468 n=6
TFS - node (v16.17.1, x64)
Memory used300,137k (± 0.01%)300,151k (± 0.01%)~300,076k300,190kp=0.471 n=6
Parse Time2.17s (± 0.54%)2.17s (± 0.38%)~2.16s2.18sp=0.738 n=6
Bind Time1.24s (± 0.97%)1.24s (± 0.66%)~1.23s1.25sp=1.000 n=6
Check Time7.20s (± 0.38%)7.18s (± 0.47%)~7.15s7.24sp=0.466 n=6
Emit Time4.33s (± 0.68%)4.34s (± 0.60%)~4.30s4.37sp=0.629 n=6
Total Time14.94s (± 0.31%)14.94s (± 0.33%)~14.88s15.02sp=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used477,719k (± 0.02%)477,710k (± 0.00%)~477,691k477,726kp=0.423 n=6
Parse Time3.21s (± 0.38%)3.21s (± 0.61%)~3.19s3.24sp=0.806 n=6
Bind Time0.96s (± 1.02%)0.96s (± 0.43%)~0.95s0.96sp=0.673 n=6
Check Time18.10s (± 0.62%)18.07s (± 0.62%)~17.91s18.22sp=1.000 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.28s (± 0.51%)22.24s (± 0.57%)~22.06s22.41sp=0.748 n=6
xstate - node (v16.17.1, x64)
Memory used550,722k (± 0.02%)553,975k (± 0.02%)+3,253k (+ 0.59%)553,862k554,106kp=0.005 n=6
Parse Time3.94s (± 0.31%)3.96s (± 0.31%)+0.03s (+ 0.72%)3.95s3.98sp=0.018 n=6
Bind Time1.79s (± 0.23%)1.79s (± 0.45%)~1.78s1.80sp=0.584 n=6
Check Time3.05s (± 1.25%)3.39s (± 0.51%)+0.33s (+10.97%)3.37s3.41sp=0.005 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time8.87s (± 0.41%)9.25s (± 0.23%)+0.37s (+ 4.23%)9.22s9.27sp=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Developer Information:

Download Benchmark

@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 16, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the abridged perf test suite on this PR at d409b7f. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53261

Metricmain53261DeltaBestWorstp-value
Angular - node (v16.17.1, x64)
Memory used360,900k (± 0.01%)360,870k (± 0.00%)~360,851k360,890kp=0.173 n=6
Parse Time3.51s (± 0.61%)3.53s (± 0.47%)~3.50s3.55sp=0.249 n=6
Bind Time1.18s (± 0.64%)1.18s (± 0.44%)~1.18s1.19sp=0.784 n=6
Check Time9.46s (± 0.44%)9.43s (± 0.19%)~9.41s9.46sp=0.092 n=6
Emit Time7.93s (± 0.92%)7.89s (± 0.35%)~7.87s7.93sp=0.517 n=6
Total Time22.09s (± 0.37%)22.03s (± 0.21%)~21.96s22.08sp=0.227 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used193,106k (± 0.69%)192,518k (± 0.03%)~192,468k192,624kp=0.173 n=6
Parse Time1.57s (± 1.47%)1.58s (± 0.53%)~1.58s1.60sp=0.114 n=6
Bind Time0.82s (± 0.00%)0.82s (± 0.50%)~0.82s0.83sp=0.405 n=6
Check Time10.04s (± 0.51%)10.29s (± 0.63%)+0.26s (+ 2.56%)10.22s10.39sp=0.005 n=6
Emit Time2.97s (± 0.98%)3.00s (± 1.25%)~2.96s3.07sp=0.196 n=6
Total Time15.40s (± 0.52%)15.70s (± 0.38%)+0.30s (+ 1.98%)15.63s15.80sp=0.005 n=6
Monaco - node (v16.17.1, x64)
Memory used345,435k (± 0.01%)345,587k (± 0.00%)+153k (+ 0.04%)345,563k345,607kp=0.005 n=6
Parse Time2.73s (± 0.50%)2.72s (± 0.43%)~2.71s2.74sp=0.161 n=6
Bind Time1.09s (± 0.75%)1.09s (± 0.58%)~1.08s1.10sp=0.599 n=6
Check Time7.67s (± 0.27%)7.72s (± 0.34%)+0.05s (+ 0.59%)7.68s7.74sp=0.016 n=6
Emit Time4.44s (± 0.74%)4.48s (± 0.58%)~4.44s4.50sp=0.076 n=6
Total Time15.94s (± 0.34%)16.01s (± 0.32%)+0.07s (+ 0.44%)15.94s16.07sp=0.036 n=6
TFS - node (v16.17.1, x64)
Memory used299,780k (± 0.00%)300,015k (± 0.01%)+236k (+ 0.08%)299,987k300,035kp=0.005 n=6
Parse Time2.18s (± 0.75%)2.17s (± 0.54%)~2.15s2.18sp=0.171 n=6
Bind Time1.24s (± 0.41%)1.24s (± 1.10%)~1.22s1.25sp=0.541 n=6
Check Time7.20s (± 0.56%)7.15s (± 0.42%)-0.05s (- 0.74%)7.12s7.20sp=0.035 n=6
Emit Time4.35s (± 0.69%)4.35s (± 0.71%)~4.30s4.38sp=1.000 n=6
Total Time14.97s (± 0.53%)14.91s (± 0.39%)~14.79s14.96sp=0.108 n=6
material-ui - node (v16.17.1, x64)
Memory used477,434k (± 0.01%)477,438k (± 0.01%)~477,337k477,538kp=0.810 n=6
Parse Time3.23s (± 0.32%)3.22s (± 0.36%)~3.20s3.23sp=0.345 n=6
Bind Time0.96s (± 0.54%)0.96s (± 0.54%)~0.95s0.96sp=1.000 n=6
Check Time18.08s (± 0.53%)18.09s (± 0.71%)~17.99s18.29sp=0.873 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.26s (± 0.45%)22.27s (± 0.60%)~22.17s22.47sp=0.810 n=6
xstate - node (v16.17.1, x64)
Memory used550,637k (± 0.01%)550,706k (± 0.01%)~550,630k550,789kp=0.066 n=6
Parse Time3.95s (± 0.34%)3.95s (± 0.25%)~3.94s3.96sp=0.928 n=6
Bind Time1.80s (± 0.50%)1.80s (± 0.82%)~1.78s1.82sp=0.804 n=6
Check Time3.04s (± 1.14%)3.09s (± 0.65%)+0.05s (+ 1.64%)3.07s3.12sp=0.030 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time8.88s (± 0.44%)8.94s (± 0.25%)+0.06s (+ 0.68%)8.92s8.97sp=0.009 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Developer Information:

Download Benchmark

@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 17, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the abridged perf test suite on this PR at 469f24d. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the perf test suite on this PR at 7620056. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 7620056. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 7620056. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 7620056. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/53261/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used361,706k (± 0.01%)361,853k (± 0.01%)+147k (+ 0.04%)361,817k361,884kp=0.005 n=6
Parse Time3.38s (± 0.48%)3.39s (± 0.51%)~3.37s3.41sp=0.673 n=6
Bind Time1.12s (± 0.67%)1.12s (± 0.49%)~1.11s1.12sp=0.137 n=6
Check Time8.66s (± 0.42%)8.71s (± 0.34%)+0.04s (+ 0.50%)8.67s8.73sp=0.043 n=6
Emit Time7.48s (± 0.76%)7.47s (± 0.78%)~7.38s7.54sp=0.936 n=6
Total Time20.64s (± 0.34%)20.68s (± 0.43%)~20.57s20.78sp=0.422 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used193,702k (± 1.57%)0k~0k0kp=1.000 n=6+0
Parse Time1.51s (± 1.00%)0.00s~0.00s0.00sp=1.000 n=6+0
Bind Time0.77s (± 1.42%)0.00s~0.00s0.00sp=1.000 n=6+0
Check Time9.43s (± 0.92%)0.00s~0.00s0.00sp=1.000 n=6+0
Emit Time2.73s (± 0.60%)0.00s~0.00s0.00sp=1.000 n=6+0
Total Time14.44s (± 0.73%)0.00s~0.00s0.00sp=1.000 n=6+0
Monaco - node (v18.10.0, x64)
Memory used346,257k (± 0.01%)346,389k (± 0.01%)+132k (+ 0.04%)346,358k346,411kp=0.005 n=6
Parse Time2.60s (± 0.75%)2.58s (± 0.90%)~2.56s2.62sp=0.103 n=6
Bind Time1.01s (± 0.81%)1.01s (± 0.81%)~1.00s1.02sp=1.000 n=6
Check Time7.07s (± 0.54%)7.05s (± 0.24%)~7.03s7.07sp=0.171 n=6
Emit Time4.25s (± 1.07%)4.25s (± 1.03%)~4.20s4.30sp=1.000 n=6
Total Time14.93s (± 0.55%)14.88s (± 0.51%)~14.78s14.96sp=0.293 n=6
TFS - node (v18.10.0, x64)
Memory used300,462k (± 0.01%)300,529k (± 0.00%)+67k (+ 0.02%)300,510k300,552kp=0.005 n=6
Parse Time2.05s (± 0.57%)2.06s (± 0.84%)~2.03s2.08sp=0.254 n=6
Bind Time1.14s (± 0.90%)1.14s (± 0.71%)~1.14s1.16sp=1.000 n=6
Check Time6.50s (± 0.32%)6.54s (± 0.44%)~6.49s6.57sp=0.053 n=6
Emit Time3.88s (± 1.30%)3.87s (± 0.63%)~3.83s3.89sp=0.871 n=6
Total Time13.56s (± 0.32%)13.60s (± 0.27%)~13.54s13.64sp=0.169 n=6
material-ui - node (v18.10.0, x64)
Memory used477,134k (± 0.01%)477,185k (± 0.01%)~477,160k477,231kp=0.128 n=6
Parse Time3.02s (± 3.20%)3.03s (± 1.38%)~2.96s3.07sp=1.000 n=6
Bind Time0.99s (± 8.59%)0.94s (± 6.92%)~0.90s1.07sp=0.413 n=6
Check Time17.01s (± 0.75%)16.89s (± 0.48%)~16.78s17.00sp=0.107 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.01s (± 0.65%)20.86s (± 0.27%)~20.81s20.96sp=0.065 n=6
xstate - node (v18.10.0, x64)
Memory used552,916k (± 0.01%)552,964k (± 0.03%)~552,801k553,138kp=0.936 n=6
Parse Time3.76s (± 0.58%)3.75s (± 0.45%)~3.73s3.77sp=0.373 n=6
Bind Time1.70s (± 0.30%)1.70s (± 0.44%)~1.69s1.71sp=0.241 n=6
Check Time2.75s (± 1.14%)2.81s (± 0.32%)+0.06s (+ 2.06%)2.80s2.82sp=0.019 n=6
Emit Time0.08s (± 4.99%)0.08s (± 0.00%)~0.08s0.08sp=0.405 n=6
Total Time8.31s (± 0.46%)8.35s (± 0.10%)~8.34s8.36sp=0.115 n=6
Angular - node (v16.17.1, x64)
Memory used361,045k (± 0.01%)361,190k (± 0.01%)+146k (+ 0.04%)361,149k361,248kp=0.005 n=6
Parse Time3.52s (± 0.78%)3.52s (± 0.88%)~3.49s3.56sp=0.809 n=6
Bind Time1.19s (± 0.69%)1.18s (± 0.35%)~1.18s1.19sp=0.248 n=6
Check Time9.47s (± 0.48%)9.53s (± 0.29%)+0.06s (+ 0.62%)9.48s9.56sp=0.036 n=6
Emit Time7.93s (± 0.71%)7.91s (± 0.10%)~7.90s7.92sp=0.625 n=6
Total Time22.11s (± 0.43%)22.14s (± 0.23%)~22.08s22.21sp=0.199 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used193,656k (± 0.92%)0k~0k0kp=1.000 n=6+0
Parse Time1.60s (± 0.56%)0.00s~0.00s0.00sp=1.000 n=6+0
Bind Time0.82s (± 0.63%)0.00s~0.00s0.00sp=1.000 n=6+0
Check Time10.17s (± 0.90%)0.00s~0.00s0.00sp=1.000 n=6+0
Emit Time3.00s (± 1.11%)0.00s~0.00s0.00sp=1.000 n=6+0
Total Time15.59s (± 0.60%)0.00s~0.00s0.00sp=1.000 n=6+0
Monaco - node (v16.17.1, x64)
Memory used345,573k (± 0.00%)345,681k (± 0.01%)+108k (+ 0.03%)345,654k345,697kp=0.005 n=6
Parse Time2.73s (± 0.78%)2.71s (± 0.54%)~2.69s2.73sp=0.104 n=6
Bind Time1.10s (± 1.06%)1.08s (± 0.50%)-0.01s (- 1.21%)1.08s1.09sp=0.025 n=6
Check Time7.71s (± 0.13%)7.71s (± 0.24%)~7.69s7.74sp=0.935 n=6
Emit Time4.47s (± 0.75%)4.45s (± 0.58%)~4.41s4.48sp=0.225 n=6
Total Time16.02s (± 0.19%)15.96s (± 0.36%)~15.88s16.04sp=0.077 n=6
TFS - node (v16.17.1, x64)
Memory used299,785k (± 0.01%)299,884k (± 0.01%)+99k (+ 0.03%)299,843k299,911kp=0.005 n=6
Parse Time2.16s (± 0.54%)2.17s (± 0.35%)~2.16s2.18sp=0.054 n=6
Bind Time1.23s (± 0.66%)1.24s (± 0.98%)~1.22s1.25sp=0.677 n=6
Check Time7.19s (± 0.56%)7.19s (± 0.12%)~7.18s7.20sp=1.000 n=6
Emit Time4.36s (± 1.21%)4.33s (± 0.60%)~4.30s4.37sp=0.466 n=6
Total Time14.94s (± 0.53%)14.93s (± 0.24%)~14.88s14.98sp=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used476,430k (± 0.01%)476,408k (± 0.01%)~476,373k476,469kp=0.229 n=6
Parse Time3.22s (± 0.57%)3.22s (± 0.28%)~3.21s3.23sp=0.806 n=6
Bind Time0.95s (± 0.54%)0.96s (± 0.54%)~0.95s0.96sp=0.311 n=6
Check Time17.93s (± 0.42%)17.98s (± 0.62%)~17.85s18.15sp=0.470 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.10s (± 0.38%)22.16s (± 0.51%)~22.04s22.32sp=0.376 n=6
xstate - node (v16.17.1, x64)
Memory used550,520k (± 0.01%)550,512k (± 0.01%)~550,463k550,572kp=0.936 n=6
Parse Time3.95s (± 0.35%)3.94s (± 0.37%)~3.92s3.95sp=0.465 n=6
Bind Time1.81s (± 0.54%)1.79s (± 0.65%)-0.02s (- 0.92%)1.78s1.81sp=0.036 n=6
Check Time2.99s (± 0.68%)3.04s (± 0.80%)+0.05s (+ 1.62%)3.01s3.08sp=0.010 n=6
Emit Time0.09s (± 0.00%)0.09s (± 4.45%)~0.09s0.10sp=0.405 n=6
Total Time8.83s (± 0.38%)8.86s (± 0.39%)~8.83s8.92sp=0.225 n=6
Angular - node (v14.15.1, x64)
Memory used354,915k (± 0.01%)355,077k (± 0.00%)+161k (+ 0.05%)355,058k355,101kp=0.005 n=6
Parse Time3.61s (± 0.83%)3.61s (± 1.12%)~3.56s3.67sp=0.746 n=6
Bind Time1.24s (± 0.66%)1.24s (± 0.44%)~1.23s1.24sp=0.859 n=6
Check Time9.81s (± 0.47%)9.93s (± 0.37%)+0.12s (+ 1.17%)9.88s9.97sp=0.008 n=6
Emit Time8.39s (± 1.09%)8.36s (± 0.52%)~8.30s8.41sp=0.687 n=6
Total Time23.06s (± 0.58%)23.13s (± 0.18%)~23.06s23.17sp=0.377 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used187,777k (± 0.01%)0k~0k0kp=1.000 n=6+0
Parse Time1.60s (± 0.56%)0.00s~0.00s0.00sp=1.000 n=6+0
Bind Time0.85s (± 1.73%)0.00s~0.00s0.00sp=1.000 n=6+0
Check Time10.28s (± 0.54%)0.00s~0.00s0.00sp=1.000 n=6+0
Emit Time3.13s (± 0.56%)0.00s~0.00s0.00sp=1.000 n=6+0
Total Time15.86s (± 0.36%)0.00s~0.00s0.00sp=1.000 n=6+0
Monaco - node (v14.15.1, x64)
Memory used340,548k (± 0.01%)340,667k (± 0.01%)+119k (+ 0.04%)340,617k340,691kp=0.005 n=6
Parse Time2.83s (± 0.48%)2.84s (± 0.79%)~2.81s2.86sp=0.808 n=6
Bind Time1.10s (± 0.68%)1.11s (± 1.05%)~1.09s1.12sp=0.279 n=6
Check Time8.11s (± 0.26%)8.13s (± 0.71%)~8.02s8.19sp=0.226 n=6
Emit Time4.70s (± 0.58%)4.67s (± 0.65%)~4.64s4.72sp=0.090 n=6
Total Time16.75s (± 0.18%)16.74s (± 0.54%)~16.59s16.84sp=1.000 n=6
TFS - node (v14.15.1, x64)
Memory used294,890k (± 0.00%)294,998k (± 0.00%)+108k (+ 0.04%)294,988k295,009kp=0.005 n=6
Parse Time2.39s (± 0.57%)2.39s (± 0.65%)~2.37s2.41sp=0.805 n=6
Bind Time1.07s (± 0.78%)1.07s (± 0.00%)~1.07s1.07sp=0.121 n=6
Check Time7.54s (± 0.49%)7.53s (± 0.32%)~7.49s7.56sp=0.572 n=6
Emit Time4.28s (± 0.39%)4.34s (± 1.21%)~4.26s4.40sp=0.075 n=6
Total Time15.27s (± 0.40%)15.32s (± 0.32%)~15.25s15.39sp=0.294 n=6
material-ui - node (v14.15.1, x64)
Memory used471,958k (± 0.01%)471,994k (± 0.00%)+36k (+ 0.01%)471,973k472,018kp=0.045 n=6
Parse Time3.36s (± 0.44%)3.35s (± 0.24%)~3.33s3.35sp=0.087 n=6
Bind Time1.00s (± 0.83%)1.00s (± 0.75%)~0.99s1.01sp=0.432 n=6
Check Time18.91s (± 0.49%)18.84s (± 0.62%)~18.74s19.00sp=0.261 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.28s (± 0.34%)23.19s (± 0.49%)~23.09s23.36sp=0.199 n=6
xstate - node (v14.15.1, x64)
Memory used539,126k (± 0.00%)539,194k (± 0.00%)+69k (+ 0.01%)539,151k539,209kp=0.008 n=6
Parse Time4.22s (± 0.49%)4.21s (± 0.68%)~4.19s4.26sp=0.805 n=6
Bind Time1.67s (± 0.31%)1.67s (± 0.63%)~1.65s1.68sp=0.142 n=6
Check Time3.15s (± 0.68%)3.16s (± 0.65%)~3.12s3.18sp=0.517 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time9.13s (± 0.23%)9.13s (± 0.45%)~9.07s9.19sp=0.871 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

TSServer

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,401ms (± 0.61%)2,410ms (± 0.26%)~2,400ms2,417msp=0.294 n=6
Req 2 - geterr5,395ms (± 0.49%)4,719ms (± 0.60%)🟩-677ms (-12.54%)4,685ms4,767msp=0.005 n=6
Req 3 - references337ms (± 0.31%)357ms (± 0.62%)+20ms (+ 5.99%)355ms361msp=0.005 n=6
Req 4 - navto280ms (± 0.54%)280ms (± 0.81%)~276ms282msp=0.616 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo77ms (± 5.63%)79ms (± 3.08%)~74ms81msp=0.253 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,538ms (± 1.04%)2,518ms (± 1.00%)~2,470ms2,536msp=0.423 n=6
Req 2 - geterr4,046ms (± 0.58%)3,584ms (± 0.83%)🟩-462ms (-11.42%)3,557ms3,630msp=0.005 n=6
Req 3 - references351ms (± 0.78%)359ms (± 0.42%)+8ms (+ 2.37%)358ms361msp=0.004 n=6
Req 4 - navto293ms (± 0.97%)287ms (± 0.41%)-6ms (- 2.05%)285ms288msp=0.005 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo76ms (± 6.39%)63ms (± 1.30%)🟩-13ms (-17.54%)62ms64msp=0.005 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,011ms (± 0.43%)3,021ms (± 0.45%)~3,009ms3,047msp=0.689 n=6
Req 2 - geterr1,578ms (± 1.28%)1,678ms (± 1.88%)+100ms (+ 6.35%)1,621ms1,711msp=0.005 n=6
Req 3 - references107ms (± 1.02%)107ms (± 1.09%)~106ms109msp=0.557 n=6
Req 4 - navto355ms (± 0.29%)354ms (± 0.40%)~352ms356msp=0.410 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo394ms (± 4.43%)379ms (± 2.17%)~369ms392msp=0.053 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,498ms (± 0.62%)2,499ms (± 0.55%)~2,483ms2,516msp=0.936 n=6
Req 2 - geterr5,807ms (± 0.53%)5,040ms (± 0.66%)🟩-767ms (-13.21%)5,012ms5,102msp=0.005 n=6
Req 3 - references349ms (± 0.65%)366ms (± 0.56%)+18ms (+ 5.12%)364ms369msp=0.005 n=6
Req 4 - navto279ms (± 1.49%)277ms (± 1.31%)~272ms281msp=0.809 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo75ms (± 0.73%)78ms (± 7.59%)~74ms86msp=0.341 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,682ms (± 0.60%)2,670ms (± 0.45%)~2,654ms2,688msp=0.230 n=6
Req 2 - geterr4,378ms (± 0.41%)3,920ms (± 0.56%)🟩-458ms (-10.45%)3,889ms3,938msp=0.005 n=6
Req 3 - references358ms (± 0.99%)376ms (± 0.76%)+18ms (+ 5.07%)372ms381msp=0.005 n=6
Req 4 - navto290ms (± 0.75%)283ms (± 0.39%)-7ms (- 2.25%)282ms285msp=0.005 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo77ms (± 3.17%)69ms (± 0.92%)🟩-8ms (- 9.80%)68ms70msp=0.004 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,164ms (± 0.60%)3,163ms (± 0.19%)~3,152ms3,170msp=0.471 n=6
Req 2 - geterr1,749ms (± 0.81%)1,823ms (± 1.80%)+74ms (+ 4.22%)1,792ms1,878msp=0.005 n=6
Req 3 - references114ms (± 1.65%)113ms (± 0.87%)~112ms114msp=0.565 n=6
Req 4 - navto340ms (± 0.34%)340ms (± 0.36%)~338ms341msp=0.868 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo395ms (± 0.30%)395ms (± 0.67%)~391ms399msp=0.742 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,603ms (± 0.91%)2,604ms (± 0.74%)~2,583ms2,638msp=0.873 n=6
Req 2 - geterr6,205ms (± 0.29%)5,256ms (± 0.44%)🟩-949ms (-15.29%)5,227ms5,292msp=0.005 n=6
Req 3 - references363ms (± 0.54%)383ms (± 0.77%)+20ms (+ 5.51%)380ms388msp=0.005 n=6
Req 4 - navto277ms (± 0.42%)282ms (± 0.52%)+5ms (+ 1.68%)280ms284msp=0.005 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo102ms (± 0.88%)84ms (± 0.48%)🟩-18ms (-17.48%)84ms85msp=0.003 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,822ms (± 0.71%)2,827ms (± 0.81%)~2,798ms2,868msp=0.936 n=6
Req 2 - geterr4,486ms (± 0.65%)4,036ms (± 0.52%)🟩-450ms (-10.04%)4,003ms4,060msp=0.005 n=6
Req 3 - references410ms (± 6.65%)384ms (± 1.08%)~376ms387msp=0.295 n=6
Req 4 - navto289ms (± 1.06%)291ms (± 0.79%)~289ms294msp=0.292 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo87ms (± 7.44%)81ms (± 8.82%)~76ms95msp=0.294 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,461ms (± 0.49%)3,449ms (± 0.72%)~3,422ms3,496msp=0.520 n=6
Req 2 - geterr1,878ms (± 1.15%)1,878ms (± 0.90%)~1,856ms1,895msp=0.873 n=6
Req 3 - references128ms (± 1.34%)125ms (± 1.40%)-3ms (- 2.21%)124ms128msp=0.034 n=6
Req 4 - navto370ms (± 0.58%)370ms (± 0.54%)~368ms373msp=0.806 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo411ms (± 1.01%)408ms (± 1.01%)~404ms415msp=0.226 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Startup

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time144.56ms (± 0.37%)141.53ms (± 0.18%)-3.02ms (- 2.09%)140.79ms144.29msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time232.00ms (± 0.25%)226.11ms (± 0.19%)-5.89ms (- 2.54%)225.00ms231.04msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time232.96ms (± 0.19%)228.03ms (± 0.16%)-4.93ms (- 2.12%)226.92ms234.80msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time212.98ms (± 0.24%)208.92ms (± 0.16%)-4.06ms (- 1.91%)208.00ms213.18msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/53261/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/53261/merge:

Everything looks good!

@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 21, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 21, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the abridged perf test suite on this PR at fd7d37a. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53261

Metricmain53261DeltaBestWorstp-value
Angular - node (v16.17.1, x64)
Memory used361,406k (± 0.01%)361,432k (± 0.01%)~361,385k361,467kp=0.298 n=6
Parse Time3.54s (± 0.92%)3.52s (± 0.49%)~3.50s3.54sp=0.684 n=6
Bind Time1.18s (± 0.69%)1.18s (± 0.46%)~1.18s1.19sp=0.859 n=6
Check Time9.54s (± 0.64%)9.53s (± 0.17%)~9.52s9.56sp=0.686 n=6
Emit Time7.94s (± 0.52%)7.93s (± 0.22%)~7.90s7.95sp=0.414 n=6
Total Time22.20s (± 0.53%)22.17s (± 0.08%)~22.15s22.19sp=0.466 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used193,117k (± 0.72%)193,041k (± 0.68%)~192,215k195,694kp=0.748 n=6
Parse Time1.59s (± 1.15%)1.59s (± 1.45%)~1.55s1.61sp=0.934 n=6
Bind Time0.83s (± 0.62%)0.82s (± 0.00%)-0.01s (- 0.81%)0.82s0.82sp=0.025 n=6
Check Time10.23s (± 0.61%)10.32s (± 0.50%)~10.25s10.37sp=0.054 n=6
Emit Time3.03s (± 1.29%)3.03s (± 3.76%)~2.96s3.26sp=0.170 n=6
Total Time15.68s (± 0.44%)15.76s (± 0.94%)~15.58s16.02sp=0.336 n=6
Monaco - node (v16.17.1, x64)
Memory used345,571k (± 0.01%)345,717k (± 0.00%)+146k (+ 0.04%)345,702k345,732kp=0.005 n=6
Parse Time2.75s (± 0.93%)2.73s (± 0.57%)~2.72s2.76sp=0.138 n=6
Bind Time1.09s (± 0.58%)1.09s (± 1.00%)~1.08s1.11sp=0.787 n=6
Check Time7.78s (± 0.34%)7.79s (± 0.45%)~7.76s7.85sp=0.290 n=6
Emit Time4.50s (± 0.66%)4.45s (± 0.87%)-0.05s (- 1.19%)4.41s4.52sp=0.044 n=6
Total Time16.11s (± 0.33%)16.06s (± 0.48%)~15.99s16.19sp=0.199 n=6
TFS - node (v16.17.1, x64)
Memory used299,792k (± 0.01%)300,022k (± 0.01%)+230k (+ 0.08%)299,993k300,065kp=0.005 n=6
Parse Time2.18s (± 0.41%)2.18s (± 0.93%)~2.16s2.22sp=0.801 n=6
Bind Time1.23s (± 0.80%)1.24s (± 1.10%)~1.22s1.26sp=0.111 n=6
Check Time7.20s (± 0.77%)7.22s (± 0.45%)~7.18s7.27sp=0.376 n=6
Emit Time4.36s (± 1.02%)4.35s (± 0.40%)~4.32s4.37sp=1.000 n=6
Total Time14.97s (± 0.64%)14.99s (± 0.42%)~14.90s15.09sp=0.572 n=6
material-ui - node (v16.17.1, x64)
Memory used476,432k (± 0.00%)476,428k (± 0.00%)~476,412k476,443kp=0.470 n=6
Parse Time3.22s (± 0.97%)3.21s (± 0.32%)~3.19s3.22sp=0.139 n=6
Bind Time0.96s (± 1.82%)0.96s (± 0.57%)~0.95s0.96sp=0.201 n=6
Check Time18.24s (± 0.66%)18.13s (± 0.18%)~18.09s18.18sp=0.065 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.42s (± 0.59%)22.29s (± 0.14%)-0.13s (- 0.59%)22.25s22.33sp=0.024 n=6
xstate - node (v16.17.1, x64)
Memory used550,623k (± 0.04%)550,542k (± 0.01%)~550,476k550,655kp=0.936 n=6
Parse Time3.95s (± 0.46%)3.94s (± 0.30%)~3.92s3.95sp=0.570 n=6
Bind Time1.80s (± 0.35%)1.79s (± 0.84%)~1.77s1.81sp=0.080 n=6
Check Time3.04s (± 0.54%)3.09s (± 0.39%)+0.05s (+ 1.59%)3.08s3.11sp=0.005 n=6
Emit Time0.09s (± 4.45%)0.09s (± 0.00%)~0.09s0.09sp=0.405 n=6
Total Time8.88s (± 0.31%)8.90s (± 0.22%)~8.87s8.93sp=0.091 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Developer Information:

Download Benchmark

gabritto
Gabriela Araujo Britto (gabritto) commented Mar 22, 2023
View reviewed changes
Comment threadtests/cases/compiler/classVarianceCircularity.ts
@@ -0,0 +1,16 @@
// @strict: true

// Issue #52813

@gabrittoGabriela Araujo Britto (gabritto)Mar 22, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example where this PR's approach doesn't solve the circularity problem.

@weswighamWesley Wigham (weswigham)Mar 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean the other test with the function calls rather than expressions, since that's the one that still has an error. :) If you want, you should file an issue about the other form, so the issue can still get backlog'd, if you want to consider looking into a broader fix in the future after this PR marks the original issue as fixed.

@gabritto
Gabriela Araujo Britto (gabritto) marked this pull request as ready for review March 22, 2023 17:28
@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 22, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Gabriela Araujo Britto (@gabritto), I've started to run the perf test suite on this PR at fd7d37a. You can monitor the build here.

Update: The results are in!

weswigham
Wesley Wigham (weswigham) approved these changes Mar 22, 2023
View reviewed changes

@weswighamWesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small style suggestion to remove some duplication.

Comment threadsrc/compiler/checker.ts Outdated
Comment threadtests/cases/compiler/classVarianceCircularity.ts
@@ -0,0 +1,16 @@
// @strict: true

// Issue #52813

@weswighamWesley Wigham (weswigham)Mar 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean the other test with the function calls rather than expressions, since that's the one that still has an error. :) If you want, you should file an issue about the other form, so the issue can still get backlog'd, if you want to consider looking into a broader fix in the future after this PR marks the original issue as fixed.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used362,087k (± 0.00%)362,080k (± 0.01%)~362,042k362,119kp=0.574 n=6
Parse Time3.38s (± 0.58%)3.39s (± 0.53%)~3.37s3.42sp=0.570 n=6
Bind Time1.12s (± 0.56%)1.12s (± 0.49%)~1.11s1.12sp=0.201 n=6
Check Time8.71s (± 0.47%)8.72s (± 0.33%)~8.68s8.76sp=0.332 n=6
Emit Time7.49s (± 0.56%)7.45s (± 0.28%)~7.41s7.47sp=0.121 n=6
Total Time20.70s (± 0.31%)20.67s (± 0.15%)~20.63s20.71sp=0.334 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used190,945k (± 0.01%)193,654k (± 1.59%)~190,795k196,468kp=1.000 n=6
Parse Time1.50s (± 1.85%)1.50s (± 0.54%)~1.49s1.51sp=0.511 n=6
Bind Time0.76s (± 0.68%)0.77s (± 0.67%)~0.76s0.77sp=0.311 n=6
Check Time9.42s (± 0.42%)9.61s (± 0.59%)+0.19s (+ 2.00%)9.55s9.68sp=0.005 n=6
Emit Time2.73s (± 0.85%)2.73s (± 0.65%)~2.71s2.76sp=0.745 n=6
Total Time14.41s (± 0.43%)14.59s (± 0.37%)+0.18s (+ 1.25%)14.52s14.66sp=0.006 n=6
Monaco - node (v18.10.0, x64)
Memory used346,294k (± 0.01%)346,442k (± 0.01%)+148k (+ 0.04%)346,414k346,470kp=0.005 n=6
Parse Time2.57s (± 0.92%)2.57s (± 0.96%)~2.54s2.60sp=0.936 n=6
Bind Time1.01s (± 0.54%)1.00s (± 0.54%)-0.01s (- 0.99%)1.00s1.01sp=0.024 n=6
Check Time7.05s (± 0.48%)7.11s (± 0.29%)+0.05s (+ 0.76%)7.07s7.13sp=0.012 n=6
Emit Time4.24s (± 1.08%)4.22s (± 0.78%)~4.19s4.27sp=0.467 n=6
Total Time14.88s (± 0.66%)14.90s (± 0.28%)~14.87s14.98sp=0.378 n=6
TFS - node (v18.10.0, x64)
Memory used300,468k (± 0.01%)300,672k (± 0.01%)+205k (+ 0.07%)300,643k300,728kp=0.005 n=6
Parse Time2.06s (± 1.81%)2.06s (± 0.91%)~2.04s2.09sp=0.808 n=6
Bind Time1.14s (± 0.72%)1.13s (± 0.48%)~1.13s1.14sp=0.441 n=6
Check Time6.52s (± 0.47%)6.52s (± 0.53%)~6.49s6.58sp=0.872 n=6
Emit Time3.85s (± 0.75%)3.85s (± 0.69%)~3.82s3.89sp=0.745 n=6
Total Time13.56s (± 0.70%)13.58s (± 0.47%)~13.50s13.65sp=0.628 n=6
material-ui - node (v18.10.0, x64)
Memory used477,166k (± 0.02%)477,097k (± 0.01%)~477,029k477,185kp=0.230 n=6
Parse Time3.02s (± 2.41%)2.98s (± 2.50%)~2.92s3.08sp=0.515 n=6
Bind Time0.96s (± 8.83%)1.01s (± 8.41%)~0.90s1.08sp=0.251 n=6
Check Time17.09s (± 0.36%)17.13s (± 0.69%)~17.05s17.36sp=0.629 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.07s (± 0.30%)21.13s (± 0.67%)~21.02s21.40sp=0.422 n=6
xstate - node (v18.10.0, x64)
Memory used552,847k (± 0.01%)552,911k (± 0.02%)~552,788k553,027kp=0.173 n=6
Parse Time3.78s (± 0.72%)3.78s (± 0.68%)~3.74s3.82sp=0.746 n=6
Bind Time1.71s (± 0.24%)1.70s (± 0.64%)~1.69s1.72sp=0.090 n=6
Check Time2.80s (± 0.83%)2.85s (± 0.53%)+0.04s (+ 1.49%)2.83s2.87sp=0.016 n=6
Emit Time0.08s (± 0.00%)0.08s (± 0.00%)~0.08s0.08sp=1.000 n=6
Total Time8.38s (± 0.46%)8.41s (± 0.33%)~8.37s8.44sp=0.297 n=6
Angular - node (v16.17.1, x64)
Memory used361,424k (± 0.01%)361,410k (± 0.01%)~361,387k361,452kp=0.471 n=6
Parse Time3.55s (± 0.47%)3.55s (± 0.46%)~3.52s3.57sp=0.933 n=6
Bind Time1.18s (± 0.35%)1.18s (± 0.35%)~1.18s1.19sp=1.000 n=6
Check Time9.51s (± 0.30%)9.53s (± 0.35%)~9.48s9.57sp=0.419 n=6
Emit Time7.91s (± 0.55%)7.93s (± 0.59%)~7.86s8.00sp=0.747 n=6
Total Time22.15s (± 0.29%)22.19s (± 0.29%)~22.11s22.28sp=0.295 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used193,696k (± 0.87%)193,143k (± 0.73%)~192,527k196,020kp=0.471 n=6
Parse Time1.58s (± 1.04%)1.58s (± 1.09%)~1.56s1.60sp=0.868 n=6
Bind Time0.82s (± 0.77%)0.82s (± 0.99%)~0.82s0.84sp=0.599 n=6
Check Time10.11s (± 0.53%)10.30s (± 0.65%)+0.19s (+ 1.91%)10.22s10.38sp=0.005 n=6
Emit Time2.98s (± 0.73%)2.98s (± 0.54%)~2.96s3.00sp=0.935 n=6
Total Time15.49s (± 0.33%)15.69s (± 0.34%)+0.20s (+ 1.26%)15.64s15.76sp=0.005 n=6
Monaco - node (v16.17.1, x64)
Memory used345,553k (± 0.01%)345,706k (± 0.01%)+153k (+ 0.04%)345,669k345,732kp=0.005 n=6
Parse Time2.72s (± 0.60%)2.72s (± 0.38%)~2.71s2.74sp=1.000 n=6
Bind Time1.09s (± 1.00%)1.09s (± 0.37%)~1.08s1.09sp=1.000 n=6
Check Time7.77s (± 0.62%)7.80s (± 0.69%)~7.74s7.88sp=0.421 n=6
Emit Time4.47s (± 0.49%)4.44s (± 0.52%)~4.42s4.48sp=0.064 n=6
Total Time16.04s (± 0.43%)16.05s (± 0.36%)~15.98s16.13sp=1.000 n=6
TFS - node (v16.17.1, x64)
Memory used299,811k (± 0.01%)300,032k (± 0.01%)+221k (+ 0.07%)299,999k300,060kp=0.005 n=6
Parse Time2.17s (± 0.63%)2.17s (± 0.61%)~2.15s2.19sp=0.673 n=6
Bind Time1.23s (± 0.68%)1.24s (± 0.94%)~1.22s1.25sp=0.547 n=6
Check Time7.20s (± 0.65%)7.21s (± 0.61%)~7.16s7.28sp=0.517 n=6
Emit Time4.34s (± 0.49%)4.34s (± 0.89%)~4.30s4.41sp=0.520 n=6
Total Time14.95s (± 0.40%)14.96s (± 0.45%)~14.88s15.06sp=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used476,418k (± 0.00%)476,411k (± 0.00%)~476,398k476,428kp=0.471 n=6
Parse Time3.22s (± 0.50%)3.20s (± 1.04%)~3.16s3.23sp=0.317 n=6
Bind Time0.96s (± 0.57%)0.97s (± 2.57%)~0.95s1.01sp=0.138 n=6
Check Time18.14s (± 0.42%)18.12s (± 0.69%)~17.99s18.32sp=0.575 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.31s (± 0.32%)22.28s (± 0.54%)~22.16s22.49sp=0.520 n=6
xstate - node (v16.17.1, x64)
Memory used550,505k (± 0.02%)550,511k (± 0.02%)~550,419k550,754kp=0.936 n=6
Parse Time3.94s (± 0.14%)3.94s (± 0.23%)~3.93s3.95sp=0.342 n=6
Bind Time1.79s (± 1.12%)1.79s (± 0.65%)~1.77s1.80sp=1.000 n=6
Check Time3.02s (± 1.13%)3.10s (± 0.39%)+0.08s (+ 2.54%)3.09s3.12sp=0.005 n=6
Emit Time0.09s (± 0.00%)0.09s (± 4.62%)~0.08s0.09sp=0.405 n=6
Total Time8.83s (± 0.46%)8.91s (± 0.17%)+0.08s (+ 0.91%)8.89s8.93sp=0.005 n=6
Angular - node (v14.15.1, x64)
Memory used355,280k (± 0.01%)355,304k (± 0.00%)~355,297k355,318kp=0.298 n=6
Parse Time3.60s (± 0.58%)3.59s (± 0.48%)~3.56s3.61sp=0.192 n=6
Bind Time1.22s (± 0.42%)1.22s (± 1.09%)~1.20s1.24sp=0.928 n=6
Check Time9.80s (± 0.40%)9.88s (± 0.56%)+0.08s (+ 0.80%)9.83s9.98sp=0.020 n=6
Emit Time8.36s (± 0.26%)8.32s (± 0.54%)~8.28s8.41sp=0.064 n=6
Total Time22.98s (± 0.23%)23.01s (± 0.43%)~22.94s23.20sp=0.686 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used188,308k (± 0.62%)187,806k (± 0.01%)~187,768k187,839kp=0.173 n=6
Parse Time1.60s (± 0.47%)1.61s (± 1.02%)~1.59s1.63sp=0.672 n=6
Bind Time0.84s (± 0.00%)0.85s (± 0.61%)+0.01s (+ 0.79%)0.84s0.85sp=0.025 n=6
Check Time10.23s (± 0.49%)10.42s (± 0.43%)+0.19s (+ 1.86%)10.37s10.47sp=0.005 n=6
Emit Time3.13s (± 0.56%)3.14s (± 0.63%)~3.11s3.17sp=0.317 n=6
Total Time15.79s (± 0.24%)16.01s (± 0.37%)+0.21s (+ 1.35%)15.94s16.09sp=0.005 n=6
Monaco - node (v14.15.1, x64)
Memory used340,530k (± 0.00%)340,615k (± 0.00%)+85k (+ 0.03%)340,602k340,629kp=0.005 n=6
Parse Time2.83s (± 0.37%)2.83s (± 0.48%)~2.81s2.84sp=0.804 n=6
Bind Time1.10s (± 0.94%)1.10s (± 0.68%)~1.09s1.11sp=0.931 n=6
Check Time8.15s (± 0.70%)8.15s (± 0.64%)~8.06s8.22sp=0.415 n=6
Emit Time4.68s (± 0.48%)4.66s (± 0.25%)~4.65s4.68sp=0.195 n=6
Total Time16.75s (± 0.37%)16.74s (± 0.26%)~16.67s16.79sp=1.000 n=6
TFS - node (v14.15.1, x64)
Memory used294,887k (± 0.00%)295,084k (± 0.00%)+197k (+ 0.07%)295,074k295,096kp=0.005 n=6
Parse Time2.40s (± 1.34%)2.39s (± 0.61%)~2.37s2.41sp=0.746 n=6
Bind Time1.07s (± 0.38%)1.07s (± 0.76%)~1.06s1.08sp=0.206 n=6
Check Time7.51s (± 0.34%)7.48s (± 0.45%)~7.42s7.52sp=0.089 n=6
Emit Time4.29s (± 0.68%)4.26s (± 0.89%)~4.20s4.30sp=0.172 n=6
Total Time15.27s (± 0.24%)15.19s (± 0.17%)-0.07s (- 0.49%)15.17s15.24sp=0.012 n=6
material-ui - node (v14.15.1, x64)
Memory used471,963k (± 0.00%)471,978k (± 0.01%)~471,907k472,009kp=0.336 n=6
Parse Time3.34s (± 0.41%)3.36s (± 0.40%)+0.02s (+ 0.65%)3.34s3.38sp=0.027 n=6
Bind Time1.00s (± 0.63%)1.00s (± 0.81%)~0.99s1.01sp=0.432 n=6
Check Time19.17s (± 1.15%)19.04s (± 0.23%)~18.97s19.09sp=0.199 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.51s (± 0.95%)23.40s (± 0.25%)~23.30s23.48sp=0.228 n=6
xstate - node (v14.15.1, x64)
Memory used539,131k (± 0.01%)539,133k (± 0.00%)~539,117k539,141kp=0.471 n=6
Parse Time4.23s (± 0.81%)4.23s (± 0.71%)~4.19s4.27sp=1.000 n=6
Bind Time1.67s (± 0.73%)1.67s (± 0.31%)~1.67s1.68sp=1.000 n=6
Check Time3.18s (± 0.88%)3.20s (± 0.72%)~3.17s3.23sp=0.147 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time9.17s (± 0.34%)9.19s (± 0.51%)~9.13s9.26sp=0.468 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

TSServer

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,390ms (± 0.37%)2,397ms (± 0.49%)~2,382ms2,418msp=0.295 n=6
Req 2 - geterr5,388ms (± 0.69%)5,555ms (± 0.60%)+167ms (+ 3.10%)5,520ms5,607msp=0.005 n=6
Req 3 - references343ms (± 1.13%)337ms (± 0.39%)~335ms338msp=0.050 n=6
Req 4 - navto280ms (± 0.29%)282ms (± 0.30%)+1ms (+ 0.42%)280ms282msp=0.045 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo68ms (± 1.72%)84ms (± 2.43%)+16ms (+23.59%)80ms86msp=0.004 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,520ms (± 1.19%)2,521ms (± 0.48%)~2,507ms2,543msp=1.000 n=6
Req 2 - geterr4,055ms (± 1.03%)4,064ms (± 0.68%)~4,028ms4,104msp=0.630 n=6
Req 3 - references349ms (± 1.59%)348ms (± 1.53%)~342ms355msp=0.571 n=6
Req 4 - navto295ms (± 1.24%)291ms (± 0.40%)-4ms (- 1.30%)289ms292msp=0.016 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo82ms (± 2.82%)81ms (± 5.25%)~76ms87msp=0.747 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,020ms (± 0.80%)3,011ms (± 0.40%)~2,997ms3,026msp=0.810 n=6
Req 2 - geterr1,588ms (± 1.08%)1,684ms (± 1.12%)+96ms (+ 6.07%)1,669ms1,718msp=0.005 n=6
Req 3 - references107ms (± 0.38%)106ms (± 0.49%)~106ms107msp=0.112 n=6
Req 4 - navto354ms (± 0.34%)355ms (± 0.15%)~355ms356msp=0.142 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo387ms (± 0.64%)381ms (± 2.35%)~364ms391msp=0.077 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,511ms (± 0.98%)2,492ms (± 0.37%)~2,482ms2,506msp=0.148 n=6
Req 2 - geterr5,813ms (± 0.46%)5,906ms (± 0.36%)+93ms (+ 1.60%)5,866ms5,926msp=0.005 n=6
Req 3 - references351ms (± 0.50%)345ms (± 0.50%)-6ms (- 1.57%)343ms348msp=0.006 n=6
Req 4 - navto279ms (± 1.48%)279ms (± 0.27%)~278ms280msp=1.000 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo74ms (± 1.01%)74ms (± 1.11%)~73ms75msp=0.306 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,684ms (± 0.71%)2,675ms (± 0.97%)~2,651ms2,722msp=0.471 n=6
Req 2 - geterr4,390ms (± 0.17%)4,429ms (± 0.46%)+38ms (+ 0.87%)4,402ms4,459msp=0.005 n=6
Req 3 - references358ms (± 0.58%)362ms (± 0.84%)~358ms365msp=0.064 n=6
Req 4 - navto291ms (± 0.61%)288ms (± 0.31%)-3ms (- 1.03%)287ms289msp=0.007 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo81ms (± 4.95%)76ms (± 0.68%)~76ms77msp=0.060 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,166ms (± 0.33%)3,167ms (± 0.16%)~3,158ms3,172msp=0.228 n=6
Req 2 - geterr1,769ms (± 1.51%)1,844ms (± 0.88%)+75ms (+ 4.25%)1,827ms1,867msp=0.005 n=6
Req 3 - references116ms (± 1.61%)114ms (± 1.57%)~112ms117msp=0.139 n=6
Req 4 - navto341ms (± 0.36%)343ms (± 0.31%)+2ms (+ 0.54%)341ms344msp=0.033 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo396ms (± 0.67%)402ms (± 5.01%)~390ms442msp=0.573 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,604ms (± 0.75%)2,611ms (± 0.52%)~2,592ms2,628msp=0.689 n=6
Req 2 - geterr6,202ms (± 0.51%)6,305ms (± 0.43%)+103ms (+ 1.67%)6,268ms6,344msp=0.005 n=6
Req 3 - references364ms (± 0.94%)366ms (± 0.73%)~362ms369msp=0.420 n=6
Req 4 - navto279ms (± 0.84%)281ms (± 0.74%)~277ms283msp=0.293 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo100ms (± 4.47%)101ms (± 1.49%)~99ms103msp=0.514 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,826ms (± 0.35%)2,827ms (± 0.48%)~2,815ms2,844msp=0.936 n=6
Req 2 - geterr4,590ms (± 2.55%)4,665ms (± 2.22%)~4,553ms4,787msp=0.065 n=6
Req 3 - references397ms (± 7.08%)397ms (± 6.66%)~371ms426msp=0.936 n=6
Req 4 - navto291ms (± 1.61%)289ms (± 0.22%)~288ms290msp=0.459 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo81ms (± 8.87%)82ms (±10.57%)~74ms93msp=0.678 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,445ms (± 0.27%)3,450ms (± 0.63%)~3,426ms3,481msp=0.689 n=6
Req 2 - geterr1,899ms (± 1.00%)1,888ms (± 1.09%)~1,856ms1,914msp=0.377 n=6
Req 3 - references128ms (± 2.93%)124ms (± 0.94%)~123ms126msp=0.052 n=6
Req 4 - navto371ms (± 0.71%)370ms (± 0.30%)~368ms371msp=1.000 n=6
Req 5 - completionInfo count2,861 (± 0.00%)2,861 (± 0.00%)~2,8612,861p=1.000 n=6
Req 5 - completionInfo408ms (± 0.57%)409ms (± 0.40%)~407ms411msp=0.460 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Startup

Comparison Report - main..53261
Metricmain53261DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time141.76ms (± 0.19%)141.94ms (± 0.16%)+0.18ms (+ 0.13%)141.25ms145.25msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time226.41ms (± 0.18%)227.28ms (± 0.18%)+0.87ms (+ 0.38%)226.48ms236.05msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time228.34ms (± 0.20%)229.13ms (± 0.15%)+0.79ms (+ 0.35%)228.27ms233.85msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time209.12ms (± 0.20%)209.86ms (± 0.17%)+0.74ms (+ 0.35%)209.03ms215.39msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current532616
Baselinemain6

Developer Information:

Download Benchmark

@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 22, 2023

Copy link
Copy Markdown
MemberAuthor

It's kinda unfortunate that there seems to be a slight perf impact on check time, but I don't immediately see what could be done to improve this, since my previous attempts to either defer the call to checkExpression or to use checkExpressionCached led to bad results, so...

@gabritto
Gabriela Araujo Britto (gabritto) deleted the gabritto/issue52813 branch March 23, 2023 18:46
Closed
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Apr 17, 2023
@DanielRosenwasser
Revert "Defer type comparability check for assertions (#53261)"
dd00a34
This reverts commit 8947825.
Closed
Merged
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswighamWesley Wigham (weswigham)weswigham approved these changes

Assignees

@gabrittoGabriela Araujo Britto (gabritto)

Labels

Author: TeamFor Milestone BugPRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent errors reported between tsc and VSCode

3 participants

@gabritto@typescript-bot@weswigham