Revert "Defer type comparability check for assertions" by DanielRosenwasser · Pull Request #53879 · microsoft/TypeScript

Daniel Rosenwasser (DanielRosenwasser) · 2023-04-17T21:53:46Z

Do not merge - experiment to revert #53261

This reverts commit 8947825.

Daniel Rosenwasser (DanielRosenwasser) · 2023-04-17T22:05:42Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2023-04-17T22:05:44Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at dd00a34. You can monitor the build here.

Update: The results are in!

Armando Aguirre (armanio123) · 2023-04-17T23:41:25Z

TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) · 2023-04-17T23:41:27Z

Heya Armando Aguirre (@armanio123), I've started to run the diff-based user code test suite on this PR at dd00a34. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-17T23:53:27Z

Armando Aguirre (@armanio123) Here are the results of running the user test suite comparing main and refs/pull/53879/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-04-18T00:33:04Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53879

_Metric	_main	₅₃₈₇₉	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{365,166k (± 0.01%)}	_{365,176k (± 0.01%)}	_~	_365,149k	_365,210k	_{p=0.575 n=6}
_{Parse Time}	_{3.36s (± 0.88%)}	_{3.37s (± 0.55%)}	_~	_3.34s	_3.39s	_{p=0.569 n=6}
_{Bind Time}	_{1.12s (± 0.46%)}	_{1.12s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=1.000 n=6}
_{Check Time}	_{8.70s (± 0.50%)}	_{8.69s (± 0.55%)}	_~	_8.64s	_8.78s	_{p=0.810 n=6}
_{Emit Time}	_{7.43s (± 0.75%)}	_{7.45s (± 0.91%)}	_~	_7.40s	_7.58s	_{p=1.000 n=6}
_{Total Time}	_{20.61s (± 0.59%)}	_{20.62s (± 0.39%)}	_~	_20.54s	_20.77s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,847k (± 1.18%)}	_{191,805k (± 1.18%)}	_~	_190,778k	_196,414k	_{p=0.689 n=6}
_{Parse Time}	_{1.50s (± 0.56%)}	_{1.51s (± 0.97%)}	_~	_1.49s	_1.53s	_{p=0.094 n=6}
_{Bind Time}	_{0.78s (± 0.71%)}	_{0.77s (± 1.05%)}	_~	_0.76s	_0.78s	_{p=0.859 n=6}
_{Check Time}	_{9.56s (± 0.40%)}	_{9.42s (± 0.38%)}	_{-0.14s (- 1.50%)}	_9.38s	_9.47s	_{p=0.005 n=6}
_{Emit Time}	_{2.72s (± 0.50%)}	_{2.73s (± 0.85%)}	_~	_2.70s	_2.76s	_{p=0.512 n=6}
_{Total Time}	_{14.55s (± 0.23%)}	_{14.43s (± 0.29%)}	_{-0.13s (- 0.86%)}	_14.39s	_14.50s	_{p=0.006 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,470k (± 0.01%)}	_{346,378k (± 0.01%)}	_{-92k (- 0.03%)}	_346,331k	_346,459k	_{p=0.013 n=6}
_{Parse Time}	_{2.59s (± 0.94%)}	_{2.58s (± 0.72%)}	_~	_2.56s	_2.60s	_{p=0.804 n=6}
_{Bind Time}	_{1.01s (± 1.75%)}	_{1.00s (± 0.81%)}	_~	_1.00s	_1.02s	_{p=0.753 n=6}
_{Check Time}	_{7.13s (± 0.60%)}	_{7.08s (± 0.29%)}	_~	_7.06s	_7.11s	_{p=0.052 n=6}
_{Emit Time}	_{4.23s (± 0.70%)}	_{4.23s (± 0.93%)}	_~	_4.19s	_4.29s	_{p=1.000 n=6}
_{Total Time}	_{14.95s (± 0.38%)}	_{14.90s (± 0.22%)}	_~	_14.86s	_14.95s	_{p=0.171 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,719k (± 0.01%)}	_{300,485k (± 0.01%)}	_{-233k (- 0.08%)}	_300,462k	_300,521k	_{p=0.005 n=6}
_{Parse Time}	_{2.05s (± 0.86%)}	_{2.06s (± 1.52%)}	_~	_2.02s	_2.11s	_{p=0.746 n=6}
_{Bind Time}	_{1.14s (± 0.45%)}	_{1.14s (± 1.06%)}	_~	_1.13s	_1.16s	_{p=1.000 n=6}
_{Check Time}	_{6.55s (± 1.02%)}	_{6.49s (± 0.44%)}	_~	_6.46s	_6.54s	_{p=0.075 n=6}
_{Emit Time}	_{3.88s (± 0.68%)}	_{3.89s (± 0.54%)}	_~	_3.86s	_3.91s	_{p=0.460 n=6}
_{Total Time}	_{13.62s (± 0.61%)}	_{13.59s (± 0.59%)}	_~	_13.51s	_13.70s	_{p=0.575 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{481,860k (± 0.01%)}	_{481,846k (± 0.01%)}	_~	_481,815k	_481,894k	_{p=0.689 n=6}
_{Parse Time}	_{3.08s (± 0.61%)}	_{3.10s (± 1.01%)}	_~	_3.06s	_3.15s	_{p=0.225 n=6}
_{Bind Time}	_{0.90s (± 0.83%)}	_{0.90s (± 0.92%)}	_~	_0.90s	_0.92s	_{p=0.652 n=6}
_{Check Time}	_{16.77s (± 0.68%)}	_{16.80s (± 0.43%)}	_~	_16.73s	_16.89s	_{p=0.377 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.76s (± 0.47%)}	_{20.81s (± 0.42%)}	_~	_20.69s	_20.91s	_{p=0.336 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{561,887k (± 0.02%)}	_{561,696k (± 0.01%)}	_{-191k (- 0.03%)}	_561,595k	_561,801k	_{p=0.045 n=6}
_{Parse Time}	_{3.83s (± 0.62%)}	_{3.84s (± 0.77%)}	_~	_3.79s	_3.88s	_{p=0.809 n=6}
_{Bind Time}	_{1.67s (± 0.31%)}	_{1.66s (± 0.59%)}	_~	_1.65s	_1.67s	_{p=0.140 n=6}
_{Check Time}	_{2.82s (± 0.70%)}	_{2.77s (± 1.05%)}	_{-0.04s (- 1.60%)}	_2.74s	_2.81s	_{p=0.029 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.39s (± 0.39%)}	_{8.35s (± 0.60%)}	_~	_8.28s	_8.40s	_{p=0.336 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{364,629k (± 0.01%)}	_{364,623k (± 0.01%)}	_~	_364,567k	_364,654k	_{p=0.936 n=6}
_{Parse Time}	_{3.52s (± 0.39%)}	_{3.53s (± 0.55%)}	_~	_3.50s	_3.55s	_{p=0.681 n=6}
_{Bind Time}	_{1.19s (± 0.43%)}	_{1.18s (± 0.00%)}	_{-0.01s (- 0.56%)}	_1.18s	_1.18s	_{p=0.025 n=6}
_{Check Time}	_{9.53s (± 0.70%)}	_{9.50s (± 0.28%)}	_~	_9.46s	_9.54s	_{p=0.468 n=6}
_{Emit Time}	_{7.95s (± 1.26%)}	_{7.89s (± 0.47%)}	_~	_7.84s	_7.95s	_{p=0.261 n=6}
_{Total Time}	_{22.19s (± 0.60%)}	_{22.10s (± 0.14%)}	_~	_22.06s	_22.14s	_{p=0.108 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,593k (± 0.02%)}	_{192,594k (± 0.04%)}	_~	_192,451k	_192,688k	_{p=0.936 n=6}
_{Parse Time}	_{1.59s (± 1.04%)}	_{1.59s (± 1.40%)}	_~	_1.55s	_1.61s	_{p=0.366 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.83s (± 1.01%)}	_~	_0.82s	_0.84s	_{p=0.176 n=6}
_{Check Time}	_{10.22s (± 0.43%)}	_{10.03s (± 0.79%)}	_{-0.19s (- 1.86%)}	_9.93s	_10.13s	_{p=0.005 n=6}
_{Emit Time}	_{2.99s (± 1.05%)}	_{2.99s (± 0.49%)}	_~	_2.96s	_3.00s	_{p=0.934 n=6}
_{Total Time}	_{15.62s (± 0.35%)}	_{15.44s (± 0.51%)}	_{-0.18s (- 1.17%)}	_15.36s	_15.56s	_{p=0.008 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,777k (± 0.01%)}	_{345,626k (± 0.01%)}	_{-151k (- 0.04%)}	_345,597k	_345,707k	_{p=0.005 n=6}
_{Parse Time}	_{2.72s (± 0.70%)}	_{2.73s (± 0.45%)}	_~	_2.72s	_2.75s	_{p=0.157 n=6}
_{Bind Time}	_{1.08s (± 0.70%)}	_{1.09s (± 0.58%)}	_~	_1.08s	_1.10s	_{p=0.081 n=6}
_{Check Time}	_{7.82s (± 0.46%)}	_{7.76s (± 0.70%)}	_{-0.07s (- 0.87%)}	_7.68s	_7.82s	_{p=0.037 n=6}
_{Emit Time}	_{4.42s (± 0.56%)}	_{4.44s (± 0.72%)}	_~	_4.39s	_4.47s	_{p=0.416 n=6}
_{Total Time}	_{16.05s (± 0.33%)}	_{16.02s (± 0.28%)}	_~	_15.97s	_16.08s	_{p=0.423 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,065k (± 0.01%)}	_{299,825k (± 0.01%)}	_{-240k (- 0.08%)}	_299,789k	_299,880k	_{p=0.005 n=6}
_{Parse Time}	_{2.14s (± 0.19%)}	_{2.16s (± 0.63%)}	_{+0.02s (+ 1.01%)}	_2.14s	_2.18s	_{p=0.016 n=6}
_{Bind Time}	_{1.24s (± 0.83%)}	_{1.24s (± 0.85%)}	_~	_1.22s	_1.25s	_{p=0.241 n=6}
_{Check Time}	_{7.21s (± 0.53%)}	_{7.15s (± 0.45%)}	_~	_7.12s	_7.19s	_{p=0.052 n=6}
_{Emit Time}	_{4.36s (± 0.51%)}	_{4.38s (± 0.67%)}	_~	_4.33s	_4.42s	_{p=0.462 n=6}
_{Total Time}	_{14.95s (± 0.29%)}	_{14.92s (± 0.38%)}	_~	_14.87s	_15.01s	_{p=0.199 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,123k (± 0.01%)}	_{481,111k (± 0.02%)}	_~	_481,065k	_481,261k	_{p=0.689 n=6}
_{Parse Time}	_{3.24s (± 0.52%)}	_{3.26s (± 0.68%)}	_~	_3.23s	_3.30s	_{p=0.139 n=6}
_{Bind Time}	_{0.95s (± 0.43%)}	_{0.95s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.595 n=6}
_{Check Time}	_{17.83s (± 0.22%)}	_{17.82s (± 0.79%)}	_~	_17.65s	_18.03s	_{p=0.873 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.02s (± 0.17%)}	_{22.04s (± 0.64%)}	_~	_21.87s	_22.26s	_{p=0.936 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{559,477k (± 0.03%)}	_{559,387k (± 0.01%)}	_~	_559,271k	_559,504k	_{p=0.298 n=6}
_{Parse Time}	_{3.99s (± 0.35%)}	_{4.00s (± 0.29%)}	_~	_3.99s	_4.02s	_{p=0.105 n=6}
_{Bind Time}	_{1.77s (± 0.59%)}	_{1.78s (± 0.61%)}	_~	_1.77s	_1.80s	_{p=0.554 n=6}
_{Check Time}	_{3.03s (± 0.75%)}	_{2.99s (± 0.46%)}	_{-0.03s (- 0.99%)}	_2.97s	_3.01s	_{p=0.004 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 4.62%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.88s (± 0.36%)}	_{8.87s (± 0.33%)}	_~	_8.83s	_8.92s	_{p=0.374 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{358,569k (± 0.01%)}	_{358,587k (± 0.01%)}	_~	_358,565k	_358,637k	_{p=0.378 n=6}
_{Parse Time}	_{3.64s (± 0.57%)}	_{3.65s (± 0.45%)}	_~	_3.62s	_3.67s	_{p=0.565 n=6}
_{Bind Time}	_{1.22s (± 0.96%)}	_{1.22s (± 0.80%)}	_~	_1.21s	_1.23s	_{p=1.000 n=6}
_{Check Time}	_{9.91s (± 0.22%)}	_{10.00s (± 0.35%)}	_{+0.09s (+ 0.93%)}	_9.96s	_10.05s	_{p=0.005 n=6}
_{Emit Time}	_{8.22s (± 0.85%)}	_{8.37s (± 0.63%)}	_{+0.15s (+ 1.76%)}	_8.30s	_8.44s	_{p=0.013 n=6}
_{Total Time}	_{23.00s (± 0.38%)}	_{23.24s (± 0.27%)}	_{+0.24s (+ 1.05%)}	_23.16s	_23.31s	_{p=0.005 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{187,690k (± 0.01%)}	_{187,629k (± 0.02%)}	_{-61k (- 0.03%)}	_187,560k	_187,690k	_{p=0.020 n=6}
_{Parse Time}	_{1.60s (± 0.47%)}	_{1.60s (± 0.68%)}	_~	_1.59s	_1.62s	_{p=1.000 n=6}
_{Bind Time}	_{0.84s (± 0.65%)}	_{0.85s (± 0.65%)}	_~	_0.84s	_0.85s	_{p=1.000 n=6}
_{Check Time}	_{10.30s (± 0.50%)}	_{10.10s (± 0.30%)}	_{-0.20s (- 1.99%)}	_10.05s	_10.13s	_{p=0.005 n=6}
_{Emit Time}	_{3.44s (± 1.18%)}	_{3.46s (± 0.80%)}	_~	_3.43s	_3.49s	_{p=0.464 n=6}
_{Total Time}	_{16.19s (± 0.50%)}	_{16.01s (± 0.21%)}	_{-0.18s (- 1.14%)}	_15.95s	_16.05s	_{p=0.008 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{340,829k (± 0.00%)}	_{340,794k (± 0.01%)}	_{-35k (- 0.01%)}	_340,750k	_340,816k	_{p=0.008 n=6}
_{Parse Time}	_{2.81s (± 1.30%)}	_{2.80s (± 0.59%)}	_~	_2.78s	_2.83s	_{p=0.625 n=6}
_{Bind Time}	_{1.12s (± 0.75%)}	_{1.11s (± 0.88%)}	_~	_1.10s	_1.13s	_{p=0.445 n=6}
_{Check Time}	_{8.15s (± 0.26%)}	_{8.12s (± 0.39%)}	_~	_8.09s	_8.18s	_{p=0.052 n=6}
_{Emit Time}	_{4.67s (± 1.07%)}	_{4.67s (± 1.15%)}	_~	_4.62s	_4.74s	_{p=0.936 n=6}
_{Total Time}	_{16.74s (± 0.36%)}	_{16.70s (± 0.52%)}	_~	_16.59s	_16.84s	_{p=0.295 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,226k (± 0.00%)}	_{295,034k (± 0.01%)}	_{-193k (- 0.07%)}	_295,006k	_295,053k	_{p=0.005 n=6}
_{Parse Time}	_{2.40s (± 0.78%)}	_{2.39s (± 0.98%)}	_~	_2.36s	_2.42s	_{p=1.000 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.07s (± 0.38%)}	_~	_1.06s	_1.07s	_{p=0.595 n=6}
_{Check Time}	_{7.52s (± 0.63%)}	_{7.56s (± 0.83%)}	_~	_7.49s	_7.64s	_{p=0.335 n=6}
_{Emit Time}	_{4.31s (± 0.50%)}	_{4.29s (± 0.45%)}	_~	_4.27s	_4.32s	_{p=0.256 n=6}
_{Total Time}	_{15.28s (± 0.38%)}	_{15.31s (± 0.50%)}	_~	_15.21s	_15.40s	_{p=0.629 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{476,757k (± 0.00%)}	_{476,728k (± 0.00%)}	_{-29k (- 0.01%)}	_476,704k	_476,741k	_{p=0.031 n=6}
_{Parse Time}	_{3.32s (± 0.33%)}	_{3.32s (± 0.30%)}	_~	_3.31s	_3.34s	_{p=0.718 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.389 n=6}
_{Check Time}	_{18.76s (± 0.63%)}	_{18.67s (± 0.60%)}	_~	_18.52s	_18.86s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.07s (± 0.48%)}	_{22.98s (± 0.49%)}	_~	_22.84s	_23.18s	_{p=0.128 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{548,399k (± 0.00%)}	_{548,435k (± 0.00%)}	_{+37k (+ 0.01%)}	_548,410k	_548,463k	_{p=0.016 n=6}
_{Parse Time}	_{4.21s (± 0.61%)}	_{4.22s (± 0.41%)}	_~	_4.19s	_4.24s	_{p=1.000 n=6}
_{Bind Time}	_{1.67s (± 0.49%)}	_{1.68s (± 0.31%)}	_~	_1.67s	_1.68s	_{p=0.523 n=6}
_{Check Time}	_{3.17s (± 0.95%)}	_{3.14s (± 0.69%)}	_~	_3.11s	_3.17s	_{p=0.086 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.14s (± 0.59%)}	_{9.12s (± 0.33%)}	_~	_9.08s	_9.16s	_{p=0.377 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₈₇₉	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53879

_Metric	_main	₅₃₈₇₉	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,403ms (± 0.30%)}	_{2,420ms (± 0.78%)}	_{+17ms (+ 0.71%)}	_2,403ms	_2,456ms	_{p=0.037 n=6}
_{Req 2 - geterr}	_{5,662ms (± 0.36%)}	_{5,510ms (± 1.15%)}	_{-152ms (- 2.68%)}	_5,382ms	_5,548ms	_{p=0.005 n=6}
_{Req 3 - references}	_{338ms (± 0.49%)}	_{338ms (± 0.41%)}	_~	_335ms	_339ms	_{p=0.869 n=6}
_{Req 4 - navto}	_{285ms (± 0.34%)}	_{289ms (± 1.66%)}	_~	_283ms	_294ms	_{p=0.134 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 0.61%)}	_{83ms (± 5.07%)}	_~	_74ms	_85ms	_{p=0.091 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,515ms (± 0.40%)}	_{2,529ms (± 0.66%)}	_~	_2,510ms	_2,554ms	_{p=0.109 n=6}
_{Req 2 - geterr}	_{4,269ms (± 0.37%)}	_{4,197ms (± 0.37%)}	_{-72ms (- 1.68%)}	_4,178ms	_4,217ms	_{p=0.005 n=6}
_{Req 3 - references}	_{347ms (± 0.80%)}	_{344ms (± 0.87%)}	_~	_341ms	_348ms	_{p=0.148 n=6}
_{Req 4 - navto}	_{289ms (± 0.67%)}	_{293ms (± 0.77%)}	_{+4ms (+ 1.27%)}	_291ms	_297ms	_{p=0.022 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 5.41%)}	_{66ms (± 5.35%)}	_~	_63ms	_70ms	_{p=0.230 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,037ms (± 0.52%)}	_{3,046ms (± 0.38%)}	_~	_3,028ms	_3,057ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{1,610ms (± 0.49%)}	_{1,511ms (± 0.77%)}	_{🟩-100ms (- 6.18%)}	_1,488ms	_1,518ms	_{p=0.005 n=6}
_{Req 3 - references}	_{107ms (± 1.24%)}	_{113ms (± 1.03%)}	_{+6ms (+ 5.93%)}	_112ms	_115ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{362ms (± 0.51%)}	_{360ms (± 0.51%)}	_~	_359ms	_363ms	_{p=0.180 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{371ms (± 1.45%)}	_{375ms (± 2.29%)}	_~	_359ms	_383ms	_{p=0.261 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,529ms (± 0.54%)}	_{2,518ms (± 0.67%)}	_~	_2,499ms	_2,541ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{6,067ms (± 0.42%)}	_{6,002ms (± 0.83%)}	_{-65ms (- 1.07%)}	_5,954ms	_6,067ms	_{p=0.045 n=6}
_{Req 3 - references}	_{352ms (± 0.60%)}	_{355ms (± 0.86%)}	_{+3ms (+ 0.90%)}	_352ms	_361ms	_{p=0.042 n=6}
_{Req 4 - navto}	_{284ms (± 0.77%)}	_{289ms (± 0.57%)}	_{+5ms (+ 1.64%)}	_287ms	_291ms	_{p=0.008 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 5.52%)}	_{72ms (± 0.88%)}	_{🟩-16ms (-18.49%)}	_71ms	_73ms	_{p=0.004 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,696ms (± 0.61%)}	_{2,674ms (± 0.26%)}	_{-22ms (- 0.81%)}	_2,662ms	_2,681ms	_{p=0.013 n=6}
_{Req 2 - geterr}	_{4,624ms (± 0.49%)}	_{4,556ms (± 0.39%)}	_{-68ms (- 1.46%)}	_4,530ms	_4,577ms	_{p=0.005 n=6}
_{Req 3 - references}	_{361ms (± 0.62%)}	_{361ms (± 0.72%)}	_~	_357ms	_364ms	_{p=0.571 n=6}
_{Req 4 - navto}	_{283ms (± 0.43%)}	_{285ms (± 0.78%)}	_~	_281ms	_287ms	_{p=0.089 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 0.00%)}	_{67ms (± 1.63%)}	_{-1ms (- 1.47%)}	_66ms	_69ms	_{p=0.047 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,164ms (± 0.40%)}	_{3,162ms (± 0.68%)}	_~	_3,133ms	_3,193ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,764ms (± 1.13%)}	_{1,690ms (± 1.34%)}	_{🟩-75ms (- 4.22%)}	_1,653ms	_1,712ms	_{p=0.005 n=6}
_{Req 3 - references}	_{119ms (± 1.68%)}	_{121ms (± 1.14%)}	_~	_119ms	_123ms	_{p=0.139 n=6}
_{Req 4 - navto}	_{341ms (± 0.68%)}	_{341ms (± 0.71%)}	_~	_339ms	_346ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{394ms (± 0.86%)}	_{407ms (± 0.46%)}	_{+13ms (+ 3.17%)}	_404ms	_409ms	_{p=0.005 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,619ms (± 0.45%)}	_{2,627ms (± 0.51%)}	_~	_2,614ms	_2,653ms	_{p=0.295 n=6}
_{Req 2 - geterr}	_{6,253ms (± 0.42%)}	_{6,151ms (± 0.49%)}	_{-102ms (- 1.64%)}	_6,100ms	_6,181ms	_{p=0.005 n=6}
_{Req 3 - references}	_{362ms (± 0.83%)}	_{367ms (± 0.58%)}	_{+5ms (+ 1.48%)}	_365ms	_370ms	_{p=0.009 n=6}
_{Req 4 - navto}	_{286ms (± 1.14%)}	_{281ms (± 0.27%)}	_{-6ms (- 1.92%)}	_280ms	_282ms	_{p=0.006 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{98ms (± 5.65%)}	_{104ms (± 0.72%)}	_{+6ms (+ 6.13%)}	_103ms	_105ms	_{p=0.007 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,783ms (± 0.85%)}	_{2,784ms (± 0.57%)}	_~	_2,769ms	_2,809ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,519ms (± 0.39%)}	_{4,464ms (± 0.28%)}	_{-56ms (- 1.23%)}	_4,447ms	_4,480ms	_{p=0.005 n=6}
_{Req 3 - references}	_{372ms (± 0.45%)}	_{381ms (± 0.48%)}	_{+9ms (+ 2.37%)}	_379ms	_384ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{298ms (± 0.25%)}	_{300ms (± 0.54%)}	_{+2ms (+ 0.62%)}	_298ms	_302ms	_{p=0.046 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 1.58%)}	_{77ms (± 1.05%)}	_~	_76ms	_78ms	_{p=0.157 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,399ms (± 1.18%)}	_{3,406ms (± 1.17%)}	_~	_3,349ms	_3,443ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{1,868ms (± 1.41%)}	_{1,858ms (± 1.16%)}	_~	_1,818ms	_1,882ms	_{p=0.378 n=6}
_{Req 3 - references}	_{128ms (± 2.70%)}	_{130ms (± 0.90%)}	_~	_128ms	_131ms	_{p=0.368 n=6}
_{Req 4 - navto}	_{396ms (± 0.64%)}	_{392ms (± 1.40%)}	_~	_386ms	_401ms	_{p=0.158 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{425ms (± 3.08%)}	_{429ms (± 1.89%)}	_~	_416ms	_436ms	_{p=0.520 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₈₇₉	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53879

_Metric	_main	₅₃₈₇₉	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.51ms (± 0.17%)}	_{142.37ms (± 0.20%)}	_{+0.86ms (+ 0.60%)}	_141.43ms	_145.81ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{219.81ms (± 0.17%)}	_{221.25ms (± 0.23%)}	_{+1.44ms (+ 0.65%)}	_219.91ms	_226.94ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{221.86ms (± 0.23%)}	_{222.15ms (± 0.17%)}	_{+0.29ms (+ 0.13%)}	_221.35ms	_229.40ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{203.41ms (± 0.21%)}	_{204.32ms (± 0.21%)}	_{+0.91ms (+ 0.44%)}	_203.19ms	_210.43ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₈₇₉	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Daniel Rosenwasser (DanielRosenwasser) · 2023-05-12T22:36:37Z

Closing in favor of #54224

Revert "Defer type comparability check for assertions (#53261)"
dd00a34
This reverts commit 8947825.

TypeScript Bot (typescript-bot) assigned Daniel Rosenwasser (DanielRosenwasser)Apr 17, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 17, 2023

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request May 12, 2023
Design Meeting Notes, 5/12/2023 #54229
Closed

Daniel Rosenwasser (DanielRosenwasser) closed this Oct 2, 2023

Daniel Rosenwasser (DanielRosenwasser) deleted the revert-53261-gabritto/issue52813 branch October 2, 2023 07:57

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Navigation Menu

Uh oh!

Revert "Defer type comparability check for assertions" - #53879

Revert "Defer type comparability check for assertions"#53879
Daniel Rosenwasser (DanielRosenwasser) wants to merge 1 commit into
mainfrom
revert-53261-gabritto/issue52813

Daniel Rosenwasser (DanielRosenwasser) commented Apr 17, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 17, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 17, 2023•
edited
Loading

Uh oh!

Armando Aguirre (armanio123) commented Apr 17, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 17, 2023•
edited
Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 17, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 18, 2023

Compiler

TSServer

Startup

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Daniel Rosenwasser (DanielRosenwasser) commented Apr 17, 2023

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 17, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Armando Aguirre (armanio123) commented Apr 17, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 17, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 18, 2023

Compiler

TSServer

Startup

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Apr 17, 2023•
edited
Loading

TypeScript Bot (typescript-bot) commented Apr 17, 2023•
edited
Loading