Skip to content

JSX namespace names should not be considered expressions - #54104

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:mainfrom
weswigham:fix-jsx-namespaced-name-index-signature-comparisons
May 9, 2023
Merged

JSX namespace names should not be considered expressions#54104
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:mainfrom
weswigham:fix-jsx-namespaced-name-index-signature-comparisons

Conversation

@weswigham

@weswighamWesley Wigham (weswigham) commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes the regression in this comment, which was regressed by #47356 (and followup #53799), which mistakenly classified JsxNamespacedName nodes as Expressions, which masked a ton of locations where they were effectively unhandled - the relevant location in the case of the regression being getLiteralTypeFromPropertyName, which started returning errorType for all jsx namespace names (which perviously were correctly the a:b string, thanks to the funky identifier we used to use).

As an aside, checkExpressionWorker currently silently returns errorType for all unknown expression types - shouldn't this be a hard Debug.fail calling out the unhandled case? This may have been more obvious had that been the case.

@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 2, 2023
@weswigham

Wesley Wigham (weswigham) commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the diff-based top-repos suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at b22a671. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the perf test suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 2, 2023

Copy link
Copy Markdown
Member

As an aside, checkExpressionWorker currently silently returns errorType for all unknown expression types - shouldn't this be a hard Debug.fail calling out the unhandled case? This may have been more obvious had that been the case.

Good point - let's try that out in a follow-up PR on the top 100.

DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 2, 2023
View reviewed changes

@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but get another review.

Also, might be good to have a test with an index signature like `ns:do-${string}`

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54104
Metricmain54104DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used365,868k (± 0.00%)365,806k (± 0.01%)-62k (- 0.02%)365,762k365,833kp=0.005 n=6
Parse Time3.40s (± 0.85%)3.41s (± 0.97%)~3.37s3.47sp=0.933 n=6
Bind Time1.10s (± 0.94%)1.11s (± 0.73%)~1.10s1.12sp=0.112 n=6
Check Time8.74s (± 0.48%)8.74s (± 0.41%)~8.70s8.79sp=0.744 n=6
Emit Time7.42s (± 0.18%)7.44s (± 0.88%)~7.37s7.52sp=1.000 n=6
Total Time20.65s (± 0.28%)20.69s (± 0.28%)~20.63s20.76sp=0.376 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used190,969k (± 0.01%)191,876k (± 1.21%)~190,912k196,618kp=0.173 n=6
Parse Time1.49s (± 0.27%)1.50s (± 0.50%)+0.01s (+ 0.67%)1.49s1.51sp=0.029 n=6
Bind Time0.77s (± 0.53%)0.78s (± 0.66%)~0.77s0.78sp=0.112 n=6
Check Time9.60s (± 0.46%)9.68s (± 1.06%)~9.55s9.81sp=0.077 n=6
Emit Time2.75s (± 0.96%)2.78s (± 1.46%)~2.75s2.86sp=0.324 n=6
Total Time14.61s (± 0.36%)14.74s (± 0.81%)+0.13s (+ 0.90%)14.57s14.87sp=0.045 n=6
Monaco - node (v18.10.0, x64)
Memory used346,562k (± 0.01%)346,568k (± 0.00%)~346,550k346,582kp=0.471 n=6
Parse Time2.57s (± 0.84%)2.60s (± 0.63%)+0.03s (+ 1.17%)2.59s2.63sp=0.034 n=6
Bind Time1.00s (± 0.75%)1.01s (± 0.75%)~1.00s1.02sp=0.062 n=6
Check Time7.16s (± 0.32%)7.16s (± 0.37%)~7.13s7.20sp=0.936 n=6
Emit Time4.22s (± 0.57%)4.25s (± 0.96%)~4.20s4.30sp=0.374 n=6
Total Time14.96s (± 0.18%)15.02s (± 0.34%)~14.96s15.08sp=0.065 n=6
TFS - node (v18.10.0, x64)
Memory used300,751k (± 0.01%)300,769k (± 0.01%)~300,735k300,793kp=0.297 n=6
Parse Time2.05s (± 0.60%)2.07s (± 0.94%)~2.04s2.09sp=0.216 n=6
Bind Time1.14s (± 0.00%)1.14s (± 0.86%)~1.13s1.15sp=0.652 n=6
Check Time6.63s (± 0.43%)6.61s (± 0.26%)~6.59s6.63sp=0.164 n=6
Emit Time3.88s (± 0.45%)3.86s (± 0.45%)~3.84s3.89sp=0.073 n=6
Total Time13.71s (± 0.27%)13.68s (± 0.22%)~13.64s13.71sp=0.293 n=6
material-ui - node (v18.10.0, x64)
Memory used482,306k (± 0.01%)481,649k (± 0.01%)-657k (- 0.14%)481,612k481,699kp=0.005 n=6
Parse Time3.08s (± 0.48%)3.09s (± 0.39%)~3.07s3.10sp=0.325 n=6
Bind Time0.91s (± 0.60%)0.91s (± 1.13%)~0.90s0.93sp=0.138 n=6
Check Time16.78s (± 0.19%)16.80s (± 0.35%)~16.74s16.89sp=1.000 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time20.77s (± 0.13%)20.80s (± 0.28%)~20.74s20.88sp=0.571 n=6
xstate - node (v18.10.0, x64)
Memory used562,865k (± 0.02%)562,780k (± 0.02%)~562,637k562,897kp=0.230 n=6
Parse Time3.82s (± 0.56%)3.83s (± 0.69%)~3.79s3.86sp=0.257 n=6
Bind Time1.63s (± 0.50%)1.63s (± 0.60%)~1.61s1.64sp=0.546 n=6
Check Time2.80s (± 0.37%)2.81s (± 0.82%)~2.79s2.85sp=0.806 n=6
Emit Time0.08s (± 0.00%)0.08s (± 0.00%)~0.08s0.08sp=1.000 n=6
Total Time8.33s (± 0.42%)8.36s (± 0.59%)~8.28s8.42sp=0.515 n=6
Angular - node (v16.17.1, x64)
Memory used365,271k (± 0.01%)365,158k (± 0.00%)-113k (- 0.03%)365,145k365,170kp=0.005 n=6
Parse Time3.55s (± 0.45%)3.57s (± 0.49%)~3.54s3.59sp=0.195 n=6
Bind Time1.17s (± 0.44%)1.18s (± 0.46%)+0.01s (+ 0.99%)1.18s1.19sp=0.013 n=6
Check Time9.56s (± 0.42%)9.61s (± 0.44%)~9.53s9.66sp=0.075 n=6
Emit Time7.95s (± 0.47%)7.88s (± 0.64%)-0.06s (- 0.78%)7.84s7.98sp=0.044 n=6
Total Time22.23s (± 0.32%)22.24s (± 0.34%)~22.13s22.33sp=0.809 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used192,758k (± 0.05%)192,694k (± 0.05%)~192,621k192,818kp=0.230 n=6
Parse Time1.59s (± 0.62%)1.58s (± 1.63%)~1.54s1.61sp=1.000 n=6
Bind Time0.82s (± 1.09%)0.82s (± 0.66%)~0.82s0.83sp=0.341 n=6
Check Time10.28s (± 0.30%)10.32s (± 0.39%)~10.26s10.36sp=0.077 n=6
Emit Time3.01s (± 0.89%)3.00s (± 1.26%)~2.97s3.07sp=0.625 n=6
Total Time15.69s (± 0.23%)15.73s (± 0.37%)~15.66s15.79sp=0.378 n=6
Monaco - node (v16.17.1, x64)
Memory used345,850k (± 0.00%)345,850k (± 0.01%)~345,818k345,887kp=0.936 n=6
Parse Time2.70s (± 0.19%)2.73s (± 0.43%)+0.02s (+ 0.92%)2.72s2.75sp=0.004 n=6
Bind Time1.08s (± 0.95%)1.08s (± 0.70%)~1.07s1.09sp=0.931 n=6
Check Time7.85s (± 0.42%)7.86s (± 0.53%)~7.83s7.94sp=0.809 n=6
Emit Time4.46s (± 0.66%)4.47s (± 0.66%)~4.42s4.51sp=0.686 n=6
Total Time16.10s (± 0.30%)16.14s (± 0.40%)~16.07s16.23sp=0.199 n=6
TFS - node (v16.17.1, x64)
Memory used300,101k (± 0.00%)300,112k (± 0.01%)~300,084k300,144kp=0.295 n=6
Parse Time2.14s (± 0.35%)2.16s (± 1.05%)+0.02s (+ 1.01%)2.14s2.20sp=0.046 n=6
Bind Time1.23s (± 1.08%)1.24s (± 1.19%)~1.22s1.26sp=0.458 n=6
Check Time7.25s (± 0.38%)7.28s (± 0.51%)~7.22s7.32sp=0.147 n=6
Emit Time4.36s (± 0.69%)4.32s (± 0.32%)-0.04s (- 0.99%)4.30s4.34sp=0.029 n=6
Total Time14.98s (± 0.35%)14.99s (± 0.40%)~14.89s15.07sp=0.573 n=6
material-ui - node (v16.17.1, x64)
Memory used481,596k (± 0.01%)480,890k (± 0.00%)-706k (- 0.15%)480,858k480,907kp=0.005 n=6
Parse Time3.22s (± 0.38%)3.25s (± 0.49%)+0.02s (+ 0.78%)3.23s3.27sp=0.021 n=6
Bind Time0.93s (± 0.44%)0.94s (± 1.04%)+0.01s (+ 1.07%)0.93s0.96sp=0.033 n=6
Check Time17.83s (± 0.45%)17.84s (± 0.78%)~17.61s18.00sp=0.748 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.98s (± 0.37%)22.03s (± 0.72%)~21.78s22.22sp=0.521 n=6
xstate - node (v16.17.1, x64)
Memory used560,325k (± 0.02%)560,439k (± 0.02%)~560,267k560,579kp=0.173 n=6
Parse Time3.97s (± 0.21%)4.01s (± 0.40%)+0.03s (+ 0.84%)3.98s4.02sp=0.008 n=6
Bind Time1.76s (± 0.59%)1.77s (± 0.42%)~1.76s1.78sp=0.155 n=6
Check Time3.06s (± 0.87%)3.07s (± 0.70%)~3.05s3.11sp=0.226 n=6
Emit Time0.09s (± 4.62%)0.09s (± 0.00%)~0.09s0.09sp=0.405 n=6
Total Time8.88s (± 0.38%)8.94s (± 0.40%)+0.06s (+ 0.66%)8.88s8.99sp=0.025 n=6
Angular - node (v14.21.3, x64)
Memory used359,297k (± 0.01%)359,179k (± 0.01%)-118k (- 0.03%)359,143k359,219kp=0.005 n=6
Parse Time3.65s (± 0.62%)3.69s (± 0.70%)+0.04s (+ 1.10%)3.65s3.71sp=0.029 n=6
Bind Time1.21s (± 0.74%)1.22s (± 0.33%)~1.21s1.22sp=0.086 n=6
Check Time9.96s (± 0.46%)9.97s (± 0.31%)~9.95s10.03sp=0.746 n=6
Emit Time8.25s (± 0.47%)8.28s (± 0.45%)~8.24s8.32sp=0.408 n=6
Total Time23.07s (± 0.22%)23.15s (± 0.21%)+0.08s (+ 0.33%)23.07s23.20sp=0.045 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used188,089k (± 0.01%)188,019k (± 0.01%)-70k (- 0.04%)187,979k188,066kp=0.008 n=6
Parse Time1.59s (± 0.86%)1.61s (± 0.55%)~1.60s1.62sp=0.084 n=6
Bind Time0.84s (± 0.48%)0.85s (± 0.00%)+0.01s (+ 0.99%)0.85s0.85sp=0.007 n=6
Check Time10.37s (± 0.79%)10.46s (± 0.36%)+0.10s (+ 0.93%)10.39s10.49sp=0.016 n=6
Emit Time3.14s (± 0.69%)3.13s (± 0.69%)~3.10s3.16sp=0.226 n=6
Total Time15.95s (± 0.54%)16.05s (± 0.24%)+0.10s (+ 0.63%)15.98s16.09sp=0.030 n=6
Monaco - node (v14.21.3, x64)
Memory used340,959k (± 0.01%)340,963k (± 0.01%)~340,947k340,996kp=0.936 n=6
Parse Time2.80s (± 0.80%)2.80s (± 0.47%)~2.78s2.81sp=0.797 n=6
Bind Time1.11s (± 1.19%)1.11s (± 0.80%)~1.10s1.12sp=0.932 n=6
Check Time8.15s (± 0.26%)8.17s (± 0.55%)~8.13s8.25sp=0.421 n=6
Emit Time4.70s (± 0.86%)4.67s (± 0.57%)~4.65s4.72sp=0.290 n=6
Total Time16.76s (± 0.36%)16.76s (± 0.42%)~16.70s16.88sp=0.809 n=6
TFS - node (v14.21.3, x64)
Memory used295,286k (± 0.00%)295,289k (± 0.00%)~295,283k295,298kp=0.630 n=6
Parse Time2.39s (± 0.57%)2.39s (± 0.99%)~2.36s2.42sp=0.935 n=6
Bind Time1.06s (± 0.00%)1.07s (± 0.51%)~1.06s1.07sp=0.071 n=6
Check Time7.58s (± 0.44%)7.57s (± 0.42%)~7.54s7.63sp=0.809 n=6
Emit Time4.34s (± 0.40%)4.32s (± 0.68%)~4.28s4.36sp=0.168 n=6
Total Time15.37s (± 0.37%)15.34s (± 0.33%)~15.30s15.43sp=0.170 n=6
material-ui - node (v14.21.3, x64)
Memory used477,182k (± 0.01%)476,517k (± 0.01%)-665k (- 0.14%)476,475k476,553kp=0.005 n=6
Parse Time3.32s (± 0.27%)3.32s (± 0.65%)~3.30s3.36sp=0.198 n=6
Bind Time1.00s (± 0.63%)1.00s (± 0.75%)~0.99s1.01sp=0.718 n=6
Check Time18.78s (± 0.46%)18.73s (± 0.43%)~18.60s18.80sp=0.520 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.10s (± 0.35%)23.05s (± 0.42%)~22.90s23.17sp=0.421 n=6
xstate - node (v14.21.3, x64)
Memory used549,327k (± 0.00%)549,323k (± 0.00%)~549,313k549,343kp=1.000 n=6
Parse Time4.19s (± 0.51%)4.23s (± 1.00%)+0.04s (+ 0.95%)4.20s4.31sp=0.043 n=6
Bind Time1.65s (± 2.50%)1.64s (± 4.06%)~1.54s1.69sp=0.459 n=6
Check Time3.18s (± 0.86%)3.17s (± 0.58%)~3.15s3.20sp=1.000 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time9.11s (± 0.71%)9.13s (± 0.49%)~9.07s9.19sp=0.575 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
BenchmarkNameIterations
Current541046
Baselinemain6

TSServer

Comparison Report - main..54104
Metricmain54104DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,528ms (± 0.40%)2,545ms (± 0.88%)~2,520ms2,583msp=0.199 n=6
Req 2 - geterr5,705ms (± 0.44%)5,681ms (± 1.81%)~5,481ms5,771msp=1.000 n=6
Req 3 - references341ms (± 0.39%)337ms (± 0.52%)-5ms (- 1.32%)334ms339msp=0.006 n=6
Req 4 - navto283ms (± 1.24%)286ms (± 0.95%)+3ms (+ 1.00%)283ms291msp=0.040 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo85ms (± 1.05%)84ms (± 5.60%)~74ms86msp=0.932 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,642ms (± 0.41%)2,654ms (± 0.69%)~2,620ms2,672msp=0.128 n=6
Req 2 - geterr4,336ms (± 0.29%)4,353ms (± 0.58%)~4,314ms4,375msp=0.173 n=6
Req 3 - references349ms (± 0.94%)352ms (± 1.20%)~349ms360msp=0.167 n=6
Req 4 - navto290ms (± 0.65%)293ms (± 0.63%)+4ms (+ 1.32%)291ms295msp=0.015 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo63ms (± 2.34%)63ms (± 1.30%)~62ms64msp=1.000 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,059ms (± 0.65%)3,078ms (± 0.55%)~3,054ms3,101msp=0.173 n=6
Req 2 - geterr1,597ms (± 1.15%)1,602ms (± 1.25%)~1,579ms1,632msp=0.689 n=6
Req 3 - references108ms (± 2.70%)107ms (± 0.84%)~106ms108msp=0.683 n=6
Req 4 - navto362ms (± 0.23%)365ms (± 0.50%)+4ms (+ 0.97%)362ms367msp=0.010 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo373ms (± 0.99%)378ms (± 2.13%)~366ms388msp=0.298 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,655ms (± 0.70%)2,685ms (± 0.43%)+30ms (+ 1.12%)2,673ms2,700msp=0.013 n=6
Req 2 - geterr6,147ms (± 0.41%)6,160ms (± 0.34%)~6,129ms6,182msp=0.298 n=6
Req 3 - references353ms (± 0.58%)349ms (± 0.90%)~345ms354msp=0.064 n=6
Req 4 - navto283ms (± 0.27%)286ms (± 0.38%)+3ms (+ 1.00%)285ms287msp=0.004 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo85ms (± 7.50%)85ms (± 6.97%)~81ms93msp=0.562 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,809ms (± 0.49%)2,839ms (± 1.04%)~2,791ms2,871msp=0.092 n=6
Req 2 - geterr4,703ms (± 0.39%)4,718ms (± 0.49%)~4,679ms4,750msp=0.230 n=6
Req 3 - references363ms (± 0.54%)364ms (± 0.59%)~361ms367msp=0.418 n=6
Req 4 - navto285ms (± 0.76%)286ms (± 0.41%)~285ms288msp=0.251 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo67ms (± 0.61%)67ms (± 1.12%)~66ms68msp=0.389 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,193ms (± 0.32%)3,208ms (± 0.34%)~3,198ms3,228msp=0.053 n=6
Req 2 - geterr1,736ms (± 0.34%)1,750ms (± 0.73%)+14ms (+ 0.83%)1,737ms1,774msp=0.024 n=6
Req 3 - references123ms (± 1.26%)127ms (± 7.22%)~122ms146msp=0.357 n=6
Req 4 - navto341ms (± 1.26%)344ms (± 0.66%)~341ms347msp=0.172 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo402ms (± 1.41%)405ms (± 1.99%)~399ms418msp=0.810 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen2,779ms (± 0.65%)2,790ms (± 0.63%)~2,764ms2,813msp=0.297 n=6
Req 2 - geterr6,332ms (± 0.68%)6,337ms (± 0.83%)~6,243ms6,375msp=0.936 n=6
Req 3 - references368ms (± 0.84%)362ms (± 1.51%)~354ms369msp=0.092 n=6
Req 4 - navto291ms (± 0.84%)294ms (± 0.73%)+4ms (+ 1.26%)292ms298msp=0.036 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo99ms (± 5.66%)96ms (± 7.92%)~85ms104msp=0.517 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen2,953ms (± 0.50%)2,982ms (± 0.40%)+28ms (+ 0.96%)2,964ms2,998msp=0.013 n=6
Req 2 - geterr4,550ms (± 0.65%)4,577ms (± 0.30%)~4,557ms4,590msp=0.173 n=6
Req 3 - references376ms (± 0.78%)379ms (± 1.05%)~374ms384msp=0.145 n=6
Req 4 - navto297ms (± 0.27%)301ms (± 0.54%)+3ms (+ 1.12%)298ms302msp=0.008 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo77ms (± 0.98%)77ms (± 0.67%)~76ms77msp=0.784 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen3,473ms (± 1.26%)3,469ms (± 0.93%)~3,408ms3,502msp=0.471 n=6
Req 2 - geterr1,848ms (± 0.31%)1,844ms (± 0.17%)~1,842ms1,849msp=0.220 n=6
Req 3 - references150ms (± 8.54%)149ms (± 8.03%)~138ms163msp=0.630 n=6
Req 4 - navto394ms (± 1.66%)396ms (± 1.53%)~388ms402msp=0.686 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo428ms (± 2.08%)428ms (± 1.75%)~418ms436msp=0.936 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
BenchmarkNameIterations
Current541046
Baselinemain6

Startup

Comparison Report - main..54104
Metricmain54104DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time140.67ms (± 0.19%)141.72ms (± 0.19%)+1.06ms (+ 0.75%)140.72ms145.30msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time219.19ms (± 0.16%)220.43ms (± 0.16%)+1.24ms (+ 0.57%)219.37ms225.81msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time220.93ms (± 0.18%)221.90ms (± 0.17%)+0.97ms (+ 0.44%)220.89ms226.09msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time202.79ms (± 0.17%)203.63ms (± 0.20%)+0.85ms (+ 0.42%)202.77ms211.04msp=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current541046
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham) Here are the results of running the top-repos suite comparing main and refs/pull/54104/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@andrewbranch

Andrew Branch (andrewbranch) commented May 2, 2023

Copy link
Copy Markdown
Member

Perf run almost looks like this is visible in parse time, but it’s pretty noisy, and the only real addition is a isJsxNamespacedName(initialExpression) call 🤔

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 2, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the abridged perf test suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 2, 2023

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54104

Metricmain54104DeltaBestWorstp-value
Angular - node (v16.17.1, x64)
Memory used365,293k (± 0.01%)365,173k (± 0.01%)-121k (- 0.03%)365,152k365,233kp=0.005 n=6
Parse Time3.55s (± 0.55%)3.57s (± 0.33%)~3.56s3.59sp=0.052 n=6
Bind Time1.17s (± 0.54%)1.17s (± 0.47%)~1.17s1.18sp=0.201 n=6
Check Time9.53s (± 0.25%)9.57s (± 0.57%)~9.51s9.66sp=0.229 n=6
Emit Time7.89s (± 0.38%)7.92s (± 0.84%)~7.83s8.00sp=0.575 n=6
Total Time22.15s (± 0.19%)22.25s (± 0.45%)~22.12s22.41sp=0.054 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used192,754k (± 0.03%)192,708k (± 0.02%)~192,685k192,759kp=0.199 n=6
Parse Time1.59s (± 0.95%)1.60s (± 0.79%)~1.59s1.62sp=0.210 n=6
Bind Time0.82s (± 0.00%)0.83s (± 0.49%)+0.01s (+ 1.02%)0.82s0.83sp=0.007 n=6
Check Time10.29s (± 0.63%)10.34s (± 0.28%)~10.29s10.36sp=0.227 n=6
Emit Time3.01s (± 0.84%)3.01s (± 0.78%)~2.99s3.05sp=0.747 n=6
Total Time15.71s (± 0.30%)15.78s (± 0.16%)+0.07s (+ 0.47%)15.75s15.81sp=0.019 n=6
Monaco - node (v16.17.1, x64)
Memory used345,852k (± 0.01%)345,853k (± 0.00%)~345,829k345,864kp=0.936 n=6
Parse Time2.72s (± 0.61%)2.73s (± 0.28%)~2.72s2.74sp=0.367 n=6
Bind Time1.09s (± 0.75%)1.09s (± 0.50%)~1.08s1.09sp=0.859 n=6
Check Time7.85s (± 0.33%)7.88s (± 0.58%)~7.82s7.94sp=0.333 n=6
Emit Time4.47s (± 0.80%)4.51s (± 0.88%)~4.47s4.57sp=0.227 n=6
Total Time16.13s (± 0.31%)16.20s (± 0.49%)~16.09s16.30sp=0.127 n=6
TFS - node (v16.17.1, x64)
Memory used300,115k (± 0.01%)300,111k (± 0.01%)~300,075k300,145kp=0.873 n=6
Parse Time2.14s (± 0.35%)2.15s (± 0.56%)~2.13s2.16sp=0.502 n=6
Bind Time1.24s (± 1.10%)1.24s (± 1.66%)~1.22s1.28sp=0.622 n=6
Check Time7.27s (± 0.51%)7.28s (± 0.59%)~7.24s7.35sp=0.872 n=6
Emit Time4.38s (± 0.51%)4.29s (± 0.70%)-0.09s (- 2.06%)4.25s4.32sp=0.005 n=6
Total Time15.02s (± 0.40%)14.95s (± 0.46%)~14.88s15.06sp=0.109 n=6
material-ui - node (v16.17.1, x64)
Memory used481,621k (± 0.02%)480,897k (± 0.01%)-724k (- 0.15%)480,841k480,935kp=0.005 n=6
Parse Time3.23s (± 0.60%)3.24s (± 0.57%)~3.22s3.27sp=0.327 n=6
Bind Time0.93s (± 0.55%)0.94s (± 0.00%)+0.01s (+ 0.71%)0.94s0.94sp=0.025 n=6
Check Time17.83s (± 0.47%)17.78s (± 0.40%)~17.72s17.87sp=0.260 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time21.99s (± 0.34%)21.95s (± 0.32%)~21.90s22.06sp=0.377 n=6
xstate - node (v16.17.1, x64)
Memory used560,357k (± 0.01%)560,423k (± 0.02%)~560,284k560,559kp=0.230 n=6
Parse Time3.97s (± 0.21%)3.99s (± 0.19%)+0.02s (+ 0.46%)3.98s4.00sp=0.006 n=6
Bind Time1.75s (± 0.31%)1.77s (± 0.91%)~1.75s1.79sp=0.154 n=6
Check Time3.05s (± 0.73%)3.06s (± 1.06%)~3.02s3.11sp=0.686 n=6
Emit Time0.09s (± 0.00%)0.09s (± 0.00%)~0.09s0.09sp=1.000 n=6
Total Time8.88s (± 0.29%)8.90s (± 0.51%)~8.84s8.95sp=0.422 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
BenchmarkNameIterations
Current541046
Baselinemain6

Developer Information:

Download Benchmark

@weswighamWesley Wigham (weswigham) mentioned this pull request May 3, 2023
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)DanielRosenwasser approved these changes
@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes
@andrewbranchAndrew Branch (andrewbranch)Awaiting requested review from andrewbranch
@rbucktonRon Buckton (rbuckton)Awaiting requested review from rbuckton

Assignees

@weswighamWesley Wigham (weswigham)

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weswigham@typescript-bot@DanielRosenwasser@andrewbranch@jakebailey