Skip to content

Replace errorType return with Debug fail in checkExpressionWorker - #54117

Closed
Wesley Wigham (weswigham) wants to merge 4 commits into
microsoft:mainfrom
weswigham:cew-debug-fail
Closed

Replace errorType return with Debug fail in checkExpressionWorker#54117
Wesley Wigham (weswigham) wants to merge 4 commits into
microsoft:mainfrom
weswigham:cew-debug-fail

Conversation

@weswigham

@weswighamWesley Wigham (weswigham) commented May 3, 2023

Copy link
Copy Markdown
Member

Per my suggestion and this comment.

@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 3, 2023
@weswigham

Wesley Wigham (weswigham) commented May 3, 2023

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the diff-based top-repos suite on this PR at 7dfe497. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at 7dfe497. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at 7dfe497. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the perf test suite on this PR at 7dfe497. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54117
Metricmain54117DeltaBestWorstp-value
Angular - node (v18.10.0, x64)
Memory used365,852k (± 0.01%)365,887k (± 0.01%)~365,866k365,912kp=0.066 n=6
Parse Time3.39s (± 0.66%)3.41s (± 0.90%)~3.36s3.44sp=0.259 n=6
Bind Time1.11s (± 0.73%)1.11s (± 0.46%)~1.11s1.12sp=0.752 n=6
Check Time8.73s (± 0.25%)8.75s (± 0.66%)~8.68s8.83sp=0.807 n=6
Emit Time7.44s (± 0.70%)7.44s (± 0.65%)~7.39s7.53sp=0.935 n=6
Total Time20.67s (± 0.28%)20.71s (± 0.52%)~20.57s20.89sp=0.628 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used190,960k (± 0.02%)191,958k (± 1.20%)~190,951k196,669kp=0.065 n=6
Parse Time1.49s (± 0.69%)1.50s (± 0.70%)~1.49s1.52sp=0.098 n=6
Bind Time0.77s (± 0.97%)0.77s (± 1.05%)~0.76s0.78sp=0.729 n=6
Check Time9.60s (± 0.33%)9.64s (± 0.56%)~9.56s9.71sp=0.296 n=6
Emit Time2.77s (± 1.19%)2.77s (± 0.37%)~2.75s2.78sp=0.805 n=6
Total Time14.64s (± 0.32%)14.68s (± 0.35%)~14.62s14.75sp=0.199 n=6
Monaco - node (v18.10.0, x64)
Memory used346,572k (± 0.01%)346,564k (± 0.01%)~346,537k346,594kp=0.936 n=6
Parse Time2.58s (± 0.41%)2.58s (± 1.05%)~2.55s2.62sp=0.935 n=6
Bind Time1.01s (± 1.15%)1.00s (± 1.36%)~0.99s1.02sp=0.284 n=6
Check Time7.18s (± 0.43%)7.16s (± 0.30%)~7.13s7.19sp=0.629 n=6
Emit Time4.28s (± 1.44%)4.29s (± 0.74%)~4.25s4.34sp=0.630 n=6
Total Time15.05s (± 0.55%)15.03s (± 0.45%)~14.95s15.12sp=0.872 n=6
TFS - node (v18.10.0, x64)
Memory used300,772k (± 0.01%)300,750k (± 0.00%)~300,730k300,765kp=0.128 n=6
Parse Time2.06s (± 1.37%)2.05s (± 1.15%)~2.01s2.08sp=0.803 n=6
Bind Time1.14s (± 0.72%)1.14s (± 0.96%)~1.12s1.15sp=0.448 n=6
Check Time6.61s (± 0.54%)6.64s (± 0.57%)~6.57s6.67sp=0.226 n=6
Emit Time3.90s (± 0.73%)3.90s (± 0.94%)~3.85s3.95sp=0.936 n=6
Total Time13.71s (± 0.29%)13.73s (± 0.65%)~13.63s13.85sp=0.810 n=6
material-ui - node (v18.10.0, x64)
Memory used482,306k (± 0.01%)482,327k (± 0.01%)~482,269k482,407kp=0.689 n=6
Parse Time3.10s (± 0.63%)3.09s (± 0.72%)~3.05s3.11sp=0.933 n=6
Bind Time0.90s (± 0.83%)0.91s (± 1.08%)~0.90s0.92sp=0.109 n=6
Check Time16.79s (± 0.35%)16.86s (± 0.25%)~16.81s16.93sp=0.126 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time20.80s (± 0.26%)20.86s (± 0.24%)~20.82s20.96sp=0.169 n=6
xstate - node (v18.10.0, x64)
Memory used562,763k (± 0.02%)562,838k (± 0.02%)~562,646k562,975kp=0.378 n=6
Parse Time3.83s (± 0.53%)3.83s (± 0.76%)~3.79s3.87sp=1.000 n=6
Bind Time1.62s (± 0.91%)1.63s (± 0.33%)~1.63s1.64sp=0.054 n=6
Check Time2.81s (± 0.49%)2.80s (± 0.67%)~2.78s2.83sp=0.371 n=6
Emit Time0.08s (± 0.00%)0.08s (± 0.00%)~0.08s0.08sp=1.000 n=6
Total Time8.34s (± 0.29%)8.36s (± 0.32%)~8.34s8.41sp=0.359 n=6
Angular - node (v16.17.1, x64)
Memory used365,277k (± 0.01%)365,280k (± 0.01%)~365,220k365,321kp=1.000 n=6
Parse Time3.55s (± 0.31%)3.54s (± 0.53%)~3.52s3.57sp=0.678 n=6
Bind Time1.18s (± 0.54%)1.18s (± 0.44%)~1.17s1.18sp=0.386 n=6
Check Time9.59s (± 0.35%)9.56s (± 0.55%)~9.48s9.63sp=0.421 n=6
Emit Time7.89s (± 0.83%)7.96s (± 0.69%)+0.07s (+ 0.89%)7.91s8.06sp=0.045 n=6
Total Time22.21s (± 0.41%)22.24s (± 0.45%)~22.09s22.35sp=0.575 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used192,811k (± 0.03%)192,745k (± 0.04%)~192,646k192,832kp=0.128 n=6
Parse Time1.59s (± 1.59%)1.58s (± 1.42%)~1.54s1.60sp=0.315 n=6
Bind Time0.82s (± 0.63%)0.82s (± 0.63%)~0.82s0.83sp=1.000 n=6
Check Time10.35s (± 0.53%)10.31s (± 0.39%)~10.26s10.37sp=0.199 n=6
Emit Time3.01s (± 0.62%)3.04s (± 0.32%)~3.02s3.05sp=0.059 n=6
Total Time15.78s (± 0.43%)15.76s (± 0.38%)~15.68s15.85sp=0.629 n=6
Monaco - node (v16.17.1, x64)
Memory used345,861k (± 0.00%)345,839k (± 0.01%)~345,809k345,862kp=0.078 n=6
Parse Time2.72s (± 0.28%)2.72s (± 0.38%)~2.71s2.73sp=0.348 n=6
Bind Time1.08s (± 0.70%)1.08s (± 0.48%)~1.08s1.09sp=0.784 n=6
Check Time7.88s (± 0.60%)7.87s (± 0.37%)~7.83s7.91sp=0.936 n=6
Emit Time4.48s (± 0.67%)4.50s (± 0.63%)~4.47s4.54sp=0.416 n=6
Total Time16.17s (± 0.35%)16.17s (± 0.27%)~16.12s16.23sp=0.936 n=6
TFS - node (v16.17.1, x64)
Memory used300,110k (± 0.01%)300,117k (± 0.01%)~300,095k300,155kp=0.688 n=6
Parse Time2.15s (± 0.64%)2.17s (± 0.58%)+0.02s (+ 1.17%)2.16s2.19sp=0.016 n=6
Bind Time1.23s (± 0.98%)1.25s (± 0.67%)~1.23s1.25sp=0.093 n=6
Check Time7.29s (± 0.73%)7.28s (± 0.39%)~7.23s7.31sp=0.935 n=6
Emit Time4.41s (± 1.17%)4.38s (± 0.62%)~4.35s4.42sp=0.569 n=6
Total Time15.08s (± 0.72%)15.07s (± 0.23%)~15.02s15.11sp=0.936 n=6
material-ui - node (v16.17.1, x64)
Memory used481,561k (± 0.02%)481,633k (± 0.01%)~481,606k481,671kp=0.066 n=6
Parse Time3.24s (± 0.50%)3.24s (± 0.16%)~3.24s3.25sp=0.451 n=6
Bind Time0.93s (± 0.59%)0.94s (± 0.86%)~0.94s0.96sp=0.054 n=6
Check Time17.87s (± 0.44%)17.88s (± 0.67%)~17.77s18.09sp=1.000 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time22.05s (± 0.38%)22.07s (± 0.57%)~21.95s22.30sp=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used560,374k (± 0.01%)560,481k (± 0.02%)~560,326k560,617kp=0.173 n=6
Parse Time3.98s (± 0.30%)4.00s (± 0.39%)+0.02s (+ 0.59%)3.97s4.01sp=0.035 n=6
Bind Time1.76s (± 0.56%)1.76s (± 0.56%)~1.75s1.78sp=1.000 n=6
Check Time3.06s (± 0.64%)3.06s (± 0.57%)~3.05s3.09sp=0.326 n=6
Emit Time0.09s (± 4.62%)0.09s (± 4.62%)~0.08s0.09sp=1.000 n=6
Total Time8.88s (± 0.26%)8.92s (± 0.18%)+0.03s (+ 0.38%)8.90s8.94sp=0.035 n=6
Angular - node (v14.21.3, x64)
Memory used359,301k (± 0.00%)359,286k (± 0.00%)~359,265k359,304kp=0.065 n=6
Parse Time3.67s (± 0.72%)3.67s (± 0.46%)~3.65s3.69sp=1.000 n=6
Bind Time1.21s (± 0.45%)1.21s (± 0.45%)~1.21s1.22sp=1.000 n=6
Check Time9.99s (± 0.59%)9.97s (± 0.20%)~9.95s10.00sp=0.747 n=6
Emit Time8.28s (± 0.73%)8.26s (± 0.63%)~8.21s8.35sp=0.334 n=6
Total Time23.16s (± 0.50%)23.12s (± 0.20%)~23.07s23.20sp=0.810 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used188,096k (± 0.01%)188,110k (± 0.01%)~188,069k188,141kp=0.378 n=6
Parse Time1.61s (± 1.00%)1.61s (± 0.78%)~1.60s1.63sp=1.000 n=6
Bind Time0.84s (± 0.65%)0.85s (± 1.43%)~0.85s0.88sp=0.054 n=6
Check Time10.41s (± 0.45%)10.49s (± 0.51%)+0.08s (+ 0.82%)10.43s10.57sp=0.030 n=6
Emit Time3.17s (± 1.46%)3.17s (± 1.30%)~3.11s3.21sp=0.687 n=6
Total Time16.03s (± 0.49%)16.13s (± 0.63%)~15.99s16.26sp=0.077 n=6
Monaco - node (v14.21.3, x64)
Memory used340,956k (± 0.01%)340,982k (± 0.01%)~340,935k341,008kp=0.149 n=6
Parse Time2.80s (± 0.61%)2.78s (± 0.20%)~2.78s2.79sp=0.100 n=6
Bind Time1.11s (± 1.36%)1.11s (± 0.88%)~1.10s1.13sp=0.801 n=6
Check Time8.17s (± 0.49%)8.15s (± 0.36%)~8.13s8.21sp=0.332 n=6
Emit Time4.71s (± 0.86%)4.72s (± 0.56%)~4.70s4.76sp=0.418 n=6
Total Time16.79s (± 0.47%)16.77s (± 0.36%)~16.73s16.88sp=0.808 n=6
TFS - node (v14.21.3, x64)
Memory used295,291k (± 0.00%)295,291k (± 0.00%)~295,284k295,301kp=1.000 n=6
Parse Time2.39s (± 0.51%)2.39s (± 0.77%)~2.36s2.41sp=1.000 n=6
Bind Time1.07s (± 0.38%)1.07s (± 0.84%)~1.06s1.08sp=0.787 n=6
Check Time7.61s (± 0.50%)7.59s (± 0.48%)~7.55s7.64sp=0.628 n=6
Emit Time4.33s (± 1.04%)4.35s (± 0.76%)~4.30s4.39sp=0.375 n=6
Total Time15.39s (± 0.40%)15.40s (± 0.34%)~15.31s15.46sp=1.000 n=6
material-ui - node (v14.21.3, x64)
Memory used477,204k (± 0.00%)477,184k (± 0.00%)~477,165k477,210kp=0.078 n=6
Parse Time3.33s (± 0.62%)3.32s (± 0.31%)~3.31s3.34sp=0.677 n=6
Bind Time1.00s (± 0.75%)1.00s (± 0.75%)~0.99s1.01sp=1.000 n=6
Check Time18.80s (± 0.58%)18.71s (± 0.29%)~18.65s18.80sp=0.078 n=6
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)~0.00s0.00sp=1.000 n=6
Total Time23.12s (± 0.54%)23.03s (± 0.28%)~22.95s23.14sp=0.149 n=6
xstate - node (v14.21.3, x64)
Memory used549,324k (± 0.00%)549,332k (± 0.00%)~549,300k549,351kp=0.261 n=6
Parse Time4.19s (± 0.25%)4.23s (± 1.10%)+0.04s (+ 0.96%)4.20s4.32sp=0.010 n=6
Bind Time1.66s (± 1.84%)1.63s (± 4.26%)~1.51s1.68sp=0.389 n=6
Check Time3.17s (± 0.91%)3.18s (± 0.65%)~3.14s3.20sp=0.519 n=6
Emit Time0.09s (± 0.00%)0.09s (± 4.45%)~0.09s0.10sp=0.405 n=6
Total Time9.10s (± 0.37%)9.13s (± 0.40%)~9.08s9.16sp=0.332 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
BenchmarkNameIterations
Current541176
Baselinemain6

TSServer

Comparison Report - main..54117
Metricmain54117DeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,524ms (± 0.41%)2,529ms (± 0.47%)~2,517ms2,543msp=0.470 n=6
Req 2 - geterr5,686ms (± 0.53%)5,693ms (± 0.40%)~5,658ms5,728msp=0.810 n=6
Req 3 - references344ms (± 0.90%)344ms (± 0.73%)~341ms347msp=0.870 n=6
Req 4 - navto282ms (± 0.91%)284ms (± 1.06%)~280ms289msp=0.292 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo85ms (± 0.96%)85ms (± 0.65%)~84ms85msp=0.088 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,625ms (± 0.58%)2,647ms (± 1.05%)~2,596ms2,672msp=0.109 n=6
Req 2 - geterr4,337ms (± 0.46%)4,324ms (± 1.67%)~4,181ms4,379msp=0.689 n=6
Req 3 - references348ms (± 0.67%)349ms (± 0.38%)~347ms351msp=0.323 n=6
Req 4 - navto289ms (± 0.67%)291ms (± 0.60%)~288ms293msp=0.124 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo64ms (± 4.07%)64ms (± 5.34%)~62ms71msp=0.934 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,047ms (± 0.46%)3,075ms (± 0.69%)~3,038ms3,091msp=0.054 n=6
Req 2 - geterr1,605ms (± 0.40%)1,609ms (± 0.66%)~1,591ms1,623msp=0.297 n=6
Req 3 - references106ms (± 0.97%)107ms (± 0.98%)~105ms108msp=0.801 n=6
Req 4 - navto362ms (± 0.14%)363ms (± 0.14%)+1ms (+ 0.28%)362ms363msp=0.018 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo377ms (± 1.39%)371ms (± 2.26%)~362ms385msp=0.108 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,658ms (± 0.69%)2,664ms (± 1.12%)~2,630ms2,706msp=0.936 n=6
Req 2 - geterr6,177ms (± 0.52%)6,174ms (± 0.55%)~6,139ms6,214msp=0.810 n=6
Req 3 - references354ms (± 1.03%)353ms (± 0.88%)~348ms357msp=0.687 n=6
Req 4 - navto284ms (± 1.48%)284ms (± 0.82%)~280ms287msp=0.678 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo86ms (± 5.82%)83ms (± 3.75%)~80ms87msp=0.288 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,808ms (± 0.64%)2,814ms (± 0.36%)~2,799ms2,823msp=0.630 n=6
Req 2 - geterr4,717ms (± 0.59%)4,713ms (± 0.49%)~4,693ms4,744msp=0.689 n=6
Req 3 - references364ms (± 0.71%)364ms (± 0.55%)~361ms366msp=0.681 n=6
Req 4 - navto285ms (± 1.07%)284ms (± 0.70%)~281ms286msp=0.467 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo67ms (± 1.13%)67ms (± 0.77%)~67ms68msp=0.241 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,201ms (± 0.33%)3,220ms (± 0.40%)+19ms (+ 0.59%)3,205ms3,240msp=0.031 n=6
Req 2 - geterr1,745ms (± 0.73%)1,741ms (± 0.40%)~1,735ms1,753msp=0.296 n=6
Req 3 - references123ms (± 0.86%)124ms (± 1.51%)~120ms125msp=0.166 n=6
Req 4 - navto341ms (± 0.60%)342ms (± 0.68%)~339ms345msp=0.808 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo399ms (± 1.69%)400ms (± 0.47%)~397ms402msp=0.469 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen2,770ms (± 0.41%)2,790ms (± 0.55%)+20ms (+ 0.72%)2,775ms2,812msp=0.031 n=6
Req 2 - geterr6,345ms (± 0.73%)6,361ms (± 0.76%)~6,277ms6,418msp=0.575 n=6
Req 3 - references364ms (± 0.33%)365ms (± 0.77%)~360ms368msp=0.373 n=6
Req 4 - navto290ms (± 0.72%)291ms (± 0.52%)~288ms292msp=0.330 n=6
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)~1,3561,356p=1.000 n=6
Req 5 - completionInfo99ms (± 8.78%)97ms (± 3.93%)~92ms101msp=0.170 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen2,956ms (± 0.36%)2,953ms (± 0.32%)~2,945ms2,967msp=0.470 n=6
Req 2 - geterr4,555ms (± 0.37%)4,580ms (± 0.55%)~4,542ms4,614msp=0.066 n=6
Req 3 - references378ms (± 0.55%)377ms (± 0.72%)~374ms382msp=0.807 n=6
Req 4 - navto298ms (± 0.35%)298ms (± 0.49%)~296ms300msp=1.000 n=6
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)~1,5181,518p=1.000 n=6
Req 5 - completionInfo77ms (± 0.67%)76ms (± 0.99%)~75ms77msp=0.247 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen3,478ms (± 0.49%)3,480ms (± 1.55%)~3,408ms3,543msp=0.378 n=6
Req 2 - geterr1,847ms (± 0.57%)1,840ms (± 0.63%)~1,822ms1,852msp=0.687 n=6
Req 3 - references149ms (± 8.26%)151ms (± 8.79%)~130ms161msp=0.872 n=6
Req 4 - navto398ms (± 1.78%)393ms (± 1.41%)~386ms400msp=0.377 n=6
Req 5 - completionInfo count2,862 (± 0.00%)2,862 (± 0.00%)~2,8622,862p=1.000 n=6
Req 5 - completionInfo435ms (± 0.98%)426ms (± 2.40%)~410ms439msp=0.108 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
BenchmarkNameIterations
Current541176
Baselinemain6

Startup

Comparison Report - main..54117
Metricmain54117DeltaBestWorstp-value
tsc-startup - node (v16.17.1, x64)
Execution time141.48ms (± 0.22%)141.35ms (± 0.20%)-0.13ms (- 0.09%)140.67ms144.82msp=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time220.18ms (± 0.17%)220.41ms (± 0.18%)+0.23ms (+ 0.10%)219.34ms225.64msp=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time221.47ms (± 0.15%)221.64ms (± 0.15%)+0.17ms (+ 0.08%)220.87ms225.31msp=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time203.45ms (± 0.15%)203.52ms (± 0.18%)~202.71ms208.91msp=0.198 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current541176
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 3, 2023

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham) Here are the results of running the top-repos suite comparing main and refs/pull/54117/merge:

Everything looks good!

weswigham
Wesley Wigham (weswigham) commented May 3, 2023
View reviewed changes
Comment threadsrc/compiler/checker.ts
case SyntaxKind.JsxNamespacedName:
return errorType; // FIXME: Remove when JsxNamespacedName is no longer used as an expression
case SyntaxKind.MissingDeclaration:
return errorType; // invalid decorated expression

@weswighamWesley Wigham (weswigham)May 3, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ron Buckton (@rbuckton) should this be an expression? It's not flagged by isExpressionNode, but is definitely assigned to expression-expecting node positions.

@rbucktonRon Buckton (rbuckton)May 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two different ways to test for expressions, so we may need to verify both are correct:

  • isExpression in utilitiesPublic.ts — Tests whether a Node is a subtype of Expression. Doesn't care about context (i.e., no .parent access). Designed for use with transformers (where .parent may not be set).
  • isExpressionNode in _utilities.ts — Tests whether a Node is used in an expression position. Highly contextual (performs .parent lookups). Used by the checker, though I'd love to find a way to retire it at some point.

@sandersn

Nathan Shively-Sanders (sandersn) commented May 13, 2025

Copy link
Copy Markdown
Member

Wesley Wigham (@weswigham) This looks like a strict improvement to me. Is there a reason not to merge this?

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

@github-project-automationgithub-project-automationBot moved this from Waiting on reviewers to Done in PR BacklogMar 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Awaiting requested review from DanielRosenwasser
@rbucktonRon Buckton (rbuckton)Awaiting requested review from rbuckton

Assignees

@weswighamWesley Wigham (weswigham)

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weswigham@typescript-bot@sandersn@rbuckton@RyanCavanaugh