Uh oh!
There was an error while loading. Please reload this page.
fix(54155): "Move to file" does not carry all function overload and implementation signatures - #54164
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoMay 24, 2023
Conversation
…n signatures to new files
navya9singh
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! Can you also add tests to verify that this change works for moveToFile as well and not just moveToNewFile?
Oleksandr Tarasiuk (a-tarasyuk)
commented
May 8, 2023
ContributorAuthor
navya9singh Sure. I've added additional tests |
Nathan Shively-Sanders (sandersn)
approved these changes
May 22, 2023
Member
navya9singh this looks ready to me, let me know if you agree. |
navya9singh
approved these changes
May 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#54155