Uh oh!
There was an error while loading. Please reload this page.
fix CI build - #54386
Merged
Jake Bailey (jakebailey) merged 2 commits intoMay 25, 2023
Merged
Conversation
Jake Bailey (jakebailey)
commented
May 25, 2023
Member
Fwiw I think we do normalize newlines sometimes in fourslash, if that's part of the issue. |
Oleksandr Tarasiuk (a-tarasyuk)
commented
May 25, 2023
ContributorAuthor
Jake Bailey (@jakebailey) The issue is to preserve the new line, from the target file. This PR #54164 conflicts with #54358 which was merged before. |
Oleksandr Tarasiuk (a-tarasyuk)
marked this pull request as ready for review
May 25, 2023 06:14
Uh oh!
There was an error while loading. Please reload this page.
Nathan Shively-Sanders (sandersn)
approved these changes
May 25, 2023
Member
Passes on my machine; I'll merge this when CI finishes. |
Jake Bailey (jakebailey)
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.