[wip] Shared resolutions in tsserver - #55968

Closed

Sheetal Nandi (sheetalkamat) wants to merge 26 commits into

mainfrom

sharedResolutions

Commits on May 16, 2025

Write log about unresolved imports calculation
Sheetal Nandi (sheetalkamat)
committed
31009c8
Add test when type acquisition changes
Sheetal Nandi (sheetalkamat)
committed
d81f147
Verify getUnresolvedImports incrementally
Sheetal Nandi (sheetalkamat)
committed
592bba4
Handle unnecessary typings request force just because root files change
Sheetal Nandi (sheetalkamat)
committed
cae589d
When type acquisition is disabled, remove the typing files set as root
Sheetal Nandi (sheetalkamat)
committed
3ae4463
Close watchers for TI that are no longer needed
Sheetal Nandi (sheetalkamat)
committed
e89404f
Update the unresolved import list only if it will be used
Sheetal Nandi (sheetalkamat)
committed
d839cae
Do not update typings for project if type aquisition is disabled
Sheetal Nandi (sheetalkamat)
committed
457d9b7
If typing installer is disabled invalidate all the resolutions from typings cache
Sheetal Nandi (sheetalkamat)
committed
f659bec
Use globalCacheResolution to invalidate resolutions on typings update
Sheetal Nandi (sheetalkamat)
committed
1637783
Update cached import list update as part of resolving modules instead of another pass
Sheetal Nandi (sheetalkamat)
committed
dad8851
If the there is no change detected in module resolution we shouldnt need to update last cached unresolved imports just because we have new program
Sheetal Nandi (sheetalkamat)
committed
cbbbf4a
Now that work with unresolved imports cleanup is done, remove the temp logging added
Sheetal Nandi (sheetalkamat)
committed
8e23cb4
unresolved imports of empty array and undefined are same
Sheetal Nandi (sheetalkamat)
committed
2a08064
Tests
Sheetal Nandi (sheetalkamat)
committed
c9dcebe
Add incremental test where cache should have same resolutions as whats in the program
Sheetal Nandi (sheetalkamat)
committed
2f52238
Make sure reused resolutions from file are accounted if all resolutions are reused/are resolved to ambient module names
Sheetal Nandi (sheetalkamat)
committed
3b993ff
In preparation of sharing resolutions, watch the resolutions right away instead of defering external module reoslutions to watch all failed lookup locations
Sheetal Nandi (sheetalkamat)
committed
254139c
Resolutions in cache stays for lifetime..
Sheetal Nandi (sheetalkamat)
committed
a51e79a
Handle package json lifetime
Sheetal Nandi (sheetalkamat)
committed
b3ab401
The redirected reference use that projects tsconfig directory as the root directory for watching resolutions
Sheetal Nandi (sheetalkamat)
committed
fb623b9

Navigation Menu

Uh oh!

[wip] Shared resolutions in tsserver - #55968

[wip] Shared resolutions in tsserver #55968
Sheetal Nandi (sheetalkamat) wants to merge 26 commits into
mainfrom
sharedResolutions

Commits on May 16, 2025

Write log about unresolved imports calculation

Add test when type acquisition changes

Verify getUnresolvedImports incrementally

Handle unnecessary typings request force just because root files change

When type acquisition is disabled, remove the typing files set as root

Close watchers for TI that are no longer needed

Update the unresolved import list only if it will be used

Do not update typings for project if type aquisition is disabled

If typing installer is disabled invalidate all the resolutions from typings cache

Use globalCacheResolution to invalidate resolutions on typings update

Update cached import list update as part of resolving modules instead of another pass

If the there is no change detected in module resolution we shouldnt need to update last cached unresolved imports just because we have new program

Now that work with unresolved imports cleanup is done, remove the temp logging added

unresolved imports of empty array and undefined are same

Tests

Add incremental test where cache should have same resolutions as whats in the program

Make sure reused resolutions from file are accounted if all resolutions are reused/are resolved to ambient module names

In preparation of sharing resolutions, watch the resolutions right away instead of defering external module reoslutions to watch all failed lookup locations

Resolutions in cache stays for lifetime..

Handle package json lifetime

The redirected reference use that projects tsconfig directory as the root directory for watching resolutions

Commits on May 17, 2025

Dont pollute resolution so we can reuse it across projects

Factor out cache to be shared and not shared. Projects still are not sharing caches

Real sharing across projects

Test cases for shared resolutions and effective type roots calculation

Handle effective type roots and type ref resolution sharing cache