Uh oh!
There was an error while loading. Please reload this page.
[wip] Shared resolutions in tsserver - #55968
Closed
Sheetal Nandi (sheetalkamat) wants to merge 26 commits into
Closed
[wip] Shared resolutions in tsserver #55968Sheetal Nandi (sheetalkamat) wants to merge 26 commits into
Sheetal Nandi (sheetalkamat) wants to merge 26 commits into
Conversation
TypeScript Bot (typescript-bot)
commented
Oct 3, 2023
Contributor
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up. |
Sheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
2 times, most recently
from
October 25, 2023 19:01
ad81eea to
a0f7406CompareSheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
5 times, most recently
from
November 14, 2023 23:15
6fe87d6 to
d947de4CompareSheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
2 times, most recently
from
November 28, 2023 22:10
bf1aaea to
73e6924CompareSheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
from
June 26, 2024 17:50
939f761 to
a797369Compare
This was referenced Jun 26, 2024
Sheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
5 times, most recently
from
July 3, 2024 19:42
e0b8659 to
a4bce9eCompareSheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
2 times, most recently
from
July 8, 2024 17:53
1fb73da to
5762b06CompareSheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
3 times, most recently
from
July 8, 2024 19:12
9846495 to
ce2e752CompareSheetal Nandi (sheetalkamat)force-pushed
the
sharedResolutions
branch
3 times, most recently
from
September 26, 2024 18:49
dc00f09 to
77da0deCompareFirst unresolved import gets the typing file into cache and sets it as root, This results in scheduling new typing request with that unresolved import missing The result will come back with typing file that is omitted, so root file will change but file will still be part of program so its not really removed from program
Also cache the inferred type acquition for inferred project
…ypings cache This change finally makes all tests pass incremental tests for matching resolutions and program structuture
…eed to update last cached unresolved imports just because we have new program
…s in the program This shows cache is holding onto resolutions that are no longer needed by program because either those modules arent present in file or is determined to be ambient resolution
…ns are reused/are resolved to ambient module names
…ay instead of defering external module reoslutions to watch all failed lookup locations
- All the package json watched are ref counted if watched - Not watched package json locations are released - First of this kind are when resolution from global cache fails, we dont watch those locations so not safe to have them cached - If we are looking for a file and the file is not found, the package json locations looked up are not watched
…root directory for watching resolutions
// TODO: update incremental tests to actually verify the cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still working and creating PR to do testing as i push commits
Rework of #55067