Uh oh!
There was an error while loading. Please reload this page.
In project, instead of iterating over program files to determine if file needs to be detached, do it through existing mechanism of releasing oldSourceFile - #59181
Merged
Conversation
… be detached, do it though existing mechanism of releasing oldSourceFile
Sheetal Nandi (sheetalkamat)
requested review from
Andrew Branch (andrewbranch) and Jake Bailey (jakebailey)July 8, 2024 18:54
Jake Bailey (jakebailey)
approved these changes
Jul 8, 2024
| /** @internal */ | ||
| onReleaseOldSourceFile( | ||
| oldSourceFile: SourceFile, | ||
| _oldOptions: CompilerOptions, |
There was a problem hiding this comment.
Is this parameter intentionally unused?
MemberAuthor
There was a problem hiding this comment.
yeah its used in services and is API so its unused here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another refactor found as part of working on #55968