Uh oh!
There was an error while loading. Please reload this page.
[Transforms] Merge master 06/06/2016 - #8991
Merged
Merged
Conversation
| context.enableSubstitution(SyntaxKind.Identifier); | ||
| context.enableSubstitution(SyntaxKind.BinaryExpression); | ||
| context.enableSubstitution(SyntaxKind.PrefixUnaryExpression); | ||
| context.enableSubstitution(SyntaxKind.PostfixUnaryExpression); |
Contributor
There was a problem hiding this comment.
You need to enable emit notification for source files so that you know the current source file during substitution.
… methods # Conflicts: # tests/cases/unittests/transpile.ts
(commandLineOptions_stringToEnum would be undefined if optionDeclarations wasn't loaded yet)
…n_clause minor fix: add missing return clause
…er-independent Primitive type guards are order independent
Yui (yuit)
commented
Jun 13, 2016
ContributorAuthor
Current following tests are failing:
|
| const sourceFileName = sourceFile ? sourceFile.fileName : undefined; | ||
| if (bindingNameExportSpecifiers && bindingNameExportSpecifiers[sourceFileName] && hasProperty(bindingNameExportSpecifiers[sourceFileName], left.text)) { | ||
| if (bindingNameExportSpecifiersForFileMap && | ||
| bindingNameExportSpecifiersForFileMap[currentSourceFileIdDuringSubstitution] && |
Contributor
There was a problem hiding this comment.
Can we store the result of this lookup in a local variable so we aren't performing the same lookup twice in a row?
Ron Buckton (rbuckton)
commented
Jun 14, 2016
Contributor
After you address this comment (and the related comments), 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.