.NET: fix: uri canonization in workflow http handler - #8406
Merged
Merged
Conversation
Vincent Biret (baywet)
deployed
to
github-app-auth
September 15, 2026 19:24 — with 
GitHub Actions
Active
Vincent Biret (baywet)
deployed
to
github-app-auth
September 15, 2026 19:24 — with
GitHub Actions
Active
Vincent Biret (baywet)
deployed
to
github-app-auth
September 15, 2026 19:24 — with
GitHub Actions
Active
Vincent Biret (baywet)
deployed
to
integration
September 15, 2026 19:24 — with
GitHub Actions
Active
Vincent Biret (baywet)
deployed
to
integration
September 15, 2026 19:24 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is focused, preserves request data, and includes appropriate regression coverage.
Pull request overview
Canonicalizes workflow HTTP request URIs before client selection, ensuring authorization and transport use the same effective URI.
Changes:
- Canonicalizes initial request URLs before invoking the provider.
- Adds regression coverage for dot-segment normalization.
File summaries
| File | Description |
|---|---|
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/DefaultHttpRequestHandler.cs |
Creates canonical request metadata before dispatch. |
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/DefaultHttpRequestHandlerTests.cs |
Verifies provider and transport receive matching canonical URLs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit df3cd96 in the Show a line coverage summary of the most covered files.
|
Vincent Biret (baywet)
marked this pull request as ready for review
September 16, 2026 10:53
Vincent Biret (baywet)
enabled auto-merge
September 16, 2026 10:53
Vincent Biret (baywet)
deployed
to
github-app-auth
September 16, 2026 10:53 — with
GitHub Actions
Active
Vincent Biret (baywet)
deployed
to
github-app-auth
September 16, 2026 10:54 — with
GitHub Actions
Active
SergeyMenshykh
approved these changes
Sep 16, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the request URI was not being normalized, which may lead to improper evaluations below.