Skip to content

.NET: tests(workflows): adds additional tests for metadata uri access - #8431

Closed
Vincent Biret (baywet) wants to merge 2 commits into
mainfrom
fix/canonical-url-metadata
Closed

Vincent Biret (baywet) wants to merge 2 commits into
mainfrom
fix/canonical-url-metadata

Conversation

@baywet

Copy link
Copy Markdown
Member

behaviour actually fixed in #8406, this only adds additional unit tests to prevent any potential regression

Copilot AI balanced review requested due to automatic review settings September 16, 2026 13:16
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Sep 16, 2026
@github-actions github-actions Bot changed the title tests(workflows): adds additional tests for metadata uri access .NET: tests(workflows): adds additional tests for metadata uri access Sep 16, 2026

This comment was marked as outdated.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): 1a427164ba15
Model: gpt-5.6-sol-fast

Overview

This test-only PR verifies that a URL resolved from System.LastMessageText, including a link-local metadata URL, reaches the configured HTTP request handler unchanged without performing a real network request. Existing DefaultHttpRequestHandler coverage independently verifies that the provider authorization callback and transport receive the same canonicalized URL, so the added boundary test does not leave a publishable Critical, High, or Medium concern.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit 1a42716 in the fix/canonical-url-me... branch is 84%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main fix/canonical-url-me... 1a42716 +/-
/home/runner/wo...valConverter.cs 100%
/home/runner/wo...entsProvider.cs 99%
/home/runner/wo...nticAnalyzer.cs 94%
/home/runner/wo...tClientAgent.cs 91%
/home/runner/wo...putConverter.cs 90%
/home/runner/wo...kflowBuilder.cs 90%
/home/runner/wo...kflowSession.cs 87%
/home/runner/wo...SkillsSource.cs 86%
/home/runner/wo...onExtensions.cs 81%
/home/runner/wo...ctionVisitor.cs 70%

Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed test-only changes add focused regression coverage with no unresolved issues.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants